Repository navigation
Conversation
Contributor
Member
|
What should happen to modesp's |
zrecore
added a commit
to femtoduino/micropython
that referenced
this pull request
Aug 24, 2019
Updating custom partitions CSV comments Removing 404 link in comments Adjusting partitions CSV for 2MiB ESP32 devices. Storage partition is now 0xA0000 (640KiB) Adding support for ESP32-D2WD (2MiB) for issue micropython#4986 Removing 404 link in comments Adjusting partitions CSV for 2MiB ESP32 devices. Storage partition is now 0xA0000 (640KiB) Implementing boards mpconfigboard files for generic ESP32-D2WD board type Rebase off upstream master branch. Adding support for ESP32-D2WD (2MiB) for issue micropython#4986 Git rebase off upstream master. Removing 404 link in comments What is this, recursion? Attempting to rebase off upstream master. Again. Adding support for ESP32-D2WD (2MiB) for issue micropython#4986 Removing 404 link in comments Removing merge conflict junk leftovers We no longer need some of the changes once we rebase off PR micropython#5027. FLASH_USER_START and FLASH_SIZE removed. No need for gitignore modifications Removing left over edit to README Rolling back changes to modesp, updating partitions-2MiB.csv to name storage partition as vfs Undoing changes to gitignore Renaming board config for generic ESP32-D2WD
Member
Author
|
Ok, merged in 31de447
Probably best to just deprecate them. The start of the vfs partition can be obtained from the Partition object. |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Jul 21, 2021
Only push `main` builds to S3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the newly-added
esp32.Partitionclass to replace the existingFlashBdevclass. Partition objects implement the block protocol so can be directly mounted viauos.mount(). This has the following benefits:partitions.csv, and overridden by a particular boardpartitions.csvNote that this patch is fully backwards compatible: existing filesystems remain untouched and work with this new code.