Type guards in Array.prototype.every

TypeScript Version: 2.2.2

Code

function isNumber(x: any): x is number { return typeof(x) === "number"; }

let numbersOrStrings: (number | string)[] = [1, 2, 3, 4];

if(numbersOrStrings.every(isNumber)) {
    let _numbers: number[] = numbersOrStrings;
    // ...
}

Expected behavior:

When every member of numberOfStrings matches the isNumber type guard, the whole array should be inferred to be numberOfStrings: number[]; so, the above code should compile without error.

Actual behavior:

The above fails to compile, with the following error:

error TS2322: Type '(string | number)[]' is not assignable to type 'number[]'.

This issue is similar to #7657, and it can be solved by adding something like the following to lib.d.ts:

interface Array<T> {
    every<U extends T>(pred: (a: T) => a is U): this is U[];
}

(or, the above can be added locally to a project as a temporary workaround)

This issue is similar to #7657,

It's not the same, though. filter creates a new array, every doesn't. Assigning (string | number)[] to a number[] is unsafe, because a string can be pushed at any moment.

Vladimir Kurchatkin (@vkurchatkin)

Vladimir Kurchatkin (@vkurchatkin) Would adding the above declaration for ReadonlyArray<T> be safe, then?

Kyle Lacy (@kylewlacy)

Kyle Lacy (@kylewlacy) yes, I think so

Added overload to ReadonlyArray.prototype.every to make it a type gua…

related to #5101

#16069 now tracks inferring the type guard automatically.

Navigation Menu

Repository navigation

Type guards in Array.prototype.every #14963

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Type guards in Array.prototype.every #14963

Description

Activity

vkurchatkin commented on Apr 1, 2017

kylewlacy commented on Apr 2, 2017

vkurchatkin commented on Apr 3, 2017

mhegazy commented on May 2, 2018

mhegazy commented on May 2, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions