Repository navigation
add special check for parameter initializer lookup if targeting es2015+ - #26317
Merged
Ryan Cavanaugh (RyanCavanaugh) merged 2 commits intoAug 28, 2018
Merged
Ryan Cavanaugh (RyanCavanaugh) merged 2 commits into
Ryan Cavanaugh (RyanCavanaugh) merged 2 commits into
Conversation
Klaus Meinhardt (ajafff)
suggested changes
Aug 10, 2018
| // to make sure that they reference no variables declared after them. | ||
| useResult = | ||
| // parameter initializer will lookup as normal variable scope when targeting es2015+ | ||
| if (compilerOptions.target && compilerOptions.target >= ScriptTarget.ES2015 && isParameter(lastLocation) && lastLocation.initializer === originalLocation && result.valueDeclaration !== lastLocation) { |
Contributor
There was a problem hiding this comment.
I didn't mention this in the original issue, but that's not limited to parameter intializers. It's basically every expression that could occur in a ParameterDeclaration. For example a ComputedPropertyName:
let foo = 0;
(function test({[foo]: bar}: any[]) {
let foo = 1;
console.log(bar); // logs 'a'
})(['a', 'b'])
Contributor
Author
There was a problem hiding this comment.
This is too desperate🤷♂️
Wenlu Wang (Kingwl)
force-pushed
the
parameter-initializer-lookup-fix
branch
from
August 28, 2018 08:52
c2351f5 to
8869f39
Compare
Member
|
Ryan Cavanaugh (@RyanCavanaugh) probably worth noting that even though this is a bugfix, it is also a breaking change. Also, in the context of parameter properties it doesn't make sense (ie, it is wrong), since those will still get downleveled, eg: class Foo {
constructor(public x = 12, public y = x.toFixed()) {}
}we have breaks in RWC along these lines. |
Member
|
Filed #26719 to track the regression. |
This was referenced Aug 29, 2018
Ryan Cavanaugh (RyanCavanaugh)
added a commit
to RyanCavanaugh/TypeScript
that referenced
this pull request
Aug 31, 2018
…ration for a clean PR fixing all the issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22769