Repository navigation
Added menu arrow after nextcloud/server#3282 - #60
Merged
Merged
Conversation
skjnldsv
requested review from
ChristophWurst,
MorrisJobke,
jancborchardt and
nickvergessen
January 26, 2017 15:00
MorrisJobke
previously requested changes
Jan 26, 2017
|
|
||
| /* Menu arrow */ | ||
| .notification-container:after { | ||
| right: 53px; |
Member
There was a problem hiding this comment.
This needs to be done in JS I think:
Member
Author
There was a problem hiding this comment.
How did I missed that... On it... -_-
Member
Author
|
@MorrisJobke Fixed! 馃帀 |
Member
Author
|
Narrow screen is broken |
Member
|
|
Member
Author
|
@nickvergessen That what I said! ^^ |
Member
|
I just reposted it, because morris canceled it. |
Member
Author
|
I don't think we can do without js this time :/ |
Member
|
@skjnldsv check out nextcloud/server#4074 - with that the name is removed, so we can set a fixed spot for the triangle. :) |
Signed-off-by: John Molakvo忙 (skjnldsv) <[email protected]>
Signed-off-by: John Molakvo忙 (skjnldsv) <[email protected]>
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
jancborchardt
force-pushed
the
menu-arrow
branch
from
March 27, 2017 10:50
d60ffa2 to
bcca803
Compare
Member
|
Fixed: Please review @skjnldsv @nickvergessen :) |
nickvergessen
approved these changes
Mar 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following nextcloud/server#3282
@nextcloud/designers