Repository navigation
Merge similar properties and standardize the arrow to the menu class - #3282
Merged
Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
added
3. to review
skjnldsv
requested review from
ChristophWurst,
MorrisJobke,
jancborchardt and
nickvergessen
January 26, 2017 14:59
skjnldsv
added a commit
to nextcloud/notifications
that referenced
this pull request
Jan 26, 2017
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
|
@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChristophWurst to be a potential reviewer. |
skjnldsv
added a commit
to nextcloud/notifications
that referenced
this pull request
Jan 26, 2017
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
MorrisJobke
approved these changes
Jan 26, 2017
MorrisJobke
left a comment
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
Tested and works - but doesn't fix #3274 entirely (because the PR from the notification repo is needed as well;))
Member
Author
|
You're right. This is a split pr! :) |
ChristophWurst
added
4. to release
Member
|
Failing CI run seems unrelated |
Member
Author
|
Restarted the test |
jancborchardt
pushed a commit
to nextcloud/notifications
that referenced
this pull request
Mar 27, 2017
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
nickvergessen
added a commit
to nextcloud/notifications
that referenced
this pull request
Mar 27, 2017
Added menu arrow after nextcloud/server#3282
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixref #3274@nextcloud/designers