Repository navigation
Lots of SVG source files broken since svgo optimization #4076
Description
Activity
@jancborchardt sure, I'll take a look at it. Assigning myself on this if you don't mind, @skjnldsv
Reacted by Jan C. Borchardt and John Molakvoæ@pixelipo awesome, thank you!
Thank you @pixelipo! :) Most should be possible to fix by getting the state before the PR I mentioned above.
- added a commit that references this issue
on Nov 6, 2017 TO DO:
- optimize remaining
actionsicons Optimize SVG icons #7130 - optimize
categoriesicons Re-optimize filetype and category icons #7194 - optimize
filetypesicons Re-optimize filetype and category icons #7194 - optimize
placesicons Re-optimize places and files icons #7188 - optimize 'files' icons Re-optimize places and files icons #7188
- optimize remaining icons Re-optimize and clean up settings, social and logo icons #7209
- optimize remaining
I have to fix other folders as well - see previous comment. At @MorrisJobke suggestion, I will split it across multiple PRs so it's easier to test.
Reacted by Jan C. Borchardt and John MolakvoæThanks @pixelipo for all your effort 👍
Reacted by John Molakvoæ and BugsbaneIcons in
core/img/,apps/files/img/andsettings/img/folder have been optimized and cleaned up. In the process, I've managed to cut their size considerably, from 145 kB to 79 kB, without losing quality. It won't make a big difference, but still...Lots of them have also been fixed for better consistency.
Reacted by John Molakvoæ and Morris JobkeReacted by John Molakvoæ, Morris Jobke and Jan C. Borchardt@pixelipo thank you sooo much for fixing this and the optimization! :) Was a big "design debt" issue.
Reacted by Marin Treselj
When wanting to edit some icons, I stumbled upon this issue:
This seems to be caused by the SVGO optimization: #1534
While they seem to be correctly displayed, Inkscape has big problems showing them correctly. There’s a reason we use Scour as per https://github.com/nextcloud/server/blob/master/core/img/image-optimization.sh#L10 and not SVGO. ;)
cc @skjnldsv could you check it out? In doubt I’d say your PR needs to be reverted and we should do it via Scour instead – which was already used on most of the icons.