Repository navigation
Lots of SVG source files broken since svgo optimization #4076
Description
When wanting to edit some icons, I stumbled upon this issue:
This seems to be caused by the SVGO optimization: #1534
While they seem to be correctly displayed, Inkscape has big problems showing them correctly. There’s a reason we use Scour as per https://github.com/nextcloud/server/blob/master/core/img/image-optimization.sh#L10 and not SVGO. ;)
cc @skjnldsv could you check it out? In doubt I’d say your PR needs to be reverted and we should do it via Scour instead – which was already used on most of the icons.
Activity
jancborchardt commentedon Jun 19, 2017
@pixelipo while you’re at optimizing, maybe you can look into reverting #1534 and recompressing the icons using Scour instead (which is not as lossy as SVGO apparently). cc @skjnldsv
pixelipo commentedon Jun 20, 2017
@jancborchardt sure, I'll take a look at it. Assigning myself on this if you don't mind, @skjnldsv
jancborchardt commentedon Jun 20, 2017
@pixelipo awesome, thank you!
skjnldsv commentedon Sep 24, 2017
Is this done? @pixelipo
pixelipo commentedon Oct 19, 2017
I'm working on it, @skjnldsv . There are a lot of files to be fixed...
jancborchardt commentedon Oct 19, 2017
Thank you @pixelipo! :) Most should be possible to fix by getting the state before the PR I mentioned above.
skjnldsv commentedon Oct 19, 2017
sorry @pixelipo I was asking because I was working on something related last month. It wasn't meant to be a reminder, sorry for the poor choice of words! :)
Thanks for your awesome work!
Fixes #4076 - first batch of fixed and re-optimized icons
pixelipo commentedon Nov 13, 2017
TO DO:
actionsicons Optimize SVG icons #7130categoriesicons Re-optimize filetype and category icons #7194filetypesicons Re-optimize filetype and category icons #7194placesicons Re-optimize places and files icons #7188pixelipo commentedon Nov 14, 2017
I have to fix other folders as well - see previous comment. At @MorrisJobke suggestion, I will split it across multiple PRs so it's easier to test.
MorrisJobke commentedon Nov 18, 2017
Thanks @pixelipo for all your effort 👍
pixelipo commentedon Nov 20, 2017
Icons in
core/img/,apps/files/img/andsettings/img/folder have been optimized and cleaned up. In the process, I've managed to cut their size considerably, from 145 kB to 79 kB, without losing quality. It won't make a big difference, but still...Lots of them have also been fixed for better consistency.
jancborchardt commentedon Nov 22, 2017
@pixelipo thank you sooo much for fixing this and the optimization! :) Was a big "design debt" issue.