Repository navigation
meta: document commit msg exception for long URLs - #20207
Closed
vsemozhetbyt wants to merge 1 commit into
Closed
vsemozhetbyt wants to merge 1 commit into
vsemozhetbyt wants to merge 1 commit into
Conversation
vsemozhetbyt
added
meta
Contributor
Author
|
Please, add 👍 here to approve fast-tracking. |
Contributor
Author
BridgeAR
approved these changes
Apr 22, 2018
BridgeAR
added
the
author ready
lpinca
approved these changes
Apr 22, 2018
trivikr
approved these changes
Apr 22, 2018
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 22, 2018
PR-URL: #20207 Fixes: #17116 Refs: nodejs/core-validate-commit#24 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Contributor
Author
|
Landed in 2060787 |
jasnell
pushed a commit
that referenced
this pull request
Apr 23, 2018
PR-URL: #20207 Fixes: #17116 Refs: nodejs/core-validate-commit#24 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesFixes: #17116
Refs: nodejs/core-validate-commit#24