ENH: add keyword nrows to genfromtxt, closes #5084 - #5093

I think the code is ready to go, although some other eyes are welcome!

There are a few issues though before we can merge this:

• You are working from the master branch of your forked repository. That is not the way we do things around here! You should be working on a feature branch, take a look at the development workflow docs, more specifically here.
• Commit messages should also follow the guidelines here, this one should probably be something like ENH: add keyword nrowstogenfromtxt, closes #5084

On a separate note, you didn't have to close #5090 and send a new PR, just push a new commit to your repository. That makes it easier to follow the discussion for others. Although you probably will have to create a new PR to fix the branch issue on this one.

I don't think we actually care about the feature branch thing -
understanding how to use feature branches is a good idea because they make
life easier when writing the code (esp. when you have more than one
change at different stages of progress), but from the reviewer's
perspective it doesn't make a difference, so there's no need to fix it here
unless you want to.
On 21 Sep 2014 15:26, "Jaime" [email protected] wrote:

I think the code is ready to go, although some other eyes are welcome!

There are a few issues though before we can merge this:

You are working from the master branch of your forked repository. That
is not the way we do things around here! You should be working on a feature
branch, take a look at the development workflow docs
http://docs.scipy.org/doc/numpy/dev/gitwash/development_workflow.html,
more specifically here
http://docs.scipy.org/doc/numpy/dev/gitwash/development_workflow.html#making-a-new-feature-branch
.

Commit messages should also follow the guidelines here
http://docs.scipy.org/doc/numpy/dev/gitwash/development_workflow.html#writing-the-commit-message,
this one should probably be something like ENH: add keyword nrows to
genfromtxt, closes #5084

On a separate note, you didn't have to close #5090
#5090 and send a new PR, just push a
new commit to your repository. That makes it easier to follow the
discussion for others. Although you probably will have to create a new PR
to fix the branch issue on this one.

—
Reply to this email directly or view it on GitHub
#5093 (comment).

I don't think we actually care about the feature branch thing

It does cause problems long term in keeping the local master in sync with upstream. The best way to do that is to only update master from upstream. For a one-off PR, it doesn't really matter, but hopefully new contributors will make more than one PR .

@jaimefrio

You are working from the master branch of your forked repository. That is not the way we do things around here! You should be working on a feature branch, take a look at the development workflow docs, more specifically here.

Thanks for your comments. I'm not familar with github workflow, I'll follow the guide the next time.
And, what can I do for this PR? Can I change it to feature branch or something?

Closing this. The fun continues in #5103 and the mailing list.