Skip to content

aix compat fixes for ocsp.c - #5657

Closed
covener wants to merge 1 commit into
openssl:masterfrom
covener:aixcompat
Closed

aix compat fixes for ocsp.c#5657
covener wants to merge 1 commit into
openssl:masterfrom
covener:aixcompat

Conversation

@covener

@covener covener commented Mar 17, 2018

Copy link
Copy Markdown
Contributor

WCOREDUMP() and vsyslog are not portable

This was the only thing i needed to build master on AIX w/ xlc.

@covener
aix compat fixes for ocsp.c
1d325c4 
WCOREDUMP and vsyslog are not portable
@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement. label Mar 17, 2018
@covener

covener commented Mar 18, 2018

Copy link
Copy Markdown
Contributor Author

Is there some way to explicitly mark this as trivial?

@richsalz

richsalz commented Mar 18, 2018

Copy link
Copy Markdown
Contributor

You have to put "CLA: trivial" in the commit message text (commit --amend) and the reviewers have to agree that it's trivial.

@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement. label Mar 18, 2018
@dot-asm dot-asm added branch: master Applies to master branch approval: review pending This pull request needs review by a committer 1.1.0 labels Mar 18, 2018
@dot-asm

dot-asm commented Mar 18, 2018

Copy link
Copy Markdown
Contributor

Just in case, not merge commits are allowed, so some one will go in.

@dot-asm

dot-asm commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

Just in case, not merge commits are allowed, so some one will go in.

It shows that it was late hour. I meant "no merge commits are allowed, so only one will go in".

@dot-asm dot-asm mentioned this pull request Mar 19, 2018
Closed
mattcaswell
mattcaswell requested changes Mar 19, 2018
View reviewed changes

@mattcaswell mattcaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would approve the change (subject to the merge commit being removed as per comment from @dot-asm), but I do not agree that this is trivial. Please could you submit a CLA?

@covener

covener commented Mar 19, 2018

Copy link
Copy Markdown
Contributor Author

Thanks all and sorry for the trouble on both fronts, I'll get both sorted.

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement. label Mar 19, 2018
@dot-asm

dot-asm commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

One can also simply let @paulidale do similar thing for HP-UX in #5658.

@richsalz

richsalz commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

open/close to kick the CLA bot.

@richsalz richsalz closed this Mar 19, 2018
@richsalz richsalz reopened this Mar 19, 2018
@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement. label Mar 19, 2018
@richsalz richsalz closed this Mar 19, 2018
@richsalz richsalz reopened this Mar 19, 2018
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement. label Mar 19, 2018
@paulidale

paulidale commented Mar 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

I'll merge when unfrozen

@dot-asm dot-asm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Mar 19, 2018
@mattcaswell mattcaswell added this to the 1.1.1 milestone Mar 20, 2018
levitte pushed a commit that referenced this pull request Mar 20, 2018
@covener @paulidale
aix compat fixes for ocsp.c
a9dd51a 
WCOREDUMP and vsyslog are not portable

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
(Merged from #5657)
@paulidale

paulidale commented Mar 20, 2018

Copy link
Copy Markdown
Contributor

Merged to master, thanks.
Not merged to 1.1.0 because the multi-threaded support has been.

@paulidale paulidale closed this Mar 20, 2018
@paulidale paulidale removed 1.1.0 approval: done This pull request has the required number of approvals labels Mar 20, 2018
@covener
covener deleted the aixcompat branch March 30, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes
@paulidale paulidale paulidale approved these changes
+1 more reviewer
@dot-asm dot-asm dot-asm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch: master Applies to master branch

Projects

None yet

Milestone

1.1.1

Development

Successfully merging this pull request may close these issues.

6 participants

@covener @richsalz @dot-asm @paulidale @mattcaswell @openssl-machine