Conversation
paulidale
added
the
approval: review pending
Contributor
|
AIX people work harder [in #5657] |
Contributor
Author
|
That doesn't help strsignal. |
Contributor
|
Well, strsignal appears to be quite recent addition to POSIX, so that one can always argue that it totally should be conditional, as in #ifdef _POSIX_C_SOURCE >= 200809L. Alternatively I wouldn't feel bad if it was simply omitted to avoid the spaghetti... |
Contributor
Author
|
I've changed this so it only conditions out strsignal, the vsyslog is fixed by #5657 |
paulidale
changed the title
Contributor
Author
|
I'm not seeing how the test failures could be related... |
Contributor
Author
|
A rebuild and the failure disappeared. OMC review? |
Contributor
|
I would have just always and only printed the signal number (the else condition). Anything else seems not worth it. |
The strsignal call is not supported by some machines, so avoid its use.
Contributor
Author
|
Okay, just printing the signal number now. |
richsalz
approved these changes
Mar 21, 2018
paulidale
added
approval: done
levitte
pushed a commit
that referenced
this pull request
Mar 21, 2018
The strsignal call is not supported by some machines, so avoid its use. Reviewed-by: Rich Salz <[email protected]> (Merged from #5658)
Contributor
Author
|
Merged, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HP-UX does not support the system call strsignal.
Checked for Itanium HP-UX 11i v3.
The alternative would be to supply our own versions of the two missing calls.
Broken by 3e3c7c3 earlier this month.