Skip to content

Change clobber keyword - #510

Merged
wtgee merged 4 commits into
panoptes:developfrom
wtgee:fits-clobber-warning
May 8, 2018
Merged

Change clobber keyword#510
wtgee merged 4 commits into
panoptes:developfrom
wtgee:fits-clobber-warning

Conversation

@wtgee

@wtgee wtgee commented Apr 6, 2018

Copy link
Copy Markdown
Member

@wtgee
wtgee requested a review from a team April 6, 2018 23:17
@codecov

codecov Bot commented Apr 6, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #510 into develop will decrease coverage by 0.07%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #510      +/-   ##
===========================================
- Coverage    67.92%   67.85%   -0.08%     
===========================================
  Files           62       62              
  Lines         5419     5419              
  Branches       752      752              
===========================================
- Hits          3681     3677       -4     
- Misses        1541     1544       +3     
- Partials       197      198       +1
Impacted Files Coverage Δ
pocs/utils/images/cr2.py 0% <ø> (ø) ⬆️
pocs/utils/images/fits.py 77.27% <0%> (ø) ⬆️
pocs/utils/config.py 90.47% <100%> (ø) ⬆️
pocs/serial_handlers/protocol_arduinosimulator.py 75.38% <0%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a2338...911abba. Read the comment docs.

jamessynge
jamessynge approved these changes Apr 8, 2018
View reviewed changes

@jamessynge jamessynge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, it seems like most or all uses of clobber in POCS could be changed to overwrite.

@jamessynge

jamessynge commented Apr 8, 2018

Copy link
Copy Markdown
Contributor

Looks like we also need to change PIAA.

@jamessynge

jamessynge commented Apr 8, 2018

Copy link
Copy Markdown
Contributor

Do we need to update requirements to select the correct (updated) version of astropy?

wtgee added 2 commits April 9, 2018 09:59
@wtgee
Updating all instances of clobber with overwrite, including in
9f8c634 
`save_config` functions. Left a few in the `database.py` file but it
should probably just removed as stale.
@wtgee
Upping astropy requirements
db222d0
@wtgee

wtgee commented Apr 9, 2018

Copy link
Copy Markdown
Member Author

FWIW, it seems like most or all uses of clobber in POCS could be changed to overwrite.

Good call, I got them all now.

Looks like we also need to change PIAA.

I'll have a PR for that shortly.

Do we need to update requirements to select the correct (updated) version of astropy?

I went ahead and did this. I've been running 3.x for a bit now and haven't seen any issues. Can revert if think it's going to be a problem or want in separate PR.

@wtgee wtgee mentioned this pull request May 1, 2018
Merged
jamessynge pushed a commit that referenced this pull request May 7, 2018
@wtgee @jamessynge
* Updating astropy dependency #510 (#515)
39a2338 
* Locking pycodestyle until fix in #511, #512, #514
@wtgee
wtgee merged commit 7824c20 into panoptes:develop May 8, 2018
@wtgee
wtgee deleted the fits-clobber-warning branch May 8, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamessynge jamessynge jamessynge approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wtgee @jamessynge