Skip to content

Really deprecate clobber keyword in FITS now - #6203

Merged
bsipocz merged 1 commit into
astropy:masterfrom
pllim:rm-fits-pending-dep
Jun 15, 2017
Merged

Really deprecate clobber keyword in FITS now#6203
bsipocz merged 1 commit into
astropy:masterfrom
pllim:rm-fits-pending-dep

Conversation

@pllim

@pllim pllim commented Jun 14, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Remove "pending" status introduced by #5761. Fix #5773.

Note: I canceled Travis CI on purpose to save resources (long queue). Check https://travis-ci.org/pllim/astropy/builds/242938845 for actual test result.

@pllim pllim added this to the v2.0.0 milestone Jun 14, 2017
@pllim
pllim requested review from MSeifert04 and saimn June 14, 2017 17:54
@bsipocz

bsipocz commented Jun 14, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Adding the last-before-release label, with the same logic I mentioned for the analytic functions, namely that this is really a last-before-branching/RC1, so affiliates will run into issues within a bit shorter timerange.

@pllim
pllim force-pushed the rm-fits-pending-dep branch from c7cd36e to ee0ffda Compare June 14, 2017 17:58
@pllim

pllim commented Jun 15, 2017

Copy link
Copy Markdown
Member Author

Travis tests on my fork passed.

@bsipocz

bsipocz commented Jun 15, 2017

Copy link
Copy Markdown
Member

@pllim - Revisiting my arguments above, shall we just start merging these deprecations? So if any issue comes up, we get some extra time to fix it without delaying RC too much.

@pllim

pllim commented Jun 15, 2017

Copy link
Copy Markdown
Member Author

It is your call since you are doing the release. Personally I am okay with merging now. If people complain, they can pin to 1.3.3.

@bsipocz

bsipocz commented Jun 15, 2017

Copy link
Copy Markdown
Member

OK. Lets do this and the rest as well.

@bsipocz
bsipocz merged commit dc89b4d into astropy:master Jun 15, 2017
@pllim
pllim deleted the rm-fits-pending-dep branch June 15, 2017 14:09
@saimn

saimn commented Jun 15, 2017

Copy link
Copy Markdown
Contributor

Thanks for taking care if this @pllim ! (I see only now your review request, sorry!)

@MSeifert04

MSeifert04 commented Jun 16, 2017

Copy link
Copy Markdown
Contributor

LGTM!

I'm on vacation until monday so I'm sorry I haven't seen this sooner. :(

@pllim pllim mentioned this pull request Jul 1, 2017
Merged
@wtgee wtgee mentioned this pull request Apr 6, 2018
Merged
wtgee added a commit to panoptes/POCS that referenced this pull request May 8, 2018
@wtgee
Change clobber keyword (#510)
7824c20 
astropy/astropy#6203

Updating all instances of `clobber` with `overwrite`, including in
`save_config` functions. Left a few in the `database.py` file but it
should probably just removed as stale.
@pllim pllim mentioned this pull request Jul 1, 2020
Merged
20 tasks done
eerovaher added a commit to eerovaher/astropy that referenced this pull request Oct 18, 2021
@eerovaher
Remove the clobber argument from io.fits
b87b9ee 
The  `clobber` argument has been deprecated since astropy#6203.
@eerovaher eerovaher mentioned this pull request Oct 18, 2021
Merged
9 tasks
eerovaher added a commit to eerovaher/astropy that referenced this pull request Oct 19, 2021
@eerovaher
Remove the clobber argument from io.fits
f5a37ea 
The  `clobber` argument has been deprecated since astropy#6203.
eerovaher added a commit to eerovaher/astropy that referenced this pull request Nov 9, 2021
@eerovaher
Remove the clobber argument from io.fits
e44889e 
The  `clobber` argument has been deprecated since astropy#6203.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saimn saimn Awaiting requested review from saimn
@MSeifert04 MSeifert04 Awaiting requested review from MSeifert04

Assignees

No one assigned

Labels

io.fits Last-before-release Refactoring

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pllim @bsipocz @saimn @MSeifert04