Skip to content

fix: v0.11 housekeeping — Plugin Checker compliance (closes #130, #131, #132, #133) - #198

Merged
ivdimova merged 1 commit into
devfrom
fix/v0-11-housekeeping
May 12, 2026
Merged

ivdimova merged 1 commit into
devfrom
fix/v0-11-housekeeping

Conversation

@pluginslab

Copy link
Copy Markdown
Owner

Summary

First of the WP.org-submission PRs. Four mechanical Plugin Checker fixes bundled into one small change.

Net: -235 / +7 lines, 4 files touched.

Closes

Issue Title Fix
#133 Remove or relocate `CLOUDFEST_HACKATHON.md` before release Removed from `.distpackage` so it stops shipping. File stays in the repo for archival reference. Also deleted `docs/FEEDBACK-DEV.md` (stale documentation for the feedback system removed in PR #195).
#132 Fix nonexistent "Domain Path" in plugin header Dropped `Domain Path: /languages` from `wp-agentic-admin.php` header. The directory doesn't exist and WP.org-hosted plugins don't need it (translations auto-load from translate.wordpress.org).
#131 Remove deprecated `load_plugin_textdomain()` call Removed the call + the private method that wrapped it + its caller in `init()`. Replaced with a brief explanatory comment.
#130 Prefix global variables in `uninstall.php` Renamed `$sites` → `$wp_agentic_admin_sites` and `$site` → `$wp_agentic_admin_site` in the multisite cleanup branch.

Verification

  • `composer lint` — clean (no errors, no warnings)
  • `npm test` — 96 passing, 0 changed
  • `grep "Domain Path|load_plugin_textdomain"` returns only the explanatory comment
  • `grep '\$sites|\$site\\b' uninstall.php` returns nothing (all prefixed)
  • `.distpackage` no longer references `CLOUDFEST_HACKATHON.md`

What's still queued for v0.11

After this lands, the remaining WP.org blockers are:

Test plan

  • Build check passes
  • PHP lint passes
  • JS lint passes (no JS changed but should remain clean)
  • Unit tests pass (96)
  • Manual: confirm a build via `npm run dist` (or equivalent) produces a zip that does NOT contain `CLOUDFEST_HACKATHON.md` or `docs/FEEDBACK-DEV.md`

🤖 Generated with Claude Code

…prefix uninstall globals

Bundles four small Plugin Checker fixes ahead of the WordPress.org
submission path.

Resolves #133:
  - Remove CLOUDFEST_HACKATHON.md from .distpackage so it doesn't ship.
    File stays in the repo for archival reference.
  - Also delete docs/FEEDBACK-DEV.md (stale documentation for the
    feedback system removed in PR #195).

Resolves #132:
  - Drop the "Domain Path: /languages" header from wp-agentic-admin.php.
    The languages/ directory doesn't exist in the repo, and the header
    isn't needed for WP.org-hosted plugins (translations are auto-loaded
    from translate.wordpress.org).

Resolves #131:
  - Remove the load_plugin_textdomain() call. WordPress 4.6+ loads
    translations automatically for plugins hosted on WordPress.org, so
    the call is flagged by the Plugin Checker as a discouraged function.
    Replaced the now-empty private method + its caller with a brief
    explanatory comment.

Resolves #130:
  - Prefix $sites and $site in the multisite cleanup branch of
    uninstall.php to $wp_agentic_admin_sites / $wp_agentic_admin_site.
    Satisfies WordPress.NamingConventions.PrefixAllGlobals.

Tests: 96 passing, 0 changed (mechanical fixes only).
PHP lint: clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

@ivdimova ivdimova left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All compliance and cleanup — no functional changes. Domain Path removal, load_textdomain() drop, uninstall global prefixing, and hackathon doc exclusion from dist are all correct.

@ivdimova
ivdimova merged commit 70f70c7 into dev May 12, 2026
4 checks passed
@ivdimova
ivdimova deleted the fix/v0-11-housekeeping branch May 12, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants