Repository navigation
gh-133656: Remove unused import in Lib/zipimport.py - #140325
Merged
brettcannon merged 3 commits intoOct 20, 2025
Merged
Conversation
Signed-off-by: yihong0618 <[email protected]>
yihong0618
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
October 19, 2025 06:09
Member
|
Last usage was removed in 5c6937a |
StanFromIreland
left a comment
StanFromIreland
left a comment
Member
There was a problem hiding this comment.
On lines 13 and 14 we have two commented out imports that exist since the module's Python re-write. I think we can remove them too.
Signed-off-by: yihong0618 <[email protected]>
Contributor
Author
thanks and deleted |
StanFromIreland
changed the title
StanFromIreland
changed the title
Lib/zipimport.py
brettcannon
approved these changes
Oct 20, 2025
brettcannon
enabled auto-merge (squash)
October 20, 2025 19:17
brettcannon
disabled auto-merge
October 20, 2025 19:17
brettcannon
enabled auto-merge (squash)
October 20, 2025 19:17
Member
|
Thanks! |
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also drop the import and maybe a tiny performance up(
can skip news
zipimport.zipimporter.load_module#133656