Repository navigation
Isinstance for if expressions - #896
Merged
Merged
Conversation
If we have an expression of the form "not instance" then we can recurse and just switch the else and if expressions. We might as well take this opportunity.
We simply check for isinstance when visiting conditionals and correctly push for the if/else expressions, giving them new types only for those particular expressions. After that, the type of the variable being modified returns to its original type.
Contributor
|
What about |
Collaborator
Author
|
See comment in Adding this would require modifying |
Collaborator
|
Yeah, multiple |
Collaborator
|
Looks good, thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#806