Repository navigation
Conversation
The fix I found was to use io.h when building with msvc. unistd.h should be for unix or mingw builds.
|
CC: @cgohlke |
|
I didn't notice since I have an empty |
|
Does this have any relation to the changes that were recently included for windows builds in #652? @aclark4life -- be careful on the merge, this isn't against master. |
|
I'm not sure why we'd want this if not for master… |
|
Sorry, I didn’t realize the push should go to master. Should I redo the pull request and target master? I thought 2.3.x would be a dev branch and master was official release. I’ll test what happens if I eliminate the #include block all together since Gohlke said his include file is empty. From: wiredfool [mailto:[email protected]] Does this have any relation to the changes that were recently included for windows builds in #652#652? @aclark4lifehttps://github.com/aclark4life -- be careful on the merge, this isn't against master. — |
|
@jamesra Yes please resubmit to master |
|
2.3.x is an old release (though it's the one that's in the Ubuntu LTS.), 2.4 is the current released version, and master is steaming towards 2.5. You may want to recheck that you need this based on the current state of master. |
|
OK, I originally tested on the master branch and switched when a pull request was wanted. I’ll switch to master, test removing the #include entirely, and then resubmit whatever works. From: wiredfool [mailto:[email protected]] 2.3.x is an old release (though it's the one that's in the Ubuntu LTS.), 2.4 is the current released version, and master is steaming towards 2.5. You may want to recheck that you need this based on the current state of master. — |
4 participants
To build Pillow in Windows with MSVC I had to include io.h instead of unistd.h. unistd.h should work for mingw builds. How this change effects other platforms is unknown. The change was requested in Issue #672 (#672)