Repository navigation
Conversation
Member
|
Note that no current python is actually built with VC2012, 3.4 is still on 2010, and most of the older pythons that we support are on VC2008. |
Author
|
OK, I have all the MSVS versions installed. I just verified the behavior in VC2008 was identical to VC2012. From: wiredfool [mailto:[email protected]] Note that no current python is actually built with VC2012, 3.4 is still on 2010, and most of the older pythons that we support are on VC2008. — |
Merged
Member
|
Included in #704 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the conservative choice and only removed the #include <unistd.h> for Windows. It can probably be removed entirely but didn't have a testing platform with another compiler.
Issue #697