Repository navigation
Conversation
|
I am not sure we should go this way. I thought the idea is to generate the list of candidates normally (without considering fuzzy) and apply the fuzzying only once the completion list has been show to reduce the number of items shown in the popup? So after the completion menu has been shown with all matches initially? Otherwiese I am not sure it makes sense for completion methods like thesaurus completion, whole line completion, dictionary, spelling or tags completion. In the end, that's why we have different completion methods for and if you want to gather a list of completions using fuzzy matching, one can omni-completion or user-defined completion. |
|
It actually makes sense to apply fuzzy initially when gathering completion candidates as well. At least I would expect it to happen. Also #14921 |
|
removing edit on
Internally we differentiate between completion behaviors and modes. But for users they think they are all the same, so that's why they want to see fuzzy results in some default completions as well. I don't have any opinion with it, because I don't use keyword completion very often. If need support, I will try my best. |
25b5353 to
e8d0ae9
Compare
|
I tried to make fuzzy support for original pattern at the end. It works fine. But I don't use some default completions very often. So not sure if it's broken or some patterns don't work. Might need some testing and feedback. Thanks |
|
alright, convinced :) |
563a9c9 to
a60c1f2
Compare
|
Thanks for this feature. My primary completion method is keyword completion. When I start typing I am fairly certain about first character of the word I want to be completed. I get the candidates starting with that character and fuzzy match the word I want. Too many candidates will be generated if we generate them as well with fuzzy. Which may slow down the completion. I would suggest generate candidates with fuzzy under another option such as |
|
so maybe we can use a separate sub-option 'fuzzysearch' for the 'completeopt' option then? |
|
Yes |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Let the people have it if they want it |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Ping me when there is a result and I will implement it |
|
yeah, let's have another option value for 'completeopt' that determines how the candidates for the completion-menu are collected. It may be called 'fuzzysearch' or 'fuzzycollect' then (not good on names), but it seems good to give people the chance on how they want the completion to work. Thanks! |
|
Thanks. I vote for |
This comment was marked as off-topic.
This comment was marked as off-topic.
c84745b to
44e096b
Compare
glepnir
changed the title
1f6c7e9 to
f121421
Compare
|
so this is ready? |
|
Any other questions about the code? @zeertzjq I'm not sure if this is a result of discussion, |
|
No complaints? I take that as a general agreement :) Thanks everybody! |
Problem: cannot use fuzzy keyword completion
(Maxim Kim)
Solution: add the fuzzycollect value for the 'completeopt'
setting, to gather matches using fuzzy logic (glepnir)
fixes: vim/vim#14912
closes: vim/vim#14976
vim/vim@43eef88
Problem: cannot use fuzzy keyword completion
(Maxim Kim)
Solution: add the fuzzycollect value for the 'completeopt'
setting, to gather matches using fuzzy logic (glepnir)
fixes: vim/vim#14912
closes: vim/vim#14976
vim/vim@43eef88
Problem: cannot use fuzzy keyword completion
(Maxim Kim)
Solution: add the fuzzycollect value for the 'completeopt'
setting, to gather matches using fuzzy logic (glepnir)
fixes: vim/vim#14912
closes: vim/vim#14976
vim/vim@43eef88
Problem: cannot use fuzzy keyword completion
(Maxim Kim)
Solution: add the fuzzycollect value for the 'completeopt'
setting, to gather matches using fuzzy logic (glepnir)
fixes: vim/vim#14912
closes: vim/vim#14976
vim/vim@43eef88
Problem: cannot use fuzzy keyword completion
(Maxim Kim)
Solution: add the fuzzycollect value for the 'completeopt'
setting, to gather matches using fuzzy logic (glepnir)
fixes: vim/vim#14912
closes: vim/vim#14976
vim/vim@43eef88
Problem: cannot use fuzzy keyword completion
(Maxim Kim)
Solution: add the fuzzycollect value for the 'completeopt'
setting, to gather matches using fuzzy logic (glepnir)
fixes: vim/vim#14912
closes: vim/vim#14976
vim/vim@43eef88
vim-patch:9.1.0503: cannot use fuzzy keyword completion
Problem: cannot use fuzzy keyword completion
(Maxim Kim)
Solution: add the "fuzzycollect" value for the 'completeopt'
setting, to gather matches using fuzzy logic (glepnir)
fixes: vim/vim#14912
closes: vim/vim#14976
vim/vim@43eef88
vim-patch:9.1.0549: fuzzycollect regex based completion not working as expected
Problem: fuzzycollect regex based completion not working as expected
Solution: Revert Patch v9.1.0503 (glepnir)
closes: vim/vim#15192
vim/vim@600a12d
Co-authored-by: glepnir <[email protected]>
vim-patch:9.1.0503: cannot use fuzzy keyword completion
Problem: cannot use fuzzy keyword completion
(Maxim Kim)
Solution: add the "fuzzycollect" value for the 'completeopt'
setting, to gather matches using fuzzy logic (glepnir)
fixes: vim/vim#14912
closes: vim/vim#14976
vim/vim@43eef88
vim-patch:9.1.0549: fuzzycollect regex based completion not working as expected
Problem: fuzzycollect regex based completion not working as expected
Solution: Revert Patch v9.1.0503 (glepnir)
closes: vim/vim#15192
vim/vim@600a12d
Co-authored-by: glepnir <[email protected]>
6 participants
initial attempt we can generate a fuzzy matching regular expression here and give it to searchit. then keyword completion CTRL-N CTRL-P can get a fuzzy result and set into match array.
Fix #14912