Repository navigation
revert: patch 9.1.0503 - #15192
Closed
glepnir wants to merge 1 commit into
Closed
revert: patch 9.1.0503#15192glepnir wants to merge 1 commit into
glepnir wants to merge 1 commit into
Conversation
zeertzjq
reviewed
Jul 9, 2024
zeertzjq
reviewed
Jul 9, 2024
Member
|
thanks! |
RestorerZ
pushed a commit
to RestorerZ/fork_vim-orig
that referenced
this pull request
Jul 9, 2024
…pected Problem: fuzzycollect regex based completion not working as expected Solution: Revert Patch v9.1.0503 (glepnir) closes: vim#15192 Signed-off-by: glepnir <[email protected]> Signed-off-by: Christian Brabandt <[email protected]>
Member
|
This change from patch 9.1.0503 hasn't been reverted: diff --git a/src/insexpand.c b/src/insexpand.c
index c673df927..78fea5127 100644
--- a/src/insexpand.c
+++ b/src/insexpand.c
@@ -4100,8 +4100,7 @@ find_comp_when_fuzzy(void)
int is_backward = compl_shows_dir_backward();
compl_T *comp = NULL;
- if (compl_match_array == NULL ||
- (is_forward && compl_selected_item == compl_match_arraysize - 1)
+ if ((is_forward && compl_selected_item == compl_match_arraysize - 1)
|| (is_backward && compl_selected_item == 0))
return compl_first_match;
Does it need to be? |
Member
Author
|
find_next_completion_match has checked the array is not NULL so there no need revert. |
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Jul 10, 2024
vim-patch:9.1.0503: cannot use fuzzy keyword completion
Problem: cannot use fuzzy keyword completion
(Maxim Kim)
Solution: add the "fuzzycollect" value for the 'completeopt'
setting, to gather matches using fuzzy logic (glepnir)
fixes: vim/vim#14912
closes: vim/vim#14976
vim/vim@43eef88
vim-patch:9.1.0549: fuzzycollect regex based completion not working as expected
Problem: fuzzycollect regex based completion not working as expected
Solution: Revert Patch v9.1.0503 (glepnir)
closes: vim/vim#15192
vim/vim@600a12d
Co-authored-by: glepnir <[email protected]>
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Jul 10, 2024
vim-patch:9.1.0503: cannot use fuzzy keyword completion
Problem: cannot use fuzzy keyword completion
(Maxim Kim)
Solution: add the "fuzzycollect" value for the 'completeopt'
setting, to gather matches using fuzzy logic (glepnir)
fixes: vim/vim#14912
closes: vim/vim#14976
vim/vim@43eef88
vim-patch:9.1.0549: fuzzycollect regex based completion not working as expected
Problem: fuzzycollect regex based completion not working as expected
Solution: Revert Patch v9.1.0503 (glepnir)
closes: vim/vim#15192
vim/vim@600a12d
Co-authored-by: glepnir <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fuzzy can handle keyword completion as well. so fuzzycollect is no longer needed.