Skip to content

[volt get -u] Don't change 'repos/trx_id' if no other properties are changed #149

Description

@tyru
No description provided.

Activity

  1. last-partizan commented on Mar 14, 2018

    @last-partizan
    Contributor

    Would be great to see this implemented.

    It will make storing lockfile in git and syncing better. Any plans for this one?

    Looks like this is simple enough issue, maybe i'll try to fix it. However it'll take a time, i have no expirience with go beyond tutorial.

  2. tyru commented on Mar 15, 2018

    @tyru
    MemberAuthor

    Contribution is welcome!
    Currently I'm not planning to fix this issue soon, because this is not so annoying for me :p
    That's great if you could help fixing this :)

  3. last-partizan commented on Mar 15, 2018

    @last-partizan
    Contributor

    Nice!
    May i ask, why there is need to store that trx_id at all? other package managers, like yarn, don't store anything like that.

  4. tyru commented on Mar 15, 2018

    @tyru
    MemberAuthor

    Well, at first, that property is added because vim-volt plugin can detect which plugins are installed/updated.
    After that, vim-volt plugin reloads installed/updated plugins to take effect in current Vim, without restarting Vim.

    But now, trx_id and repos[].trx_id are indeed not necessary.
    It is for vim-volt plugin, but the plugin can detect it without trx_id, such as saving previous hashes and checking updated hashes, and added plugins.

  5. last-partizan commented on Mar 15, 2018

    @last-partizan
    Contributor

    Great!
    I'll take a look.

  6. added a commit that references this issue on Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions