Skip to content

Removed trx_id/TrxID (issue #149) - #201

Merged
tyru merged 5 commits into
vim-volt:develfrom
last-partizan:master
Mar 17, 2018
Merged

tyru merged 5 commits into
vim-volt:develfrom
last-partizan:master

Conversation

@last-partizan

Copy link
Copy Markdown
Contributor

Here it is.

I just removed trx_id/TrxID and code using it.

Checked rm/get commands, working fine.

I cannot run make test becouse it was asking for github passwords.

@tyru

tyru commented Mar 16, 2018 •

Copy link
Copy Markdown
Member

Great! Thanks :)

  • Would you change base branch to devel ?
  • Would you rebase or merge devel ?
    • This should fix failing CI

@last-partizan
last-partizan changed the base branch from master to devel March 16, 2018 15:58
@last-partizan

Copy link
Copy Markdown
Contributor Author

Changed base branch to devel

@tyru

tyru commented Mar 17, 2018

Copy link
Copy Markdown
Member

Please rebase or merge devel?
I want to check if CI succeeds (in devel, appveyor config problem is fixed #204).

@last-partizan

Copy link
Copy Markdown
Contributor Author

Looks like it worked!

@tyru
tyru merged commit 9c9ae78 into vim-volt:devel Mar 17, 2018
@tyru

tyru commented Mar 17, 2018

Copy link
Copy Markdown
Member

Seems good, thanks :)

tyru added a commit that referenced this pull request Mar 30, 2018
tyru added a commit that referenced this pull request Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants