Repository navigation
Follow up to astropy 3.1.1 unit bug fix - #596
Conversation
mpmath.polylog no longer fails on large values. This seems to have been fixed by mpmath 1.1.0 https://github.com/fredrik-johansson/mpmath/blob/475527a7b5d373d702021d4cd11a0b43ba29eb48/CHANGES
|
Some lingering issues with dev versions of numpy, which looks a bit like something on the conda side... |
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
=========================================
Coverage ? 96.58%
=========================================
Files ? 49
Lines ? 4506
Branches ? 0
=========================================
Hits ? 4352
Misses ? 154
Partials ? 0
Continue to review full report at Codecov.
|
|
Hello @StanczakDominik! Thanks for updating your pull request. Congratulations! There are no PEP8 issues in this pull request. 😸 Comment last updated on January 04, 2019 at 17:21 Hours UTC |
|
EDIT: this is a comment to my previous commit, "Revert "Update Type Hint Annotations for Consistency (#586)". It got Bloody hell. This is exactly what we get for not dealing with the astropy unit bug earlier and pushing to master on broken tests. My bad, apologies >_< What happened here is that I was so sure #586 was fine since tests were failing but that PR did nothing related to the astropy 3.1.0 unit optimization bug, so it was fine to merge it. It wasn't! That pull request triggered the To sum up, when I was in high school I used to play Command and Conquer 3 online a lot, in team games. In fact, that's where I picked up most of my english. There was this guy nicknamed Ulkrond whom me and my group met up with often, whose most memorable quote that we had many a laugh about was "Your hubris shall be your downfall". And, well, turns out that indeed it was. |
6cbd9fa to
f13c4d2
Compare
This brings back the change from PlasmaPy#590, which got obsoleted.
This reverts commit 97d7fd3. The bug it addresses is getting a fix in PlasmaPy#596.
|
The good thing about version control and open development is that it makes it more straightforward to fix things like this when issues arise. Thank you for making these fixes! And as I like to say, getting things wrong is the first step towards getting things right! |
I guess f8fac84 was broken in that it provided two mentions of astropy and this is causing conflicts.
Closes #589 and closes #587 too.