Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Initial pass at handling post_meta based on feedback in #68. - #168

Merged
rachelbaker merged 3 commits into
masterfrom
post-meta-handling
May 24, 2014
Merged

Initial pass at handling post_meta based on feedback in #68.#168
rachelbaker merged 3 commits into
masterfrom
post-meta-handling

Conversation

@rachelbaker

@rachelbaker rachelbaker commented May 4, 2014

Copy link
Copy Markdown
Member

No description provided.

tlovett1 and others added 3 commits May 3, 2014 17:57
@tlovett1
Post meta handler; Allow for updating, adding, and deleting of post m…
9be17a8 
…eta. Filter for passing sanitization callbacks; filter for requiring santizition callbacks. This method assumes values are passed as they are intended to be stored (array or single). In response to #68

Remove sanitization callback functionality - see #68
@rachelbaker
Pulled in post_meta progress from tlovett1 in #167.
2cd3565
@rachelbaker
Added methods to verify post meta should be updated or added.
e4438c9
@rachelbaker

rachelbaker commented May 4, 2014

Copy link
Copy Markdown
Member Author

@rmccue Please review the progress here for post_meta handling.

@tlovett1

tlovett1 commented May 4, 2014

Copy link
Copy Markdown
Member

Looks good. Although, I think we should at least allow for arrays to be updated/added to post meta.

@rmccue

rmccue commented May 5, 2014

Copy link
Copy Markdown
Member

Looks good. Although, I think we should at least allow for arrays to be updated/added to post meta.

👎 for now, I want to make sure we skip serialized data completely for now until we can consider it a bit more. There's always 1.1 and afterwards! :)

rmccue
rmccue reviewed May 5, 2014
View reviewed changes
Comment thread lib/class-wp-json-posts.php

@rmccue rmccue May 5, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we refactor this out? A generic can_set_meta that we can reuse, and fold this into handle_post_meta_action instead.

@rmccue

rmccue commented May 5, 2014

Copy link
Copy Markdown
Member

If we're doing to change the format of post_meta for update/creation, we should change the format from retrieval (prepare_meta) too. :)

rmccue
rmccue reviewed May 5, 2014
View reviewed changes
Comment thread lib/class-wp-json-posts.php

@rmccue rmccue May 5, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use a different code and message, since it's not actually an invalid action.

@rmccue rmccue added this to the 1.0 milestone May 5, 2014
@rmccue

rmccue commented May 5, 2014

Copy link
Copy Markdown
Member

Cool; looking like a good start, and reasonably simple for now. 🎆

I'll also post this to the o2 for feedback, as we need to get this right.

@rachelbaker rachelbaker mentioned this pull request May 8, 2014
Closed
This was referenced May 12, 2014
Closed
Merged
@rmccue

rmccue commented May 12, 2014

Copy link
Copy Markdown
Member

Posted for feedback on the o2.

@rmccue rmccue mentioned this pull request May 22, 2014
Merged
@rachelbaker
rachelbaker merged commit e4438c9 into master May 24, 2014
rachelbaker added a commit that referenced this pull request May 24, 2014
@rachelbaker
Merge pull request #207 from WP-API/post-meta-handling-v4
b545556 
Add ability to add, update, delete post_meta.  Fixes #68.  Closes #189 and #168.
@rmccue
rmccue deleted the post-meta-handling branch May 25, 2014 01:53
kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014
@rachelbaker
Merge pull request WP-API#207 from WP-API/post-meta-handling-v4
3a52be3 
Add ability to add, update, delete post_meta.  Fixes WP-API#68.  Closes WP-API#189 and WP-API#168.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@rachelbaker rachelbaker

Labels

Enhancement

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@rachelbaker @tlovett1 @rmccue