This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Repository navigation
Third pass at handling post meta - #189
Merged
Merged
Conversation
Member
Author
|
Posted for feedback on the o2. |
kellbot
pushed a commit
to kellbot/WP-API
that referenced
this pull request
Aug 1, 2014
Add ability to add, update, delete post_meta. Fixes WP-API#68. Closes WP-API#189 and WP-API#168.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pass at post meta builds off the previous (#168, #188), but changes the format around.
When retrieving meta:
{ "ID": 13, "post_meta": [ { "ID": 33, "key": "my_meta_key", "value": "My value!" } ] }To update, you just change the value and send it back:
{ "ID": 13, "post_meta": [ { "ID": 33, "key": "my_meta_key", "value": "My new value!" } ] }To add a new value, you add an object to the array without an ID:
{ "ID": 13, "post_meta": [ { "key": "another_key", "value": "Another value" } ] }To delete a value, you set the key and value to
null:{ "ID": 13, "post_meta": [ { "ID": 33, "key": null, "value": null } ] }Side-effect: you can rename meta keys by changing the
keywhen updating, as it's no longer used as the primary key.Disadvantages: This cannot be read from the meta cache. I don't see this being a huge issue, as it's only exposed on
context=edit.Fixes #68.