Repository navigation
Fourth pass at post meta handler - #207
Conversation
|
I successfully tested viewing post_meta, adding single value meta keys and values, and editing/adding array values for meta keys. @tlovett1 would you be able to test this code as well? Next steps:
|
|
Yes, I'll test. |
|
I tested edit/create/delete. Everything worked well except changing a key without changing the value. Do we have unit tests for this yet? |
The ID should be in the meta_id field anyway.
These cases are handled by the underlying add_meta/update_meta, so there's no need for them here.
|
We're now at 95% minimum code coverage for meta methods; can't test the internal @rachelbaker Can we hit those extra docs in 1.1 instead? If so, let's #reviewmerge and ship 1.0. |
|
Let's add the extra docs in 1.1, I will review right after breakfast. On Saturday, May 24, 2014, Ryan McCue [email protected] wrote:
Rachel Baker |
…outes. Relates to WP-API#213 and WP-API#207.
Add ability to add, update, delete post_meta. Fixes WP-API#68. Closes WP-API#189 and WP-API#168.
Fixes #68. Continued from #168, #189 based on feedback from the o2.