Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Fourth pass at post meta handler - #207

Merged
rachelbaker merged 36 commits into
masterfrom
post-meta-handling-v4
May 24, 2014
Merged

rachelbaker merged 36 commits into
masterfrom
post-meta-handling-v4

Conversation

@rmccue

@rmccue rmccue commented May 22, 2014

Copy link
Copy Markdown
Member

Fixes #68. Continued from #168, #189 based on feedback from the o2.

@rmccue rmccue added this to the 1.0 milestone May 22, 2014
@rmccue rmccue self-assigned this May 22, 2014
@rachelbaker

Copy link
Copy Markdown
Member

I successfully tested viewing post_meta, adding single value meta keys and values, and editing/adding array values for meta keys.

@tlovett1 would you be able to test this code as well?

Next steps:

  • add functionality docs for post_meta
  • HATEOAS links

@tlovett1

Copy link
Copy Markdown
Member

Yes, I'll test.

@tlovett1

Copy link
Copy Markdown
Member

I tested edit/create/delete. Everything worked well except changing a key without changing the value. Do we have unit tests for this yet?

@rachelbaker

Copy link
Copy Markdown
Member

@rmccue #review 1eee8b9 and 710aac6

Still needed POST /post/ and PUT /post/id post_meta data parameter details. Blocked by merge of #212 that includes data parameter details for those routes.

@rmccue

rmccue commented May 24, 2014

Copy link
Copy Markdown
Member Author

We're now at 95% minimum code coverage for meta methods; can't test the internal add_post_meta/update_metadata_by_mid/delete_metadata_by_mid responses, since we check for those cases beforehand anyway.

@rachelbaker Can we hit those extra docs in 1.1 instead? If so, let's #reviewmerge and ship 1.0.

@rmccue rmccue assigned rachelbaker and unassigned rmccue May 24, 2014
@rachelbaker

Copy link
Copy Markdown
Member

Let's add the extra docs in 1.1, I will review right after breakfast.

On Saturday, May 24, 2014, Ryan McCue [email protected] wrote:

We're now at 95% minimum code coverage for meta methods; can't test the
internal add_post_meta/update_metadata_by_mid/delete_metadata_by_midresponses, since we check for those cases beforehand anyway.

@rachelbaker https://github.com/rachelbaker Can we hit those extra docs
in 1.1 instead? If so, let's #reviewmerge and ship 1.0.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/207#issuecomment-44081981
.

Rachel Baker

rachelbaker added a commit that referenced this pull request May 24, 2014
Add ability to add, update, delete post_meta.  Fixes #68.  Closes #189 and #168.
@rachelbaker
rachelbaker merged commit b545556 into master May 24, 2014
@rachelbaker
rachelbaker deleted the post-meta-handling-v4 branch May 24, 2014 13:46
kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014
kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014
kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014
Add ability to add, update, delete post_meta.  Fixes WP-API#68.  Closes WP-API#189 and WP-API#168.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants