Repository navigation
Conversation
JeanMeche
commented
Feb 26, 2023
Member
Author
There was a problem hiding this comment.
It's acceptable to have this todo removed without comment : It's common to have non-null assertions on inputs in spec files.
JeanMeche
force-pushed
the
compiler-24571
branch
from
February 26, 2023 23:26
56e276c to
7c19308
Compare
atscott
requested changes
Feb 27, 2023
JeanMeche
force-pushed
the
compiler-24571
branch
from
February 27, 2023 18:19
7c19308 to
6c40c13
Compare
atscott
approved these changes
Feb 27, 2023
This was referenced Feb 27, 2023
jessicajaniuk
added
the
area: compiler
Member
Author
|
@dgp1130 By any chance could you have a look in the next few days ? |
Contributor
|
I think @AndrewKushnir would have stronger feelings than I do, and he should be able to given the |
AndrewKushnir
approved these changes
Apr 18, 2023
This commit removes the remaining TODO(issue/24571) in compiler code base.
AndrewKushnir
force-pushed
the
compiler-24571
branch
from
April 18, 2023 00:43
6c40c13 to
d29b87b
Compare
AndrewKushnir
added
action: presubmit
Contributor
jessicajaniuk
added
action: merge
Contributor
|
This PR was merged into the repository by commit d4ef207. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looking to tackle the ~200ish TODOs related to #24571 to finally close it.
This commit removes the remaining ones in compiler code base
Does this PR introduce a breaking change?
See also the PRs about #24571 :