Skip to content

refactor: handle #24571 todos for examples/platform-server/elements - #49233

Closed
JeanMeche wants to merge 3 commits into
angular:mainfrom
JeanMeche:chore/misc-24571
Closed

JeanMeche wants to merge 3 commits into
angular:mainfrom
JeanMeche:chore/misc-24571

Conversation

@JeanMeche

@JeanMeche JeanMeche commented Feb 27, 2023 •

Copy link
Copy Markdown
Member

This PR removes the remaining TODO(issue/24571) in the platform-server, examples & elements code base.

See individual commits, it's 1 one file per mentioned package. I didn't want to waist the time of the caretaker by doing an individual PR for each one ! 馃槉

See also the PRs about #24571 :

*#48241

This commit removes the remaining TODO(issue/24571) in elements code base.
@JeanMeche JeanMeche changed the title Chore/misc 24571 refactor: handle #24571 todos for examples/platform-server/elements Feb 27, 2023
This commit removes a TODO(issue/24571) that leaking into the docs examples
This commit removes the remaining TODO(issue/24571) in platform-server code base.
@ngbot ngbot Bot added this to the Backlog milestone Feb 27, 2023
@JeanMeche
JeanMeche marked this pull request as ready for review February 27, 2023 22:37
@pullapprove
pullapprove Bot requested a review from dylhunn February 27, 2023 22:37
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 28, 2023
@AndrewKushnir

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 8869289.

AndrewKushnir pushed a commit that referenced this pull request Feb 28, 2023
This commit removes a TODO(issue/24571) that leaking into the docs examples

PR Close #49233
AndrewKushnir pushed a commit that referenced this pull request Feb 28, 2023
This commit removes the remaining TODO(issue/24571) in platform-server code base.

PR Close #49233
AndrewKushnir pushed a commit that referenced this pull request Feb 28, 2023
This commit removes the remaining TODO(issue/24571) in elements code base.

PR Close #49233
AndrewKushnir pushed a commit that referenced this pull request Feb 28, 2023
This commit removes a TODO(issue/24571) that leaking into the docs examples

PR Close #49233
AndrewKushnir pushed a commit that referenced this pull request Feb 28, 2023
This commit removes the remaining TODO(issue/24571) in platform-server code base.

PR Close #49233
@JeanMeche
JeanMeche deleted the chore/misc-24571 branch February 28, 2023 19:01
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants