Skip to content

refactor(platform-browser): handle #24571 todos - #49232

Closed
JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:chore/pf-browser-24571
Closed

refactor(platform-browser): handle #24571 todos#49232
JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:chore/pf-browser-24571

Conversation

@JeanMeche

@JeanMeche JeanMeche commented Feb 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This was referenced Feb 27, 2023
Closed
Closed
Closed
Closed
Closed
@JeanMeche
JeanMeche marked this pull request as ready for review February 27, 2023 22:37
@pullapprove
pullapprove Bot requested a review from dylhunn February 27, 2023 22:37
AndrewKushnir
AndrewKushnir reviewed Feb 28, 2023
View reviewed changes
Comment thread packages/platform-browser/src/dom/events/event_manager.ts Outdated
@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Feb 28, 2023
@ngbot ngbot Bot modified the milestone: Backlog Feb 28, 2023
@JeanMeche
JeanMeche force-pushed the chore/pf-browser-24571 branch from b6c7bc9 to 8989cd8 Compare March 4, 2023 18:26
AndrewKushnir
AndrewKushnir reviewed Mar 5, 2023
View reviewed changes

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeanMeche thanks for the cleanup! Just left a minor comment.

Comment thread packages/platform-browser/src/dom/events/event_manager.ts Outdated
Comment thread packages/platform-browser/src/dom/events/event_manager.ts Outdated
@JeanMeche
refactor(platform-browser): handle angular#24571 todos
de93ab8 
This commit removes the remaining TODO(issue/24571) in platform-browser code base.
@JeanMeche
JeanMeche force-pushed the chore/pf-browser-24571 branch from 8989cd8 to de93ab8 Compare March 5, 2023 22:21
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 5, 2023
@AndrewKushnir
AndrewKushnir removed the request for review from dylhunn March 5, 2023 22:22
@AndrewKushnir

AndrewKushnir commented Mar 5, 2023

Copy link
Copy Markdown
Contributor

Caretaker note: very low risk change, no presubmit required.

@jessicajaniuk

jessicajaniuk commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 06b0003.

jessicajaniuk pushed a commit that referenced this pull request Mar 6, 2023
@JeanMeche @thePunderWoman
refactor(platform-browser): handle #24571 todos (#49232)
1822585 
This commit removes the remaining TODO(issue/24571) in platform-browser code base.

PR Close #49232
@JeanMeche
JeanMeche deleted the chore/pf-browser-24571 branch March 8, 2023 08:50
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Apr 8, 2023

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@JeanMeche @AndrewKushnir @jessicajaniuk