Repository navigation
MAINT CI: delete passing tests' tmp_path (Windows out of disk); acceptance on 3.13 - #1251
Merged
bruAristimunha merged 7 commits intoOct 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated docstrings still provide an incorrect two-dimensional shape guarantee for scalar and sequence targets.
3 open findings
What changed in this PR
Prevents CI disk exhaustion, expands acceptance testing to Python 3.13, and clarifies predict_trials return types.
Changes:
- Delete temporary paths for passing tests.
- Run acceptance tests on Python 3.12 and 3.13.
- Update target-return documentation and simplify Codecov configuration.
| File | Description |
|---|---|
pyproject.toml |
Configures pytest temporary-path cleanup. |
.github/workflows/tests.yml |
Expands acceptance CI and adjusts Codecov. |
docs/whats_new.rst |
Records the CI disk fix. |
braindecode/training/scoring.py |
Updates target return documentation. |
braindecode/classifier.py |
Updates classifier documentation. |
braindecode/regressor.py |
Updates regressor documentation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1251 +/- ##
==========================================
- Coverage 89.05% 89.02% -0.04%
==========================================
Files 157 157
Lines 19660 19396 -264
==========================================
- Hits 17509 17267 -242
+ Misses 2151 2129 -22 🚀 New features to boost your workflow:
|
Resolved docs/whats_new.rst by keeping both entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows test jobs on master stop at ~63% with
There is not enough space on the disk(runs 37566696035 windows 3.13, 37646500319 windows 3.12; also reported on #1182, #1196, #1200).Cause:
test_return_features.py::test_reset_head_model_reloads_after_savingsaves every model that overridesreset_head, at full default size, totmp_path, and pytest keeps everytmp_pathuntil the session ends. Locally (pytest test/unit_tests/models/test_return_features.py -n 6 --basetemp=...) that file leaves 6.1 GB behind on master (largest test directory 1.34 GB); with this PR it leaves 0 B.Changes:
pyproject.toml:tmp_path_retention_policy = "failed", so pytest deletes thetmp_pathof each passing test. Failing tests keep theirs.tests.yml: acceptance job runs on Python 3.12 and 3.13 (Restore acceptance tests on supported Python versions #1159 review); dropfail_ci_if_error: falsefrom the Codecov step, which already hascontinue-on-error: true(CI: make the Codecov upload non-blocking #1234 review).predict_trialsdocstrings (training/scoring.py,classifier.py,regressor.py):trial_targetsisnp.ndarray | list of np.ndarray, as_stack_trialsreturns a list when sequence targets differ in length (Restore acceptance tests on supported Python versions #1159 review).No file under
braindecode/modelschanged.