Repository navigation
Flutter SDK's test deps are stuck due to vm_snapshot_analysis, devtools_server #77856
Description
Activity
- addedtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.
on Mar 10, 2021 - addeddependency: dartDart team may need to help usDart team may need to help us
on Mar 11, 2021 Now that this is unpinned, we're stuck due to dwds
- changed the title
[-]Flutter SDK's test, vm_service, shelf, dwds deps are stuck due to mockito pin[/-][+]Flutter SDK's test, vm_service, shelf, dwds deps are stuck due to mockito and dwds[/+]on Mar 12, 2021 Now that this is unpinned, we're stuck due to dwds
@jonahwilliams Could you expand on the nature of the stuck-ness a bit?
I missed this when investigating because i thought dwds had been published recently, but its been about a month:
https://github.com/dart-lang/webdev/blob/master/dwds/pubspec.yaml
dwds shares many dependencies with test, and pins an exact vm_service version since it implements the interface. We'd need a publish of at least the current dwds to get the next vm_service. In order to get the latest test packages, we'd need a dwds that is updated to the latest shelf deps, but this seems to be blocked by dwds's dev dependencies on build_runner and sse.
We are expecting a breaking change in the near future as @annagrin is doing some SDK work to better support evaluation. Can this wait a week or so?
A week is fine with me - we've already cut the last beta so its more of a matter of giving the version updates a chance to bake for the April beta release
Assigning to @grouma to follow up when dwds is released.
Yup. I should have a PR shortly. This one was nasty....
21 remaining items
I was able to get this working locally by dependency overriding web_socket_channel to 2.0.0 and shelf_web_socket to 1.0.0, i dunno if there will be any further issues once those are unpinned.
In order to get the latest test, I also needed to dependency override webkit_inspection_protocol to 1.0.0
I'm trying to migrate the Flutter benchmark stocks app to be null safe because it relies on some generated l10n code (which is now null-safe). This is mostly necessary because we are adding some lints for unnecessary ignores for the framework and I need to run the l10n generation code on the app to make sure that the
ignores are no longer being generated.Right now, we've only manually removed the
ignores in the stocks app to unblock progress: #78669, but the proper fix involves removing redundant ignores from the code generator, and then runninggen-l10non the stocks app to make sure that we don't accidentally re-introduce them.To do this, I need to bump the stocks app's
httpdependency to be0.13.0or higher. However, whenever I manually modify thepubspec.yamlto a null-safe version of http, runningflutter update-packages --force-upgradeoverwrites it back to0.12.2due to the deps being pinned. Once they're unpinned, it should unblock the stocks app.@kenzieschmoll sorry, 🥔 back to you but we need a new version of devtools with flutter/devtools#2836
DevTools 2.0.0+3 published
Many of the versions are coming unstuck with #79088 but I missed webkit_inspection_protocol
IT WORKED
- added 2 commits that reference this issue
on Mar 29, 2021 Update: waiting on plugins CI/roll to land
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Aug 3, 2021 - addedP0Critical issues such as a build break or regressionCritical issues such as a build break or regressionand removed
on Jun 28, 2023
The versions of major tooling dependencies, shelf, test, dwds, vm_service are currently stuck due to the flutter_tools pin of mockito. Mockito was pinned to 4.1.1 to avoid needing to add more dependencies on code generation libraries, and eventually to avoid needing codegen for mockito tests.
The flutter_tool is the last user of mockito, but it will be several more months until we have completed migration off of mockito.
See also: