Skip to content

Flutter SDK's test deps are stuck due to vm_snapshot_analysis, devtools_server #77856

Description

@jonahwilliams

The versions of major tooling dependencies, shelf, test, dwds, vm_service are currently stuck due to the flutter_tools pin of mockito. Mockito was pinned to 4.1.1 to avoid needing to add more dependencies on code generation libraries, and eventually to avoid needing codegen for mockito tests.

The flutter_tool is the last user of mockito, but it will be several more months until we have completed migration off of mockito.

See also:

Activity

  1. added
    toolAffects the "flutter" command-line tool. See also t: labels.
    on Mar 10, 2021
  2. jonahwilliams commented on Mar 10, 2021

    @jonahwilliams
    ContributorAuthor
  3. jonahwilliams commented on Mar 12, 2021

    @jonahwilliams
    ContributorAuthor

    Now that this is unpinned, we're stuck due to dwds

  4. changed the title [-]Flutter SDK's test, vm_service, shelf, dwds deps are stuck due to mockito pin[/-] [+]Flutter SDK's test, vm_service, shelf, dwds deps are stuck due to mockito and dwds[/+] on Mar 12, 2021
  5. zanderso commented on Mar 12, 2021

    @zanderso
    Member

    Now that this is unpinned, we're stuck due to dwds

    @jonahwilliams Could you expand on the nature of the stuck-ness a bit?

  6. jonahwilliams commented on Mar 12, 2021

    @jonahwilliams
    ContributorAuthor

    I missed this when investigating because i thought dwds had been published recently, but its been about a month:

    https://github.com/dart-lang/webdev/blob/master/dwds/pubspec.yaml

    dwds shares many dependencies with test, and pins an exact vm_service version since it implements the interface. We'd need a publish of at least the current dwds to get the next vm_service. In order to get the latest test packages, we'd need a dwds that is updated to the latest shelf deps, but this seems to be blocked by dwds's dev dependencies on build_runner and sse.

    @grouma

  7. grouma commented on Mar 12, 2021

    @grouma
    Member

    We are expecting a breaking change in the near future as @annagrin is doing some SDK work to better support evaluation. Can this wait a week or so?

  8. jonahwilliams commented on Mar 12, 2021

    @jonahwilliams
    ContributorAuthor

    A week is fine with me - we've already cut the last beta so its more of a matter of giving the version updates a chance to bake for the April beta release

  9. jonahwilliams commented on Mar 16, 2021

    @jonahwilliams
    ContributorAuthor

    Assigning to @grouma to follow up when dwds is released.

  10. grouma commented on Mar 16, 2021

    @grouma
    Member

    Yup. I should have a PR shortly. This one was nasty....

  11. added a commit that references this issue on Mar 17, 2021
  12. 21 remaining items

  13. jonahwilliams commented on Mar 23, 2021

    @jonahwilliams
    ContributorAuthor

    I was able to get this working locally by dependency overriding web_socket_channel to 2.0.0 and shelf_web_socket to 1.0.0, i dunno if there will be any further issues once those are unpinned.

  14. jonahwilliams commented on Mar 23, 2021

    @jonahwilliams
    ContributorAuthor

    In order to get the latest test, I also needed to dependency override webkit_inspection_protocol to 1.0.0

  15. shihaohong commented on Mar 24, 2021

    @shihaohong
    Contributor

    I'm trying to migrate the Flutter benchmark stocks app to be null safe because it relies on some generated l10n code (which is now null-safe). This is mostly necessary because we are adding some lints for unnecessary ignores for the framework and I need to run the l10n generation code on the app to make sure that the ignores are no longer being generated.

    Right now, we've only manually removed the ignores in the stocks app to unblock progress: #78669, but the proper fix involves removing redundant ignores from the code generator, and then running gen-l10n on the stocks app to make sure that we don't accidentally re-introduce them.

    To do this, I need to bump the stocks app's http dependency to be 0.13.0 or higher. However, whenever I manually modify the pubspec.yaml to a null-safe version of http, running flutter update-packages --force-upgrade overwrites it back to 0.12.2 due to the deps being pinned. Once they're unpinned, it should unblock the stocks app.

  16. jonahwilliams commented on Mar 24, 2021

    @jonahwilliams
    ContributorAuthor

    @kenzieschmoll sorry, 🥔 back to you but we need a new version of devtools with flutter/devtools#2836

  17. kenzieschmoll commented on Mar 24, 2021

    @kenzieschmoll
    Member

    DevTools 2.0.0+3 published

  18. jonahwilliams commented on Mar 25, 2021

    @jonahwilliams
    ContributorAuthor

    Many of the versions are coming unstuck with #79088 but I missed webkit_inspection_protocol

  19. jonahwilliams commented on Mar 25, 2021

    @jonahwilliams
    ContributorAuthor

    IT WORKED

  20. jonahwilliams commented on Mar 30, 2021

    @jonahwilliams
    ContributorAuthor

    Update: waiting on plugins CI/roll to land

  21. github-actions commented on Aug 3, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  22. locked as resolved and limited conversation to collaborators on Aug 3, 2021
  23. added
    P0Critical issues such as a build break or regression
    and removed on Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P0Critical issues such as a build break or regressiondependency: dartDart team may need to help ustoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions