Repository navigation
Flutter SDK's test deps are stuck due to vm_snapshot_analysis, devtools_server #77856
Description
The versions of major tooling dependencies, shelf, test, dwds, vm_service are currently stuck due to the flutter_tools pin of mockito. Mockito was pinned to 4.1.1 to avoid needing to add more dependencies on code generation libraries, and eventually to avoid needing codegen for mockito tests.
The flutter_tool is the last user of mockito, but it will be several more months until we have completed migration off of mockito.
See also:
Activity
jonahwilliams commentedon Mar 10, 2021
@zanderso
jonahwilliams commentedon Mar 12, 2021
Now that this is unpinned, we're stuck due to dwds
[-]Flutter SDK's test, vm_service, shelf, dwds deps are stuck due to mockito pin[/-][+]Flutter SDK's test, vm_service, shelf, dwds deps are stuck due to mockito and dwds[/+]zanderso commentedon Mar 12, 2021
@jonahwilliams Could you expand on the nature of the stuck-ness a bit?
jonahwilliams commentedon Mar 12, 2021
I missed this when investigating because i thought dwds had been published recently, but its been about a month:
https://github.com/dart-lang/webdev/blob/master/dwds/pubspec.yaml
dwds shares many dependencies with test, and pins an exact vm_service version since it implements the interface. We'd need a publish of at least the current dwds to get the next vm_service. In order to get the latest test packages, we'd need a dwds that is updated to the latest shelf deps, but this seems to be blocked by dwds's dev dependencies on build_runner and sse.
@grouma
grouma commentedon Mar 12, 2021
We are expecting a breaking change in the near future as @annagrin is doing some SDK work to better support evaluation. Can this wait a week or so?
jonahwilliams commentedon Mar 12, 2021
A week is fine with me - we've already cut the last beta so its more of a matter of giving the version updates a chance to bake for the April beta release
jonahwilliams commentedon Mar 16, 2021
Assigning to @grouma to follow up when dwds is released.
grouma commentedon Mar 16, 2021
Yup. I should have a PR shortly. This one was nasty....
Prepare for release (#1273)
21 remaining items
jonahwilliams commentedon Mar 23, 2021
I was able to get this working locally by dependency overriding web_socket_channel to 2.0.0 and shelf_web_socket to 1.0.0, i dunno if there will be any further issues once those are unpinned.
jonahwilliams commentedon Mar 23, 2021
In order to get the latest test, I also needed to dependency override webkit_inspection_protocol to 1.0.0
shihaohong commentedon Mar 24, 2021
I'm trying to migrate the Flutter benchmark stocks app to be null safe because it relies on some generated l10n code (which is now null-safe). This is mostly necessary because we are adding some lints for unnecessary ignores for the framework and I need to run the l10n generation code on the app to make sure that the
ignores are no longer being generated.Right now, we've only manually removed the
ignores in the stocks app to unblock progress: #78669, but the proper fix involves removing redundant ignores from the code generator, and then runninggen-l10non the stocks app to make sure that we don't accidentally re-introduce them.To do this, I need to bump the stocks app's
httpdependency to be0.13.0or higher. However, whenever I manually modify thepubspec.yamlto a null-safe version of http, runningflutter update-packages --force-upgradeoverwrites it back to0.12.2due to the deps being pinned. Once they're unpinned, it should unblock the stocks app.jonahwilliams commentedon Mar 24, 2021
@kenzieschmoll sorry, 🥔 back to you but we need a new version of devtools with flutter/devtools#2836
kenzieschmoll commentedon Mar 24, 2021
DevTools 2.0.0+3 published
jonahwilliams commentedon Mar 25, 2021
Many of the versions are coming unstuck with #79088 but I missed webkit_inspection_protocol
jonahwilliams commentedon Mar 25, 2021
IT WORKED
Update flutter gallery version
Update flutter gallery version (#86)
jonahwilliams commentedon Mar 30, 2021
Update: waiting on plugins CI/roll to land
github-actions commentedon Aug 3, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.