Skip to content

Linux tool_integration_tests_1_4 flakes on gradle_non_android_plugin_test #99767

Closed
Closed
Linux tool_integration_tests_1_4 flakes on gradle_non_android_plugin_test#99767
Assignees
eliasyishak
Labels
c: flakeTests that sometimes, but not always, incorrectly passteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.

Description

@keyonghan
keyonghan
opened on Mar 8, 2022

(part of #97036)

1 gradle_non_android_plugin_test.dart flake (3454)

12:19 +63 -1: test/integration.shard/gradle_non_android_plugin_test.dart: Flutter app that depends on a non-Android plugin can still build for Android [E]                                             
  Expected: a file system entity that exists
    Actual: LocalFile:<LocalFile: '/b/s/w/ir/x/t/flutter_flutter_plugin_test.ESHTVW/ios_only/example/build/app/outputs/apk/release/app-release.apk'>
     Which: does not exist
  
  package:test_api                                                 expect
  test/integration.shard/gradle_non_android_plugin_test.dart 92:5  main.<fn>
  dart:async                                                       runZoned
  test/src/common.dart 197:14                                      testWithoutContext.<fn>
  test/src/common.dart 196:18                                      testWithoutContext.<fn>
  test/src/common.dart 166:18                                      test.<fn>
  test/src/common.dart 161:5

Activity

  1. keyonghan
    added
    team: flakes
    toolAffects the "flutter" command-line tool. See also t: labels.
    on Mar 8, 2022
  2. christopherfujino
    added this to go/flutter-tools-project (deprecated)on May 18, 2023
  3. christopherfujino
    moved this to Test flakes in go/flutter-tools-project (deprecated)on May 18, 2023

  4. christopherfujino commented on May 18, 2023

    @christopherfujino
    christopherfujino
    on May 18, 2023
    Contributor

    Here we're not even checking the exit code of the flutter build command: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/gradle_non_android_plugin_test.dart#LL71C1-L80C1

    We should do an expectation something like:

    expect(result.exitCode, 0, reason: 'stdout: ${result.stdout}\nstderr: ${result.stderr}');

  5. christopherfujino
    assigned
    eliasyishak
    on May 18, 2023

  6. christopherfujino commented on May 18, 2023

    @christopherfujino
    christopherfujino
    on May 18, 2023
    Contributor

    I think it would make sense to write a helper function in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/test_utils.dart

  7. eliasyishak commented on May 18, 2023

    @eliasyishak
    eliasyishak
    on May 18, 2023
    Contributor

    I think it would make sense to write a helper function in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/test_utils.dart

    Captured in issue:

  8. auto-submit
    added a commit that references this issue on May 25, 2023

    `ProcessResultMatcher` created and used in test (#127414)

    cb3b1f8
  9. flutter-triage-bot
    added
    c: flakeTests that sometimes, but not always, incorrectly pass
    team-toolOwned by Flutter Tool team
    on Jul 7, 2023
  10. chinmaygarde
    removed
    team: flakes
    on Jul 19, 2023

  11. eliasyishak commented on Aug 2, 2023

    @eliasyishak
    eliasyishak
    on Aug 2, 2023
    Contributor

    Closing this issue to let the new process result matcher help debug future flakes if still occuring

  12. eliasyishak
    closed this as completedon Aug 2, 2023

  13. github-actions commented on Aug 16, 2023

    @github-actions
    github-actionsbot
    on Aug 16, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  14. github-actions
    locked as resolved and limited conversation to collaborators on Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: flakeTests that sometimes, but not always, incorrectly passteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions