Repository navigation
Bump devtools_shared to 13.1.0 - #189507
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the devtools_shared dependency to version 14.0.0 and refactors the devTools directory reference in persistent_preferences.dart to use devtools.LocalFileSystemExtension.devToolsDir. Feedback indicates that this change will cause a compilation error because devToolsDir returns a Directory object instead of the String expected by fs.path.join, and suggests appending .path to resolve the issue.
kenzieschmoll
left a comment
There was a problem hiding this comment.
LGTM. @bkonyi should approve as well
|
Hmm, I need re-approval for some reason. |
|
Looks like there's another merge conflict :( |
|
Haha yep. Updated; PTAL |
flutter/flutter@2a2a79d...b65f4d9 2026-07-24 [email protected] Add dart_runtime_service_vm_aot.dart.snapshot to the snapshot list in the macOS code signing configuration (flutter/flutter#189981) 2026-07-24 [email protected] Roll Fuchsia Test Scripts from wLST_A-xfOeGT_5mj... to E8hJ1AfK8CtGtaES0... (flutter/flutter#189956) 2026-07-23 [email protected] Consolidate AndroidArch and DarwinArch into CpuArch (flutter/flutter#189315) 2026-07-23 [email protected] Roll Dart SDK from 9258584f98b8 to e3fc57eae9eb (7 revisions) (flutter/flutter#189949) 2026-07-23 [email protected] [flutter_tools] Do not always wait for the full timeout when running Spotlight to locate Android Studio on macOS (flutter/flutter#189952) 2026-07-23 [email protected] Roll Skia from 1d8bf9270d8c to 6e9c4687c001 (15 revisions) (flutter/flutter#189954) 2026-07-23 [email protected] [flutter_tools] Initialize Cache.flutterRoot at the start of the upgrade_test suite (flutter/flutter#189937) 2026-07-23 [email protected] Parse AndroidX property in gradle.properties (flutter/flutter#188372) 2026-07-23 [email protected] [Impeller]Use the IO context for OpenGL program setup (flutter/flutter#185723) 2026-07-23 [email protected] Allow building projects lacking Runner.xcworkspace (flutter/flutter#186239) 2026-07-23 [email protected] [flutter_tools] Invalidate WebEntrypointTarget when plugin set changes (flutter/flutter#189460) 2026-07-23 [email protected] Bump devtools_shared to 13.1.0 (flutter/flutter#189507) 2026-07-23 [email protected] forceNdkDownload should skip configuring cmake when ndk-build is used (flutter/flutter#187201) 2026-07-23 [email protected] Disable execution order shuffling for the flutter_tools upgrade_test suite (flutter/flutter#189920) 2026-07-23 [email protected] Move WindowManager outside of WidgetsApp (flutter/flutter#188866) 2026-07-23 [email protected] Roll Skia from 3424966b8a2b to 1d8bf9270d8c (3 revisions) (flutter/flutter#189901) 2026-07-23 [email protected] Roll Fuchsia Linux SDK from GswhlPRO-D1qSNclx... to 9org0yL3yZkp80x5S... (flutter/flutter#189898) 2026-07-23 [email protected] Remove outdated logs that were added to track #172636 (flutter/flutter#189282) 2026-07-23 [email protected] Roll Skia from 5e183e5aeac5 to 3424966b8a2b (33 revisions) (flutter/flutter#189890) 2026-07-23 [email protected] [examples] Use super parameters in missed spots (flutter/flutter#186194) 2026-07-23 [email protected] [flutter_tools] Bound Spotlight mdfind execution with timeout on macOS (flutter/flutter#189461) 2026-07-23 [email protected] Fix non primary buttons not being captured on windows (flutter/flutter#188394) 2026-07-22 [email protected] Listen to log reader before VM Service and make delay configurable (flutter/flutter#187202) 2026-07-22 [email protected] Roll Dart SDK from 1e65011ee004 to 9258584f98b8 (7 revisions) (flutter/flutter#189883) 2026-07-22 [email protected] Adds skill for generating engine diffs for new releases. (flutter/flutter#189869) 2026-07-22 [email protected] [ios,macos] Add Swift Sourcekit LSP support (flutter/flutter#189761) 2026-07-22 [email protected] [iOS] Mark DisplayLinkManager.shared and init() @mainactor (flutter/flutter#189815) 2026-07-22 [email protected] Fix `Rect::ExpandToMinTransformedSize` to return the input rectangle when no expansion is needed, and remove 1-pixel roundrect to rect simplification (flutter/flutter#189808) 2026-07-22 [email protected] Skip emulator.getEmulators test (flutter/flutter#189879) 2026-07-22 [email protected] Fix null terminator in input truncates clipboard (flutter/flutter#188652) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: #189507 ### Impact Description: In Flutter 3.47.2 crash reports, `FormatException at _ChunkedJsonParser.fail` was a top crasher accounting for 170 crashes (11.4% of top 10 crashes). When `package:dds` 5.3.0 launches the Dart Development Service and the process experiences a startup failure (such as native library dlopen errors or immediate exit), `stderr` emits non-JSON text or closes prematurely. `package:dds` 5.3.0 piped `stderr` directly to `json.decoder` without an `onError:` callback, throwing an unhandled `FormatException` that crashed `flutter_tools`. Rolling `package:dds` 5.4.0 addresses these stream errors and stabilizes DDS initialization. ### Changelog Description: [flutter/189507] When Dart Development Service encounters a startup failure, flutter_tools crashes with an unhandled FormatException. ### Workaround: None. ### Risk: ### Test Coverage: ### Validation Steps: 1. Verify hermetic DDS tests pass: `dart test packages/flutter_tools/test/general.shard/base/dds_exception_test.dart`. 2. Verify package dependencies and lockfile integrity.
Adds the changelog section for 3.47.5, tracked by #192828. <details> <summary>Agent authored info</summary> Covers the cherry-picks that landed on `flutter-3.47-candidate.0` since the `3.47.4` tag. Each entry uses the **Changelog Description** exactly as authored in the corresponding cherry-pick PR. | Cherry-pick PR | Landed | Changelog reference | | --- | --- | --- | | [#192810](#192810) [CP-stable] On iOS 27+ devices, manually process lldb stops | `d3c78d8b3` | [flutter/190307](#190307) | | [#192255](#192255) [stable] [Widget Preview] Isolate PageStorage scope in widget preview group expansion tile | `64d4f6282` | [flutter/191242](#191242) | | [#192295](#192295) [stable] [flutter_tools] Roll package:dds to 5.4.0 | `0a12baff2` | [flutter/189507](#189507) | Entries are ordered by the order the cherry-picks landed on the branch, matching the convention used for 3.47.4. ### Intentionally excluded Two commits also landed in this range but are routine release infrastructure, not user-facing cherry-picks: - [#192875](#192875) Update Flutter DEPS to Dart `b530c21f7de367b94fb04787bfed9d8e989d75e8` - [#192894](#192894) Sync `engine.version` to `af7e796e161ae0bb1ff0758c71a7105418bd9ded` This matches every prior hotfix in this series: the 3.47.1, 3.47.2, and 3.47.3 ranges each contained a Dart DEPS roll and an `engine.version` sync, and none were listed as changelog bullets. ### Note for the release manager The `Issue Link` on [#192295](#192295) points at [#189507](#189507) ("Bump devtools_shared to 13.1.0", merged 2026-07-23), which does not appear to relate to the `package:dds` 5.4.0 roll that PR actually performs. The authored changelog text has been preserved verbatim rather than silently corrected. If that reference is wrong, the bullet should be repointed before this lands. ### Verification - All three entry links return HTTP 200. - The `3.47.5` tag link currently 404s because the release has not been tagged yet; it will resolve once "Push release with MPA" completes. This is expected, since the checklist places "Add changelog for stable release" before the release is pushed. </details> I have double checked with @bkonyi that there is no issue for the dds change because the issue when discovered was already fixed on master.
Adds the changelog section for 3.47.5, tracked by flutter#192828. <details> <summary>Agent authored info</summary> Covers the cherry-picks that landed on `flutter-3.47-candidate.0` since the `3.47.4` tag. Each entry uses the **Changelog Description** exactly as authored in the corresponding cherry-pick PR. | Cherry-pick PR | Landed | Changelog reference | | --- | --- | --- | | [flutter#192810](flutter#192810) [CP-stable] On iOS 27+ devices, manually process lldb stops | `d3c78d8b3` | [flutter/190307](flutter#190307) | | [flutter#192255](flutter#192255) [stable] [Widget Preview] Isolate PageStorage scope in widget preview group expansion tile | `64d4f6282` | [flutter/191242](flutter#191242) | | [flutter#192295](flutter#192295) [stable] [flutter_tools] Roll package:dds to 5.4.0 | `0a12baff2` | [flutter/189507](flutter#189507) | Entries are ordered by the order the cherry-picks landed on the branch, matching the convention used for 3.47.4. Two commits also landed in this range but are routine release infrastructure, not user-facing cherry-picks: - [flutter#192875](flutter#192875) Update Flutter DEPS to Dart `b530c21f7de367b94fb04787bfed9d8e989d75e8` - [flutter#192894](flutter#192894) Sync `engine.version` to `af7e796e161ae0bb1ff0758c71a7105418bd9ded` This matches every prior hotfix in this series: the 3.47.1, 3.47.2, and 3.47.3 ranges each contained a Dart DEPS roll and an `engine.version` sync, and none were listed as changelog bullets. The `Issue Link` on [flutter#192295](flutter#192295) points at [flutter#189507](flutter#189507) ("Bump devtools_shared to 13.1.0", merged 2026-07-23), which does not appear to relate to the `package:dds` 5.4.0 roll that PR actually performs. The authored changelog text has been preserved verbatim rather than silently corrected. If that reference is wrong, the bullet should be repointed before this lands. - All three entry links return HTTP 200. - The `3.47.5` tag link currently 404s because the release has not been tagged yet; it will resolve once "Push release with MPA" completes. This is expected, since the checklist places "Add changelog for stable release" before the release is pushed. </details> I have double checked with @bkonyi that there is no issue for the dds change because the issue when discovered was already fixed on master.
Adds the changelog section for 3.47.5, tracked by flutter#192828. <details> <summary>Agent authored info</summary> Covers the cherry-picks that landed on `flutter-3.47-candidate.0` since the `3.47.4` tag. Each entry uses the **Changelog Description** exactly as authored in the corresponding cherry-pick PR. | Cherry-pick PR | Landed | Changelog reference | | --- | --- | --- | | [flutter#192810](flutter#192810) [CP-stable] On iOS 27+ devices, manually process lldb stops | `d3c78d8b3` | [flutter/190307](flutter#190307) | | [flutter#192255](flutter#192255) [stable] [Widget Preview] Isolate PageStorage scope in widget preview group expansion tile | `64d4f6282` | [flutter/191242](flutter#191242) | | [flutter#192295](flutter#192295) [stable] [flutter_tools] Roll package:dds to 5.4.0 | `0a12baff2` | [flutter/189507](flutter#189507) | Entries are ordered by the order the cherry-picks landed on the branch, matching the convention used for 3.47.4. Two commits also landed in this range but are routine release infrastructure, not user-facing cherry-picks: - [flutter#192875](flutter#192875) Update Flutter DEPS to Dart `b530c21f7de367b94fb04787bfed9d8e989d75e8` - [flutter#192894](flutter#192894) Sync `engine.version` to `af7e796e161ae0bb1ff0758c71a7105418bd9ded` This matches every prior hotfix in this series: the 3.47.1, 3.47.2, and 3.47.3 ranges each contained a Dart DEPS roll and an `engine.version` sync, and none were listed as changelog bullets. The `Issue Link` on [flutter#192295](flutter#192295) points at [flutter#189507](flutter#189507) ("Bump devtools_shared to 13.1.0", merged 2026-07-23), which does not appear to relate to the `package:dds` 5.4.0 roll that PR actually performs. The authored changelog text has been preserved verbatim rather than silently corrected. If that reference is wrong, the bullet should be repointed before this lands. - All three entry links return HTTP 200. - The `3.47.5` tag link currently 404s because the release has not been tagged yet; it will resolve once "Push release with MPA" completes. This is expected, since the checklist places "Add changelog for stable release" before the release is pushed. </details> I have double checked with @bkonyi that there is no issue for the dds change because the issue when discovered was already fixed on master.
Adds the changelog section for 3.47.5, tracked by flutter#192828. <details> <summary>Agent authored info</summary> Covers the cherry-picks that landed on `flutter-3.47-candidate.0` since the `3.47.4` tag. Each entry uses the **Changelog Description** exactly as authored in the corresponding cherry-pick PR. | Cherry-pick PR | Landed | Changelog reference | | --- | --- | --- | | [flutter#192810](flutter#192810) [CP-stable] On iOS 27+ devices, manually process lldb stops | `d3c78d8b3` | [flutter/190307](flutter#190307) | | [flutter#192255](flutter#192255) [stable] [Widget Preview] Isolate PageStorage scope in widget preview group expansion tile | `64d4f6282` | [flutter/191242](flutter#191242) | | [flutter#192295](flutter#192295) [stable] [flutter_tools] Roll package:dds to 5.4.0 | `0a12baff2` | [flutter/189507](flutter#189507) | Entries are ordered by the order the cherry-picks landed on the branch, matching the convention used for 3.47.4. Two commits also landed in this range but are routine release infrastructure, not user-facing cherry-picks: - [flutter#192875](flutter#192875) Update Flutter DEPS to Dart `b530c21f7de367b94fb04787bfed9d8e989d75e8` - [flutter#192894](flutter#192894) Sync `engine.version` to `af7e796e161ae0bb1ff0758c71a7105418bd9ded` This matches every prior hotfix in this series: the 3.47.1, 3.47.2, and 3.47.3 ranges each contained a Dart DEPS roll and an `engine.version` sync, and none were listed as changelog bullets. The `Issue Link` on [flutter#192295](flutter#192295) points at [flutter#189507](flutter#189507) ("Bump devtools_shared to 13.1.0", merged 2026-07-23), which does not appear to relate to the `package:dds` 5.4.0 roll that PR actually performs. The authored changelog text has been preserved verbatim rather than silently corrected. If that reference is wrong, the bullet should be repointed before this lands. - All three entry links return HTTP 200. - The `3.47.5` tag link currently 404s because the release has not been tagged yet; it will resolve once "Push release with MPA" completes. This is expected, since the checklist places "Add changelog for stable release" before the release is pushed. </details> I have double checked with @bkonyi that there is no issue for the dds change because the issue when discovered was already fixed on master.
Pre-launch Checklist
///).