[stable] [flutter_tools] Roll package:dds to 5.4.0 by bkonyi · Pull Request #192295 · flutter/flutter

bkonyi · 2026-09-04T15:33:54Z

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

#189507

Impact Description:

In Flutter 3.47.2 crash reports, FormatException at _ChunkedJsonParser.fail was a top crasher accounting for 170 crashes (11.4% of top 10 crashes). When package:dds 5.3.0 launches the Dart Development Service and the process experiences a startup failure (such as native library dlopen errors or immediate exit), stderr emits non-JSON text or closes prematurely. package:dds 5.3.0 piped stderr directly to json.decoder without an onError: callback, throwing an unhandled FormatException that crashed flutter_tools. Rolling package:dds 5.4.0 addresses these stream errors and stabilizes DDS initialization.

Changelog Description:

[flutter/189507] When Dart Development Service encounters a startup failure, flutter_tools crashes with an unhandled FormatException.

Workaround:

None.

Risk:

Low
Medium
High

Test Coverage:

Yes
No

Validation Steps:

Verify hermetic DDS tests pass: dart test packages/flutter_tools/test/general.shard/base/dds_exception_test.dart.
Verify package dependencies and lockfile integrity.

- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

flutter-dashboard · 2026-09-04T15:34:06Z

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

gemini-code-assist

Code Review

This pull request updates the dependencies in packages/flutter_tools/pubspec.yaml and pubspec.lock, upgrading dds from version 5.3.0 to 5.4.0 and devtools_shared from version 12.1.0 to 13.1.0. There are no review comments, and I have no feedback to provide.

walley892 · 2026-09-09T16:55:52Z

@bkonyi, last one - could you add a secondary reviewer?

auto-submit · 2026-09-09T21:06:56Z

autosubmit label was removed for flutter/flutter/192295, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2026-09-09T21:08:51Z

autosubmit label was removed for flutter/flutter/192295, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

walley892 · 2026-09-09T21:16:09Z

Hey @bkonyi, could you look into the test failures please?

bkonyi · 2026-09-09T22:28:27Z

Hey @bkonyi, could you look into the test failures please?

Should be fixed now!

reidbaker · 2026-09-15T20:30:24Z

@bkonyi can you follow the changelog guidelines so I can copy paste into the release?

bkonyi · 2026-09-15T20:41:34Z

@bkonyi can you follow the changelog guidelines so I can copy paste into the release?

Done!

@bkonyi

Adds the changelog section for 3.47.5, tracked by #192828. <details> <summary>Agent authored info</summary> Covers the cherry-picks that landed on `flutter-3.47-candidate.0` since the `3.47.4` tag. Each entry uses the **Changelog Description** exactly as authored in the corresponding cherry-pick PR. | Cherry-pick PR | Landed | Changelog reference | | --- | --- | --- | | [#192810](#192810) [CP-stable] On iOS 27+ devices, manually process lldb stops | `d3c78d8b3` | [flutter/190307](#190307) | | [#192255](#192255) [stable] [Widget Preview] Isolate PageStorage scope in widget preview group expansion tile | `64d4f6282` | [flutter/191242](#191242) | | [#192295](#192295) [stable] [flutter_tools] Roll package:dds to 5.4.0 | `0a12baff2` | [flutter/189507](#189507) | Entries are ordered by the order the cherry-picks landed on the branch, matching the convention used for 3.47.4. ### Intentionally excluded Two commits also landed in this range but are routine release infrastructure, not user-facing cherry-picks: - [#192875](#192875) Update Flutter DEPS to Dart `b530c21f7de367b94fb04787bfed9d8e989d75e8` - [#192894](#192894) Sync `engine.version` to `af7e796e161ae0bb1ff0758c71a7105418bd9ded` This matches every prior hotfix in this series: the 3.47.1, 3.47.2, and 3.47.3 ranges each contained a Dart DEPS roll and an `engine.version` sync, and none were listed as changelog bullets. ### Note for the release manager The `Issue Link` on [#192295](#192295) points at [#189507](#189507) ("Bump devtools_shared to 13.1.0", merged 2026-07-23), which does not appear to relate to the `package:dds` 5.4.0 roll that PR actually performs. The authored changelog text has been preserved verbatim rather than silently corrected. If that reference is wrong, the bullet should be repointed before this lands. ### Verification - All three entry links return HTTP 200. - The `3.47.5` tag link currently 404s because the release has not been tagged yet; it will resolve once "Push release with MPA" completes. This is expected, since the checklist places "Add changelog for stable release" before the release is pushed. </details> I have double checked with @bkonyi that there is no issue for the dds change because the issue when discovered was already fixed on master.

@bkonyi

Adds the changelog section for 3.47.5, tracked by flutter#192828. <details> <summary>Agent authored info</summary> Covers the cherry-picks that landed on `flutter-3.47-candidate.0` since the `3.47.4` tag. Each entry uses the **Changelog Description** exactly as authored in the corresponding cherry-pick PR. | Cherry-pick PR | Landed | Changelog reference | | --- | --- | --- | | [flutter#192810](flutter#192810) [CP-stable] On iOS 27+ devices, manually process lldb stops | `d3c78d8b3` | [flutter/190307](flutter#190307) | | [flutter#192255](flutter#192255) [stable] [Widget Preview] Isolate PageStorage scope in widget preview group expansion tile | `64d4f6282` | [flutter/191242](flutter#191242) | | [flutter#192295](flutter#192295) [stable] [flutter_tools] Roll package:dds to 5.4.0 | `0a12baff2` | [flutter/189507](flutter#189507) | Entries are ordered by the order the cherry-picks landed on the branch, matching the convention used for 3.47.4. Two commits also landed in this range but are routine release infrastructure, not user-facing cherry-picks: - [flutter#192875](flutter#192875) Update Flutter DEPS to Dart `b530c21f7de367b94fb04787bfed9d8e989d75e8` - [flutter#192894](flutter#192894) Sync `engine.version` to `af7e796e161ae0bb1ff0758c71a7105418bd9ded` This matches every prior hotfix in this series: the 3.47.1, 3.47.2, and 3.47.3 ranges each contained a Dart DEPS roll and an `engine.version` sync, and none were listed as changelog bullets. The `Issue Link` on [flutter#192295](flutter#192295) points at [flutter#189507](flutter#189507) ("Bump devtools_shared to 13.1.0", merged 2026-07-23), which does not appear to relate to the `package:dds` 5.4.0 roll that PR actually performs. The authored changelog text has been preserved verbatim rather than silently corrected. If that reference is wrong, the bullet should be repointed before this lands. - All three entry links return HTTP 200. - The `3.47.5` tag link currently 404s because the release has not been tagged yet; it will resolve once "Push release with MPA" completes. This is expected, since the checklist places "Add changelog for stable release" before the release is pushed. </details> I have double checked with @bkonyi that there is no issue for the dds change because the issue when discovered was already fixed on master.

@bkonyi

Adds the changelog section for 3.47.5, tracked by flutter#192828. <details> <summary>Agent authored info</summary> Covers the cherry-picks that landed on `flutter-3.47-candidate.0` since the `3.47.4` tag. Each entry uses the **Changelog Description** exactly as authored in the corresponding cherry-pick PR. | Cherry-pick PR | Landed | Changelog reference | | --- | --- | --- | | [flutter#192810](flutter#192810) [CP-stable] On iOS 27+ devices, manually process lldb stops | `d3c78d8b3` | [flutter/190307](flutter#190307) | | [flutter#192255](flutter#192255) [stable] [Widget Preview] Isolate PageStorage scope in widget preview group expansion tile | `64d4f6282` | [flutter/191242](flutter#191242) | | [flutter#192295](flutter#192295) [stable] [flutter_tools] Roll package:dds to 5.4.0 | `0a12baff2` | [flutter/189507](flutter#189507) | Entries are ordered by the order the cherry-picks landed on the branch, matching the convention used for 3.47.4. Two commits also landed in this range but are routine release infrastructure, not user-facing cherry-picks: - [flutter#192875](flutter#192875) Update Flutter DEPS to Dart `b530c21f7de367b94fb04787bfed9d8e989d75e8` - [flutter#192894](flutter#192894) Sync `engine.version` to `af7e796e161ae0bb1ff0758c71a7105418bd9ded` This matches every prior hotfix in this series: the 3.47.1, 3.47.2, and 3.47.3 ranges each contained a Dart DEPS roll and an `engine.version` sync, and none were listed as changelog bullets. The `Issue Link` on [flutter#192295](flutter#192295) points at [flutter#189507](flutter#189507) ("Bump devtools_shared to 13.1.0", merged 2026-07-23), which does not appear to relate to the `package:dds` 5.4.0 roll that PR actually performs. The authored changelog text has been preserved verbatim rather than silently corrected. If that reference is wrong, the bullet should be repointed before this lands. - All three entry links return HTTP 200. - The `3.47.5` tag link currently 404s because the release has not been tagged yet; it will resolve once "Push release with MPA" completes. This is expected, since the checklist places "Add changelog for stable release" before the release is pushed. </details> I have double checked with @bkonyi that there is no issue for the dds change because the issue when discovered was already fixed on master.

@bkonyi

Adds the changelog section for 3.47.5, tracked by flutter#192828. <details> <summary>Agent authored info</summary> Covers the cherry-picks that landed on `flutter-3.47-candidate.0` since the `3.47.4` tag. Each entry uses the **Changelog Description** exactly as authored in the corresponding cherry-pick PR. | Cherry-pick PR | Landed | Changelog reference | | --- | --- | --- | | [flutter#192810](flutter#192810) [CP-stable] On iOS 27+ devices, manually process lldb stops | `d3c78d8b3` | [flutter/190307](flutter#190307) | | [flutter#192255](flutter#192255) [stable] [Widget Preview] Isolate PageStorage scope in widget preview group expansion tile | `64d4f6282` | [flutter/191242](flutter#191242) | | [flutter#192295](flutter#192295) [stable] [flutter_tools] Roll package:dds to 5.4.0 | `0a12baff2` | [flutter/189507](flutter#189507) | Entries are ordered by the order the cherry-picks landed on the branch, matching the convention used for 3.47.4. Two commits also landed in this range but are routine release infrastructure, not user-facing cherry-picks: - [flutter#192875](flutter#192875) Update Flutter DEPS to Dart `b530c21f7de367b94fb04787bfed9d8e989d75e8` - [flutter#192894](flutter#192894) Sync `engine.version` to `af7e796e161ae0bb1ff0758c71a7105418bd9ded` This matches every prior hotfix in this series: the 3.47.1, 3.47.2, and 3.47.3 ranges each contained a Dart DEPS roll and an `engine.version` sync, and none were listed as changelog bullets. The `Issue Link` on [flutter#192295](flutter#192295) points at [flutter#189507](flutter#189507) ("Bump devtools_shared to 13.1.0", merged 2026-07-23), which does not appear to relate to the `package:dds` 5.4.0 roll that PR actually performs. The authored changelog text has been preserved verbatim rather than silently corrected. If that reference is wrong, the bullet should be repointed before this lands. - All three entry links return HTTP 200. - The `3.47.5` tag link currently 404s because the release has not been tagged yet; it will resolve once "Push release with MPA" completes. This is expected, since the checklist places "Add changelog for stable release" before the release is pushed. </details> I have double checked with @bkonyi that there is no issue for the dds change because the issue when discovered was already fixed on master.

flutter-dashboard Bot added the CICD Run CI/CD label Sep 4, 2026

github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 4, 2026

bkonyi added cp: review Cherry-picks in the review queue cp: stable cherry pick this pull request to stable release candidate branch labels Sep 4, 2026

gemini-code-assist Bot reviewed Sep 4, 2026

View reviewed changes

bkonyi requested a review from nshahan September 9, 2026 18:40

nshahan previously approved these changes Sep 9, 2026

View reviewed changes

walley892 previously approved these changes Sep 9, 2026

View reviewed changes

walley892 added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 9, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 9, 2026

walley892 added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 9, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 9, 2026

Update PUBSPEC CHECKSUM in pubspec.yaml

e4bcca7

bkonyi dismissed stale reviews from walley892 and nshahan via e4bcca7 September 9, 2026 22:28

walley892 requested a review from nshahan September 9, 2026 22:49

reidbaker approved these changes Sep 16, 2026

View reviewed changes

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 16, 2026

auto-submit Bot merged commit 0a12baf into flutter:flutter-3.47-candidate.0 Sep 16, 2026
10 checks passed

reidbaker-agent mentioned this pull request Sep 17, 2026

Update changelog for 3.47.5 #192925

Merged

9 of 10 tasks

Navigation Menu

Repository navigation

[stable] [flutter_tools] Roll package:dds to 5.4.0 - #192295

[stable] [flutter_tools] Roll package:dds to 5.4.0#192295
auto-submit[bot] merged 2 commits into
flutter:flutter-3.47-candidate.0from
bkonyi:cp-dds-5.4.0

bkonyi commented Sep 4, 2026 •

edited

Loading

Uh oh!

flutter-dashboard Bot commented Sep 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

walley892 commented Sep 9, 2026

Uh oh!

auto-submit Bot commented Sep 9, 2026

Uh oh!

auto-submit Bot commented Sep 9, 2026

Uh oh!

walley892 commented Sep 9, 2026

Uh oh!

bkonyi commented Sep 9, 2026

Uh oh!

reidbaker commented Sep 15, 2026

Uh oh!

bkonyi commented Sep 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

bkonyi commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Link:

Impact Description:

Changelog Description:

Workaround:

Risk:

Test Coverage:

Validation Steps:

Uh oh!

flutter-dashboard Bot commented Sep 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

walley892 commented Sep 9, 2026

Uh oh!

auto-submit Bot commented Sep 9, 2026

Uh oh!

auto-submit Bot commented Sep 9, 2026

Uh oh!

walley892 commented Sep 9, 2026

Uh oh!

bkonyi commented Sep 9, 2026

Uh oh!

reidbaker commented Sep 15, 2026

Uh oh!

bkonyi commented Sep 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bkonyi commented Sep 4, 2026 •

edited

Loading