Skip to content

[CP-stable]On iOS 27+ devices, manually process lldb stops - #192810

Merged
auto-submit[bot] merged 1 commit into
flutter:flutter-3.47-candidate.0from
flutteractionsbot:cp-stable-af06e99a293b858c5b99e838d34a2e0247ee887d
Sep 15, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:flutter-3.47-candidate.0from
flutteractionsbot:cp-stable-af06e99a293b858c5b99e838d34a2e0247ee887d

Conversation

@flutteractionsbot

@flutteractionsbot flutteractionsbot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#190307

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)?
Does it impact development (ex. flutter doctor crashes when Android Studio is installed),
or the shipping of production apps (the app crashes on launch).
This information is for domain experts and release engineers to understand the consequences of saying yes or no to the cherry pick.

Debugging on iOS 27+ occasionally crashes.

Changelog Description:

Explain this cherry pick:

  • In one line that is accessible to most Flutter developers.
  • That describes the state prior to the fix.
  • That includes which platforms are impacted.
    See best practices for examples.

< Replace with changelog description here >
[flutter/190307] When debugging on physical iOS 27 devices, app occasionally crashes.

Workaround:

Is there a workaround for this issue?

No

Risk:

What is the risk level of this cherry-pick?

  • Low
  • Medium
  • High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

  • Yes
  • No

Validation Steps:

What are the steps to validate that this fix works?

Use example code a script to reproduce from #190307

On iOS 27+ devices, `lldb` sometimes doesn't stop on breakpoints when
auto-continue is enabled. To workaround this, we disable auto-continue
and manually process stops. If a stop is caused by a breakpoint, we tell
the process to continue. Otherwise, we print the backtrace and detach.

Fixes flutter#190307.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
@flutteractionsbot flutteractionsbot added the cp: review Cherry-picks in the review queue label Sep 15, 2026
@flutteractionsbot
flutteractionsbot requested review from a team as code owners September 15, 2026 15:13
@flutteractionsbot

Copy link
Copy Markdown
Contributor Author

@vashworth please fill out the PR description above, afterwards the release team will review this request.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 15, 2026
@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions Bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. platform-macos Building on or for macOS specifically a: desktop Running on desktop team-ios Owned by iOS platform team team-macos Owned by the macOS platform team labels Sep 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a workaround for iOS devices failing to stop at the JIT breakpoint in debug mode by adding conditional manual stop-handling logic to the LLDB attachment process based on the device's SDK version. The review feedback highlights a critical typo in the version check (using iOS version 27 instead of 17) that would prevent the workaround from executing on current devices. Additionally, the feedback identifies a potential race condition in the manual continue logic that could discard application logs, and suggests resetting the stop-tracking state immediately upon sending the continue command, along with updating the associated tests and comments.

Comment on lines +167 to +171
if (mode == BuildMode.debug &&
_deviceVersion != null &&
_deviceVersion >= Version(27, 0, 0)) {
manualContinue = true;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version check uses Version(27, 0, 0), which appears to be a typo for Version(17, 0, 0). iOS 17 introduced CoreDevice and devicectl, which is the version where this JIT breakpoint issue and the need for manual continue occurs. Using 27.0.0 will make this workaround dead code on all current iOS devices.

      if (mode == BuildMode.debug &&
          _deviceVersion != null &&
          _deviceVersion >= Version(17, 0, 0)) {
        manualContinue = true;
      }

Comment on lines +269 to 279
if (line.contains(_targetStoppedPattern)) {
if (stopLogs.any((log) => log.contains('stop reason = breakpoint'))) {
await _lldbProcess?.stdinWriteln(_processContinueCommand);
} else {
stopLogs.forEach(printLine);
await _lldbProcess?.stdinWriteln(_threadBacktraceAllCommand);
await _lldbProcess?.stdinWriteln(_detachCommand);
processIsStoppedAfterAttaching = false;
}
return;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

When manually continuing after hitting a breakpoint, processIsStoppedAfterAttaching is not reset to false and stopLogs is not cleared immediately. Instead, the code waits for the _lldbProcessResuming log. This creates a race condition: any application logs printed by the target immediately after resuming but before the _lldbProcessResuming log is processed will be added to stopLogs and permanently swallowed/discarded. Resetting the state and clearing stopLogs immediately when sending the continue command prevents this log loss.

            if (line.contains(_targetStoppedPattern)) {
              if (stopLogs.any((log) => log.contains('stop reason = breakpoint'))) {
                await _lldbProcess?.stdinWriteln(_processContinueCommand);
                processIsStoppedAfterAttaching = false;
                stopLogs.clear();
              } else {
                stopLogs.forEach(printLine);
                await _lldbProcess?.stdinWriteln(_threadBacktraceAllCommand);
                await _lldbProcess?.stdinWriteln(_detachCommand);
                processIsStoppedAfterAttaching = false;
              }
              return;
            }

Comment on lines +163 to +165
// iOS 27+ devices sometimes fail to stop at the JIT breakpoint (only used in debug mode)
// when `auto-continue` is enabled. This causes the app to crash. To workaround this, we
// manually listen for stops and continue the process if the stop is due to the breakpoint.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Update the comment to refer to iOS 17+ instead of iOS 27+.

      // iOS 17+ devices sometimes fail to stop at the JIT breakpoint (only used in debug mode)
      // when 'auto-continue' is enabled. This causes the app to crash. To workaround this, we
      // manually listen for stops and continue the process if the stop is due to the breakpoint.

logger: logger,
processUtils: processUtils,
xcodeProjectInterpreter: FakeXcodeProjectInterpreter(),
deviceVersion: Version(27, 0, 0),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Update the test device version to 17, 0, 0 to match the corrected iOS version check.

Suggested change
deviceVersion: Version(27, 0, 0),
deviceVersion: Version(17, 0, 0),

logger: logger,
processUtils: processUtils,
xcodeProjectInterpreter: FakeXcodeProjectInterpreter(),
deviceVersion: Version(27, 0, 0),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Update the test device version to 17, 0, 0 to match the corrected iOS version check.

Suggested change
deviceVersion: Version(27, 0, 0),
deviceVersion: Version(17, 0, 0),

});
});

testWithoutContext('Stops are handled manually for iOS 27+', () async {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Update the test description to refer to iOS 17+ instead of iOS 27+.

Suggested change
testWithoutContext('Stops are handled manually for iOS 27+', () async {
testWithoutContext('Stops are handled manually for iOS 17+', () async {

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 15, 2026
@auto-submit
auto-submit Bot merged commit d3c78d8 into flutter:flutter-3.47-candidate.0 Sep 15, 2026
12 checks passed
@flutteractionsbot
flutteractionsbot deleted the cp-stable-af06e99a293b858c5b99e838d34a2e0247ee887d branch September 15, 2026 20:29
@reidbaker-agent reidbaker-agent mentioned this pull request Sep 17, 2026
9 of 10 tasks
auto-submit Bot pushed a commit that referenced this pull request Sep 17, 2026
Adds the changelog section for 3.47.5, tracked by #192828.

<details>
<summary>Agent authored info</summary>
Covers the cherry-picks that landed on `flutter-3.47-candidate.0` since the `3.47.4` tag. Each entry uses the **Changelog Description** exactly as authored in the corresponding cherry-pick PR.

| Cherry-pick PR | Landed | Changelog reference |
| --- | --- | --- |
| [#192810](#192810) [CP-stable] On iOS 27+ devices, manually process lldb stops | `d3c78d8b3` | [flutter/190307](#190307) |
| [#192255](#192255) [stable] [Widget Preview] Isolate PageStorage scope in widget preview group expansion tile | `64d4f6282` | [flutter/191242](#191242) |
| [#192295](#192295) [stable] [flutter_tools] Roll package:dds to 5.4.0 | `0a12baff2` | [flutter/189507](#189507) |

Entries are ordered by the order the cherry-picks landed on the branch, matching the convention used for 3.47.4.

### Intentionally excluded

Two commits also landed in this range but are routine release infrastructure, not user-facing cherry-picks:

- [#192875](#192875) Update Flutter DEPS to Dart `b530c21f7de367b94fb04787bfed9d8e989d75e8`
- [#192894](#192894) Sync `engine.version` to `af7e796e161ae0bb1ff0758c71a7105418bd9ded`

This matches every prior hotfix in this series: the 3.47.1, 3.47.2, and 3.47.3 ranges each contained a Dart DEPS roll and an `engine.version` sync, and none were listed as changelog bullets.

### Note for the release manager

The `Issue Link` on [#192295](#192295) points at [#189507](#189507) ("Bump devtools_shared to 13.1.0", merged 2026-07-23), which does not appear to relate to the `package:dds` 5.4.0 roll that PR actually performs. The authored changelog text has been preserved verbatim rather than silently corrected. If that reference is wrong, the bullet should be repointed before this lands.

### Verification

- All three entry links return HTTP 200.
- The `3.47.5` tag link currently 404s because the release has not been tagged yet; it will resolve once "Push release with MPA" completes. This is expected, since the checklist places "Add changelog for stable release" before the release is pushed.

</details>

I have double checked with @bkonyi that there is no issue for the dds change because the issue when discovered was already fixed on master.
samueldwomoh222-gh pushed a commit to samueldwomoh222-gh/flutter that referenced this pull request Sep 26, 2026
Adds the changelog section for 3.47.5, tracked by flutter#192828.

<details>
<summary>Agent authored info</summary>
Covers the cherry-picks that landed on `flutter-3.47-candidate.0` since the `3.47.4` tag. Each entry uses the **Changelog Description** exactly as authored in the corresponding cherry-pick PR.

| Cherry-pick PR | Landed | Changelog reference |
| --- | --- | --- |
| [flutter#192810](flutter#192810) [CP-stable] On iOS 27+ devices, manually process lldb stops | `d3c78d8b3` | [flutter/190307](flutter#190307) |
| [flutter#192255](flutter#192255) [stable] [Widget Preview] Isolate PageStorage scope in widget preview group expansion tile | `64d4f6282` | [flutter/191242](flutter#191242) |
| [flutter#192295](flutter#192295) [stable] [flutter_tools] Roll package:dds to 5.4.0 | `0a12baff2` | [flutter/189507](flutter#189507) |

Entries are ordered by the order the cherry-picks landed on the branch, matching the convention used for 3.47.4.

Two commits also landed in this range but are routine release infrastructure, not user-facing cherry-picks:

- [flutter#192875](flutter#192875) Update Flutter DEPS to Dart `b530c21f7de367b94fb04787bfed9d8e989d75e8`
- [flutter#192894](flutter#192894) Sync `engine.version` to `af7e796e161ae0bb1ff0758c71a7105418bd9ded`

This matches every prior hotfix in this series: the 3.47.1, 3.47.2, and 3.47.3 ranges each contained a Dart DEPS roll and an `engine.version` sync, and none were listed as changelog bullets.

The `Issue Link` on [flutter#192295](flutter#192295) points at [flutter#189507](flutter#189507) ("Bump devtools_shared to 13.1.0", merged 2026-07-23), which does not appear to relate to the `package:dds` 5.4.0 roll that PR actually performs. The authored changelog text has been preserved verbatim rather than silently corrected. If that reference is wrong, the bullet should be repointed before this lands.

- All three entry links return HTTP 200.
- The `3.47.5` tag link currently 404s because the release has not been tagged yet; it will resolve once "Push release with MPA" completes. This is expected, since the checklist places "Add changelog for stable release" before the release is pushed.

</details>

I have double checked with @bkonyi that there is no issue for the dds change because the issue when discovered was already fixed on master.
LuizSant16 pushed a commit to LuizSant16/flutter that referenced this pull request Sep 30, 2026
Adds the changelog section for 3.47.5, tracked by flutter#192828.

<details>
<summary>Agent authored info</summary>
Covers the cherry-picks that landed on `flutter-3.47-candidate.0` since the `3.47.4` tag. Each entry uses the **Changelog Description** exactly as authored in the corresponding cherry-pick PR.

| Cherry-pick PR | Landed | Changelog reference |
| --- | --- | --- |
| [flutter#192810](flutter#192810) [CP-stable] On iOS 27+ devices, manually process lldb stops | `d3c78d8b3` | [flutter/190307](flutter#190307) |
| [flutter#192255](flutter#192255) [stable] [Widget Preview] Isolate PageStorage scope in widget preview group expansion tile | `64d4f6282` | [flutter/191242](flutter#191242) |
| [flutter#192295](flutter#192295) [stable] [flutter_tools] Roll package:dds to 5.4.0 | `0a12baff2` | [flutter/189507](flutter#189507) |

Entries are ordered by the order the cherry-picks landed on the branch, matching the convention used for 3.47.4.

Two commits also landed in this range but are routine release infrastructure, not user-facing cherry-picks:

- [flutter#192875](flutter#192875) Update Flutter DEPS to Dart `b530c21f7de367b94fb04787bfed9d8e989d75e8`
- [flutter#192894](flutter#192894) Sync `engine.version` to `af7e796e161ae0bb1ff0758c71a7105418bd9ded`

This matches every prior hotfix in this series: the 3.47.1, 3.47.2, and 3.47.3 ranges each contained a Dart DEPS roll and an `engine.version` sync, and none were listed as changelog bullets.

The `Issue Link` on [flutter#192295](flutter#192295) points at [flutter#189507](flutter#189507) ("Bump devtools_shared to 13.1.0", merged 2026-07-23), which does not appear to relate to the `package:dds` 5.4.0 roll that PR actually performs. The authored changelog text has been preserved verbatim rather than silently corrected. If that reference is wrong, the bullet should be repointed before this lands.

- All three entry links return HTTP 200.
- The `3.47.5` tag link currently 404s because the release has not been tagged yet; it will resolve once "Push release with MPA" completes. This is expected, since the checklist places "Add changelog for stable release" before the release is pushed.

</details>

I have double checked with @bkonyi that there is no issue for the dds change because the issue when discovered was already fixed on master.
LuisRodesDAM pushed a commit to LuisRodesDAM/flutter that referenced this pull request Oct 2, 2026
Adds the changelog section for 3.47.5, tracked by flutter#192828.

<details>
<summary>Agent authored info</summary>
Covers the cherry-picks that landed on `flutter-3.47-candidate.0` since the `3.47.4` tag. Each entry uses the **Changelog Description** exactly as authored in the corresponding cherry-pick PR.

| Cherry-pick PR | Landed | Changelog reference |
| --- | --- | --- |
| [flutter#192810](flutter#192810) [CP-stable] On iOS 27+ devices, manually process lldb stops | `d3c78d8b3` | [flutter/190307](flutter#190307) |
| [flutter#192255](flutter#192255) [stable] [Widget Preview] Isolate PageStorage scope in widget preview group expansion tile | `64d4f6282` | [flutter/191242](flutter#191242) |
| [flutter#192295](flutter#192295) [stable] [flutter_tools] Roll package:dds to 5.4.0 | `0a12baff2` | [flutter/189507](flutter#189507) |

Entries are ordered by the order the cherry-picks landed on the branch, matching the convention used for 3.47.4.

Two commits also landed in this range but are routine release infrastructure, not user-facing cherry-picks:

- [flutter#192875](flutter#192875) Update Flutter DEPS to Dart `b530c21f7de367b94fb04787bfed9d8e989d75e8`
- [flutter#192894](flutter#192894) Sync `engine.version` to `af7e796e161ae0bb1ff0758c71a7105418bd9ded`

This matches every prior hotfix in this series: the 3.47.1, 3.47.2, and 3.47.3 ranges each contained a Dart DEPS roll and an `engine.version` sync, and none were listed as changelog bullets.

The `Issue Link` on [flutter#192295](flutter#192295) points at [flutter#189507](flutter#189507) ("Bump devtools_shared to 13.1.0", merged 2026-07-23), which does not appear to relate to the `package:dds` 5.4.0 roll that PR actually performs. The authored changelog text has been preserved verbatim rather than silently corrected. If that reference is wrong, the bullet should be repointed before this lands.

- All three entry links return HTTP 200.
- The `3.47.5` tag link currently 404s because the release has not been tagged yet; it will resolve once "Push release with MPA" completes. This is expected, since the checklist places "Add changelog for stable release" before the release is pushed.

</details>

I have double checked with @bkonyi that there is no issue for the dds change because the issue when discovered was already fixed on master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD cp: review Cherry-picks in the review queue platform-ios iOS applications specifically platform-macos Building on or for macOS specifically team-ios Owned by iOS platform team team-macos Owned by the macOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants