Repository navigation
Reduce the number of gtest-parallel workers when running Impeller tests on Mac Minis used by CI - #189813
Merged
auto-submit[bot] merged 1 commit intoJul 24, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a helper function mac_hardware_model to retrieve the macOS hardware model and uses it to limit the number of parallel workers for Impeller unit tests on Mac Mini CI environments. Feedback on the changes highlights a critical issue where calling mac_hardware_model unconditionally on non-macOS platforms will trigger an assertion failure and crash the test runner. Additionally, the feedback points out that os.cpu_count() can return None or a value less than or equal to 2, which requires safer handling to prevent runtime errors.
jason-simmons
force-pushed
the
bug_189748_parallel_limit
branch
from
July 22, 2026 15:28
029bb14 to
16871db
Compare
…ts on Mac Minis used by CI flutter#188889 started using the Impeller rendering backends in playground tests run by the impeller_unittests harness. Since then, runs of OpenGLESSDF tests on macOS CI have been flaky. These flakes show up as gtest-parallel child processes that fail with exit code -5 (SIGTRAP). The affected CI machines are M1 Mac Minis (hardware model "Macmini9,1") This is an experiment to see if limiting the number of test cases run in parallel on these machines reduces the crashes. See flutter#189748
jason-simmons
force-pushed
the
bug_189748_parallel_limit
branch
from
July 23, 2026 16:38
16871db to
4ce3b4c
Compare
jason-simmons
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 25, 2026
flutter/flutter@b65f4d9...e292197 2026-07-25 [email protected] Roll Skia from 2c014dc494f1 to 62442d6cf0ec (1 revision) (flutter/flutter#190022) 2026-07-25 [email protected] Roll Skia from d8d20eef4dbd to 2c014dc494f1 (1 revision) (flutter/flutter#190020) 2026-07-25 [email protected] [Impeller] Add 2D texture array support (kTexture2DArray) (flutter/flutter#188778) 2026-07-24 [email protected] Bumped Engine AGP Dependencies to 9.1.0 for 3.50 (flutter/flutter#189417) 2026-07-24 [email protected] Roll Dart SDK from 153abd9a8296 to 28e63ac22d8d (2 revisions) (flutter/flutter#190013) 2026-07-24 [email protected] ci: add mac verify binaries workflow (flutter/flutter#190010) 2026-07-24 [email protected] Roll Skia from f2f9b52fe1ee to d8d20eef4dbd (21 revisions) (flutter/flutter#190011) 2026-07-24 [email protected] fix(ci): quote labels to fix yaml mapping error (flutter/flutter#190002) 2026-07-24 [email protected] Update contributing guidelines for commit message format (flutter/flutter#189922) 2026-07-24 [email protected] Migrate a11y_assessments to uiscene (flutter/flutter#189960) 2026-07-24 [email protected] docs(contributing): add git worktree and rebase workflow guide (flutter/flutter#189992) 2026-07-24 [email protected] Roll Dart SDK from e3fc57eae9eb to 153abd9a8296 (3 revisions) (flutter/flutter#189987) 2026-07-24 [email protected] Rename RegularWindow* to Window* in the windowing API + rename sizedToContent to shrinkWrap in the windowing API (flutter/flutter#189363) 2026-07-24 [email protected] Remove ancient `tools:tools` dep from `android_sdk` bundle (flutter/flutter#189962) 2026-07-24 [email protected] Reduce the number of gtest-parallel workers when running Impeller tests on Mac Minis used by CI (flutter/flutter#189813) 2026-07-24 [email protected] Roll Packages from 8260a1e to 6969329 (21 revisions) (flutter/flutter#189983) 2026-07-24 [email protected] Roll Fuchsia Linux SDK from 9org0yL3yZkp80x5S... to Cdb1RGKCqpcz9z4cl... (flutter/flutter#189975) 2026-07-24 [email protected] Roll Skia from 6e9c4687c001 to f2f9b52fe1ee (3 revisions) (flutter/flutter#189959) 2026-07-24 [email protected] [web] Cancel touch pointers WebKit abandons mid-gesture (flutter/flutter#189608) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
pull Bot
pushed a commit
to Superoldman96/flutter
that referenced
this pull request
Aug 5, 2026
…ller tests on Mac Minis used by CI (flutter#189813)" (flutter#190560) This reverts commit 285bf67. This was an experiment that tried to reduce the frequency of flakes when running Impeller OpenGLESSDF rendering tests. It is obsolete now that these tests were disabled by flutter#190469
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#188889 started using the Impeller rendering backends in playground tests run by the impeller_unittests harness.
Since then, runs of OpenGLESSDF tests on macOS CI have been flaky. These flakes show up as gtest-parallel child processes that fail with exit code -5 (SIGTRAP).
The affected CI machines are M1 Mac Minis (hardware model "Macmini9,1") This is an experiment to see if limiting the number of test cases run in parallel on these machines reduces the crashes.
See #189748