Repository navigation
Migrate a11y_assessments to uiscene - #189960
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the iOS runner configuration for accessibility assessments by adding scene manifest configurations to Info.plist and updating AppDelegate to conform to FlutterImplicitEngineDelegate. The feedback suggests refactoring the AppDelegate class to implement the FlutterImplicitEngineDelegate protocol conformance within a separate extension, in accordance with the Google Swift Style Guide.
LouiseHsu
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
flutter/flutter@b65f4d9...e292197 2026-07-25 [email protected] Roll Skia from 2c014dc494f1 to 62442d6cf0ec (1 revision) (flutter/flutter#190022) 2026-07-25 [email protected] Roll Skia from d8d20eef4dbd to 2c014dc494f1 (1 revision) (flutter/flutter#190020) 2026-07-25 [email protected] [Impeller] Add 2D texture array support (kTexture2DArray) (flutter/flutter#188778) 2026-07-24 [email protected] Bumped Engine AGP Dependencies to 9.1.0 for 3.50 (flutter/flutter#189417) 2026-07-24 [email protected] Roll Dart SDK from 153abd9a8296 to 28e63ac22d8d (2 revisions) (flutter/flutter#190013) 2026-07-24 [email protected] ci: add mac verify binaries workflow (flutter/flutter#190010) 2026-07-24 [email protected] Roll Skia from f2f9b52fe1ee to d8d20eef4dbd (21 revisions) (flutter/flutter#190011) 2026-07-24 [email protected] fix(ci): quote labels to fix yaml mapping error (flutter/flutter#190002) 2026-07-24 [email protected] Update contributing guidelines for commit message format (flutter/flutter#189922) 2026-07-24 [email protected] Migrate a11y_assessments to uiscene (flutter/flutter#189960) 2026-07-24 [email protected] docs(contributing): add git worktree and rebase workflow guide (flutter/flutter#189992) 2026-07-24 [email protected] Roll Dart SDK from e3fc57eae9eb to 153abd9a8296 (3 revisions) (flutter/flutter#189987) 2026-07-24 [email protected] Rename RegularWindow* to Window* in the windowing API + rename sizedToContent to shrinkWrap in the windowing API (flutter/flutter#189363) 2026-07-24 [email protected] Remove ancient `tools:tools` dep from `android_sdk` bundle (flutter/flutter#189962) 2026-07-24 [email protected] Reduce the number of gtest-parallel workers when running Impeller tests on Mac Minis used by CI (flutter/flutter#189813) 2026-07-24 [email protected] Roll Packages from 8260a1e to 6969329 (21 revisions) (flutter/flutter#189983) 2026-07-24 [email protected] Roll Fuchsia Linux SDK from 9org0yL3yZkp80x5S... to Cdb1RGKCqpcz9z4cl... (flutter/flutter#189975) 2026-07-24 [email protected] Roll Skia from 6e9c4687c001 to f2f9b52fe1ee (3 revisions) (flutter/flutter#189959) 2026-07-24 [email protected] [web] Cancel touch pointers WebKit abandons mid-gesture (flutter/flutter#189608) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Migrate dev/a11y_assessments/ to uiscene in preperation for accessibility bug bash
(and so it can launch w/ xcode 27)
Pre-launch Checklist
///).