Repository navigation
ci: add mac verify binaries workflow - #190010
Merged
auto-submit[bot] merged 3 commits intoJul 24, 2026
Merged
Conversation
- Extracts engine change detection logic from `wait-for-engine-build` into a reusable `has-engine-changes` composite action. - Introduces a new `mac-verify-binaries` GitHub Actions workflow. - Adds the `setup_android` parameter to the `composite-flutter-setup` action, allowing workflows to explicitly control whether the Android and Java SDKs are provisioned (defaulting to true to enforce specific toolchain versions). - Fixes an empty string check for `PUSH_BEFORE_SHA` in the `wait-for-engine-build` action. fixes: #189995
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new setup_android input to the composite Flutter setup action to allow Android SDK setup on GitHub-hosted runners, extracts engine change detection into a reusable has-engine-changes action, and refactors the engine build wait action to use it. Feedback highlights that writing to /opt/android/sdk on GitHub-hosted runners will cause permission errors, suggesting the use of a writable directory like $GITHUB_WORKSPACE/android-sdk and referencing $ANDROID_HOME instead of hardcoding paths.
Member
Author
|
/gemini review again. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request extracts the logic for checking engine changes into a reusable composite action, has-engine-changes, and updates the wait-for-engine-build action to use it. Feedback suggests optimizing the new action by skipping the engine change script execution when no files have changed.
zanderso
reviewed
Jul 24, 2026
zanderso
left a comment
zanderso
left a comment
Member
There was a problem hiding this comment.
Did you remove the Android SDK configuration from the PR?
Member
Author
I removed that file change. I think the composite setup could have more flags, but I don't think it was needed here. I tried running this locally, but ACT with self-hosted was not cooperating. |
e.g. test:
```
name: Test has-engine-changes Action
on: [push]
jobs:
test-action:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Check PWD and Git
run: |
pwd
ls -la
git config --global --add safe.directory '*' || true
git status || true
- name: Run local action
uses: ./.github/actions/has-engine-changes
id: engine_check
- name: Output results
run: echo "Action output was ${{ steps.engine_check.outputs.changed }}"
```
zanderso
approved these changes
Jul 24, 2026
zanderso
left a comment
zanderso
left a comment
Member
There was a problem hiding this comment.
lgtm w/ updates to title and description.
jtmcdole
changed the title
Member
Author
Ah, that was what you were asking about. done |
jtmcdole
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 25, 2026
flutter/flutter@b65f4d9...e292197 2026-07-25 [email protected] Roll Skia from 2c014dc494f1 to 62442d6cf0ec (1 revision) (flutter/flutter#190022) 2026-07-25 [email protected] Roll Skia from d8d20eef4dbd to 2c014dc494f1 (1 revision) (flutter/flutter#190020) 2026-07-25 [email protected] [Impeller] Add 2D texture array support (kTexture2DArray) (flutter/flutter#188778) 2026-07-24 [email protected] Bumped Engine AGP Dependencies to 9.1.0 for 3.50 (flutter/flutter#189417) 2026-07-24 [email protected] Roll Dart SDK from 153abd9a8296 to 28e63ac22d8d (2 revisions) (flutter/flutter#190013) 2026-07-24 [email protected] ci: add mac verify binaries workflow (flutter/flutter#190010) 2026-07-24 [email protected] Roll Skia from f2f9b52fe1ee to d8d20eef4dbd (21 revisions) (flutter/flutter#190011) 2026-07-24 [email protected] fix(ci): quote labels to fix yaml mapping error (flutter/flutter#190002) 2026-07-24 [email protected] Update contributing guidelines for commit message format (flutter/flutter#189922) 2026-07-24 [email protected] Migrate a11y_assessments to uiscene (flutter/flutter#189960) 2026-07-24 [email protected] docs(contributing): add git worktree and rebase workflow guide (flutter/flutter#189992) 2026-07-24 [email protected] Roll Dart SDK from e3fc57eae9eb to 153abd9a8296 (3 revisions) (flutter/flutter#189987) 2026-07-24 [email protected] Rename RegularWindow* to Window* in the windowing API + rename sizedToContent to shrinkWrap in the windowing API (flutter/flutter#189363) 2026-07-24 [email protected] Remove ancient `tools:tools` dep from `android_sdk` bundle (flutter/flutter#189962) 2026-07-24 [email protected] Reduce the number of gtest-parallel workers when running Impeller tests on Mac Minis used by CI (flutter/flutter#189813) 2026-07-24 [email protected] Roll Packages from 8260a1e to 6969329 (21 revisions) (flutter/flutter#189983) 2026-07-24 [email protected] Roll Fuchsia Linux SDK from 9org0yL3yZkp80x5S... to Cdb1RGKCqpcz9z4cl... (flutter/flutter#189975) 2026-07-24 [email protected] Roll Skia from 6e9c4687c001 to f2f9b52fe1ee (3 revisions) (flutter/flutter#189959) 2026-07-24 [email protected] [web] Cancel touch pointers WebKit abandons mid-gesture (flutter/flutter#189608) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wait-for-engine-buildinto a reusablehas-engine-changescomposite action.mac-verify-binariesGitHub Actions workflow.PUSH_BEFORE_SHAin thewait-for-engine-buildaction.fixes: #189995