Repository navigation
[WebParagraph] Fixing edge cases for wrapping text (with newlines) - #189858
Merged
Merged
Conversation
github-actions
Bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the web paragraph layout and wrapping logic to explicitly track and handle hard line breaks and empty lines, and optimizes line boundary queries using binary search. The review feedback identifies a missing return statement in TextLayout that results in dead code, a potential StateError when accessing visual blocks on empty lines, leftover debugging code that introduces performance overhead, and redundant control flow statements in TextWrapper.
But not for GetBoxesForRanges - it should return a list with an empty rectange, not an empty list
Apparently, text editing operates on it all the time, so everything has to be exactly as in SkParagraph
and reacting to Gemini code review
mdebbar
reviewed
Aug 12, 2026
Code needs some cleaning
Rusino
changed the title
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
mdebbar
requested changes
Sep 24, 2026
Contributor
Author
|
I updated tests to use generic Paragraph API so I can always test CanvasKit on them (as a source of truth). |
mdebbar
approved these changes
Sep 29, 2026
mdebbar
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 30, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 30, 2026
flutter/flutter@55b8f88...d649d2b 2026-09-30 [email protected] [Android] Update the CLI to reject passing engine configuration flags with a prebuilt binary in release mode (flutter/flutter#190870) 2026-09-30 [email protected] Roll Skia from af1e8b356dd1 to c7b323126bf0 (1 revision) (flutter/flutter#193569) 2026-09-30 [email protected] [web] Respect text affinity in getLineBoundary at a soft wrap (flutter/flutter#192664) 2026-09-30 [email protected] [tool] Migrate TestCommand and platform runner to modular dependency injection (flutter/flutter#190789) 2026-09-30 [email protected] Roll Skia from 3a20a0464d25 to af1e8b356dd1 (1 revision) (flutter/flutter#193564) 2026-09-30 [email protected] Roll Skia from 554ef62d11a9 to 3a20a0464d25 (6 revisions) (flutter/flutter#193556) 2026-09-30 [email protected] Use null aware elements in `platform_views.dart` (flutter/flutter#193214) 2026-09-30 [email protected] Replace deprecated `withOpacity` in `flutter_logo.dart` (flutter/flutter#192583) 2026-09-30 [email protected] Roll Skia from f441ca223b2b to 554ef62d11a9 (72 revisions) (flutter/flutter#193548) 2026-09-30 [email protected] Fix StrcmpFixed matching prefixes in the Vulkan embedder tests (flutter/flutter#192999) 2026-09-30 [email protected] Update Engine to test Android 17 AVD (flutter/flutter#193239) 2026-09-29 [email protected] Give the Vulkan test context the extensions Impeller requires (flutter/flutter#193002) 2026-09-29 [email protected] Rename "subtext" to "supportingTextPadding" in `FormField`'s documentation (flutter/flutter#183582) 2026-09-29 [email protected] Set --no-js-strongly-connected-components for DDC compiles by default (flutter/flutter#193485) 2026-09-29 [email protected] Split pre-AGP 8.3 module AAR test into a Java 17 pinned target (flutter/flutter#193467) 2026-09-29 [email protected] Remove no-shuffle from gen_defaults_test (flutter/flutter#192280) 2026-09-29 [email protected] Update guidance on bumping Dart (flutter/flutter#193131) 2026-09-29 [email protected] Remove vestigial `download_jdk` gclient var (flutter/flutter#188571) 2026-09-29 [email protected] Roll pub packages (flutter/flutter#193522) 2026-09-29 [email protected] [flutter_tools] Lazily initialize AndroidSdk platform and build-tools discovery (flutter/flutter#191972) 2026-09-29 [email protected] [tool] Migrate Web build subcommands and toolchain to modular dependency injection (flutter/flutter#190783) 2026-09-29 [email protected] Pin androidx.test dependencies in integration_test (flutter/flutter#193316) 2026-09-29 [email protected] [flutter_tools] Include flutter.js.map in web builds (flutter/flutter#192257) 2026-09-29 [email protected] [WebParagraph] Fixing edge cases for wrapping text (with newlines) (flutter/flutter#189858) 2026-09-29 [email protected] Bump customer testing version for flutter/devtools update (flutter/flutter#193511) 2026-09-29 [email protected] Roll Packages from ba0364a to 3c6ce59 (14 revisions) (flutter/flutter#193507) 2026-09-29 [email protected] [flutter_tools] Guard socket streams and done futures against socket reset errors (flutter/flutter#192941) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Rusino
added a commit
to Rusino/flutter
that referenced
this pull request
Oct 2, 2026
…tHeightBehavior and placeholder metrics Squash of webparagraph_height_and_placeholders rebased onto master after flutter#189858.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes newline (
\n) handling and caret/selection geometry inWebParagraphto matchSkParagraphbehavior, resolving misplaced cursor issues in multiline text fields on the web.Fixes #188320
Background
In Flutter text editing (
RenderEditable), caret positioning, line navigation, and selection rely directly onParagraphquery APIs (getPositionForOffset,getBoxesForRange,getLineBoundary,getLineNumberAt, andgetGlyphInfoAt).Previously,
WebParagraphdiverged fromSkParagraphin several key newline edge cases:\nas whitespace with positive advance width. InSkParagraph, newlines occupy zero physical width while retaining their logical text ranges."Hello\n") must generate an additional empty line where the cursor resides after pressing Enter.Changes
Explicit Hard Line Break Tracking (
wrapper.dart):\n) from collapsible whitespace in_LineBuilder.Logical vs. Physical Text Ranges (
layout.dart,paragraph.dart):physicalTextRangeonTextBlockto exclude\nfrom physical geometry calculations (bounds, selection rects, line widths) while preservingtextRangefor logical text operations.getGlyphInfoAtto report zero layout width for\nand synthesize end-of-line glyph bounds for newlines outside visual blocks.getPositionForOffsetandgetLineBoundarywithSkParagraphhit-testing rules, correctly handling empty trailing lines and cluster boundary affinity.SkParagraph-matching binary search ingetLineNumberAt.Testing
test/webparagraph/paragraph_edge_cases_test.dart(newline wrapping and empty line creation).test/webparagraph/paragraph_selection_caret_test.dart(caret hit-testing, affinities, and selection bounding boxes across multiline text).test/webparagraph/paragraph_line_metrics_test.dart(line geometry and width validation).webparagraphunit tests to ensure 1:1 parity withSkParagraph.