Repository navigation
[image_picker] Fix scaling 10-bit images - #12557
Merged
auto-submit[bot] merged 8 commits intoSep 23, 2026
Merged
Conversation
Using the source UIImage renderer format can create an unsupported 10-bit integer bitmap context, which produces an empty image during resizing. Render scaled images with a standard-range format while preserving scale and opacity so the result remains encodable.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the iOS image picker implementation to fix scaling of 10-bit images by setting the preferredRange of UIGraphicsImageRendererFormat to UIGraphicsImageRendererFormatRangeStandard. A unit test is added to verify that a 10-bit wide gamut image can be scaled and encoded as a JPEG. The review feedback suggests adding a nil check for cgImage in the new test to prevent a potential crash when calling CGImageGetBitsPerComponent if the image creation fails.
Comment on lines
+258
to
+259
| XCTAssertNotEqual(cgImage, nil); | ||
| XCTAssertEqual(CGImageGetBitsPerComponent(cgImage), 10); |
Contributor
There was a problem hiding this comment.
If cgImage fails to create and returns nil (for example, if the test environment or simulator does not support the kCIFormatRGB10 format), the test runner will crash when calling the CoreGraphics C function CGImageGetBitsPerComponent(cgImage) because C functions do not have nil safety. To prevent test suite crashes, we should check if cgImage is nil and return early after releasing the color space.
Suggested change
| XCTAssertNotEqual(cgImage, nil); | |
| XCTAssertEqual(CGImageGetBitsPerComponent(cgImage), 10); | |
| XCTAssertNotEqual(cgImage, nil); | |
| if (cgImage == nil) { | |
| CGColorSpaceRelease(displayP3ColorSpace); | |
| return; | |
| } | |
| XCTAssertEqual(CGImageGetBitsPerComponent(cgImage), 10); |
Contributor
Author
There was a problem hiding this comment.
Fixed in 8dca11c. The assertion still records the setup failure, and the early return prevents passing a null CGImageRef to Core Graphics.
0xthk
changed the title
…s-10-bit # Conflicts: # packages/image_picker/image_picker_ios/CHANGELOG.md # packages/image_picker/image_picker_ios/example/ios/RunnerTests/ImageUtilTests.m
Contributor
|
/cc @hellohuanlin |
hellohuanlin
reviewed
Sep 5, 2026
| UIGraphicsImageRendererFormat *imageRendererFormat = [[UIGraphicsImageRendererFormat alloc] init]; | ||
| imageRendererFormat.scale = imageToScale.imageRendererFormat.scale; | ||
| imageRendererFormat.opaque = imageToScale.imageRendererFormat.opaque; | ||
| imageRendererFormat.preferredRange = UIGraphicsImageRendererFormatRangeStandard; |
Contributor
There was a problem hiding this comment.
Can you add a comment explaining the fix here? Otherwise future contributor may try to clean this up back into the original buggy behavior.
Contributor
Author
There was a problem hiding this comment.
Added in 13b99f0. The comment explains that reusing the source format can request an unsupported 10-bit integer bitmap context and produce an empty scaled image, which is why we create a fresh standard-range format while preserving scale and opacity.
hellohuanlin
approved these changes
Sep 10, 2026
vashworth
added
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/12557, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
Bot
removed
the
autosubmit
tarrinneal
added
CICD
Open
11 tasks done
pull Bot
pushed a commit
to edisplay/flutter
that referenced
this pull request
Sep 24, 2026
…er#193289) Roll Packages from c2b58e1a97fb to 431ea69a42e2 (56 revisions) flutter/packages@c2b58e1...431ea69 2026-09-24 [email protected] [cross_file] Updates cross_file to a package separated federated plugin (flutter/packages#11010) 2026-09-23 [email protected] [material_ui] Remove static access of `copyWith` from `dart fix` golden tests for `ThemeData/TextTheme` (flutter/packages#12994) 2026-09-23 [email protected] [camera_avfoundation] Replace deprecated high-resolution capture APIs (flutter/packages#12372) 2026-09-23 [email protected] [pigeon] update nullish checks to use new isNullish method (flutter/packages#12985) 2026-09-23 [email protected] [ci] Assign batch release PR approver as reviewer on sync-back PR (flutter/packages#12976) 2026-09-23 [email protected] [image_picker] Fix scaling 10-bit images (flutter/packages#12557) 2026-09-23 [email protected] [material_ui] Improve Autocomplete, DrawerHeader, and Tooltip accessibility (flutter/packages#12918) 2026-09-23 [email protected] [google_fonts] Decouple GoogleFontsLite for full tree-shaking and add full feature parity (flutter/packages#12830) 2026-09-23 [email protected] [file_selector] Ignore flakey `file_selector_android` tests (flutter/packages#12992) 2026-09-23 [email protected] [CI] Remove bringup from `Mac_arm64 build_all_packages` targets (flutter/packages#12978) 2026-09-22 [email protected] [material_ui] Unskip 5 passing web tests in bottom_app_bar_test and text_field_test (flutter/packages#12983) 2026-09-22 [email protected] [cupertino_ui] Unskip 5 passing web tests in adaptive_text_selection_toolbar_test and text_field_test (flutter/packages#12984) 2026-09-22 [email protected] [go_router] Fix ShellRoute chrome dropped from semantics tree by ModalBarrier (flutter/packages#12353) 2026-09-22 [email protected] [material_ui] Add contrastLevel for M3 ColorScheme (flutter/packages#12743) 2026-09-22 [email protected] [go_router] Preserve nested pushes during config updates (flutter/packages#12611) 2026-09-22 [email protected] [material_ui] Migrate M3 Chip template to use new gen_defaults (flutter/packages#12847) 2026-09-22 [email protected] [material_ui] Fix LocalHistoryEntry leak when double tapping Drawer scrim (flutter/packages#12552) 2026-09-22 [email protected] Update suggested reviewers (flutter/packages#12974) 2026-09-22 [email protected] Sync release-material_ui-1.4.0 to main (flutter/packages#12966) 2026-09-22 [email protected] Sync release-cupertino_ui-1.1.1 to main (flutter/packages#12965) 2026-09-21 [email protected] [ci] Update repo for 3.47 stable release (flutter/packages#12959) 2026-09-21 [email protected] Manual roll Flutter from 27fec0e to 4fcd90b (1 revision) (flutter/packages#12904) 2026-09-21 [email protected] Revert "[go_router_builder] Migrate to material_ui" (flutter/packages#12962) 2026-09-21 [email protected] [material_ui] Update `material_ui` tests to prevent them from failing when framework `TextStyle` changes (flutter/packages#12728) 2026-09-21 [email protected] [go_router_builder] Migrate to material_ui (flutter/packages#12913) 2026-09-21 [email protected] [material_ui, cupertino_ui] Bump Flutter version from to 3.47 (flutter/packages#12944) 2026-09-21 [email protected] [cupertino_ui] Work around dart2wasm optional parameter inference bug in example checkbox tests (flutter/packages#12961) 2026-09-21 [email protected] [cupertino_ui] Work around dart2wasm optional parameter inference bug in checkbox_test.dart (flutter/packages#12956) 2026-09-21 [email protected] [google_sign_in] PR 3/4 Migrate ViewProvider and GID SDK wrappers from Objective-C to Swift (flutter/packages#12657) 2026-09-21 [email protected] [google_sign_in] PR 2/4 Migrate the plugin class from Objective-C to Swift. (flutter/packages#12655) 2026-09-20 [email protected] [cross_file_darwin] iOS/macOS implementation of `cross_file` (flutter/packages#12910) 2026-09-20 [email protected] [cross_file_web] Web implementation of `cross_file` (flutter/packages#12908) 2026-09-20 [email protected] [material_ui] Migrate M3 `InputChip` template to use new gen_defaults (flutter/packages#12850) 2026-09-20 [email protected] [material_ui] Migrate M3 Checkbox defaults to new gen_defaults (flutter/packages#12816) 2026-09-20 [email protected] [material_ui] Migrate M3 `FilterChip` template to use new gen_defaults (flutter/packages#12849) 2026-09-19 [email protected] [material_ui] Announce PopupMenuButton with a child as a button (flutter/packages#12585) 2026-09-19 [email protected] Roll Flutter (stable) from 9584c67 to 6a19cca (7 revisions) (flutter/packages#12950) 2026-09-18 [email protected] [material_ui] Reduce the `material_ui` non-wasm web test suite (flutter/packages#12763) 2026-09-18 [email protected] Replace `Mac_x64` builders with `Mac_arm64` ones (flutter/packages#12941) 2026-09-18 [email protected] [in_app_purchase_storekit] Use `_$SKPaymentDiscountWrapperToJson` (flutter/packages#12721) 2026-09-18 [email protected] [In_app _purchase] README excerpt examples and changelog (flutter/packages#12739) 2026-09-18 [email protected] [material_ui] Add alternative input method for `RangeSlider` in `NavigationMode.directional` (flutter/packages#12630) 2026-09-18 [email protected] [cross_file_android] Android implementation of `cross_file` (flutter/packages#12909) 2026-09-18 [email protected] [camera_platform_interface] Adds videoOutputPath support to startVideoRecording (flutter/packages#12667) 2026-09-17 [email protected] [cupertino_ui] Migrate a snippet in `CupertinoCheckbox`'s API doc to `{@example}` and add unit tests (flutter/packages#12180) 2026-09-17 [email protected] [material_ui] Default gen_defaults color helper prefix (flutter/packages#12848) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resizing a 10-bit wide-gamut UIImage can carry its source renderer format into UIGraphicsImageRenderer. On iOS 26 this can request an unsupported 10-bit integer bitmap context, producing a zero-size image and an empty XFile after JPEG conversion.
This change renders scaled images with a standard-range format while preserving the source scale and opacity. The native regression test synthesizes a Display-P3 kCIFormatRGB10 image and verifies that the same 1920-pixel and JPEG-quality path produces a non-empty, decodable image.
Fixes flutter/flutter#185623.
Tests
Pre-Review Checklist