Skip to content

Update Chrome for stable tests - #12747

Merged
stuartmorgan-g merged 4 commits into
flutter:mainfrom
stuartmorgan-g:stable-chrome-update
Sep 4, 2026
Merged

Update Chrome for stable tests#12747
stuartmorgan-g merged 4 commits into
flutter:mainfrom
stuartmorgan-g:stable-chrome-update

Conversation

@stuartmorgan-g

@stuartmorgan-g stuartmorgan-g commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

test 1.32.0 [requires at least Chrome 128], which caused OOB tree breakage. Our stable tests can't use the latest version of Chrome yet, so update from 125 to 137 so that the version of Chrome is compatible. (134, the oldest available in CIPD that's newer than 125, seemed to crash flakily.)

Fixes flutter/flutter#192248

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 4, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Sep 4, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version of the chrome_and_driver dependency from 125.0.6422.141 to 128.0.6613.137 in the .ci.yaml file. There are no review comments, and I have no feedback to provide.

@stuartmorgan-g stuartmorgan-g changed the title Update Chrome for stable tests to 128.0.6613.137 Update Chrome for stable tests to 134.0.6998.165 Sep 4, 2026
@stuartmorgan-g

stuartmorgan-g commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

It looks like 134 resolved the issue, as expected, but hit what I believe may be a browser crash during material_ui tests:

...
00:56 +30: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/input_decorator/input_decoration.3_test.dart
00:58 +30: test/input_decorator/input_decoration.3_test.dart: TextFormField is decorated
00:58 +31: test/input_decorator/input_decoration.3_test.dart: Decorations are correctly ordered
00:59 +32: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/input_decorator/input_decoration.0_test.dart
01:01 +32: test/input_decorator/input_decoration.0_test.dart: TextField is decorated
01:01 +33: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/input_decorator/input_decoration.2_test.dart
01:03 +33: test/input_decorator/input_decoration.2_test.dart: TextField is decorated
01:03 +34: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/input_decorator/input_decoration.prefix_icon.0_test.dart
01:05 +34: test/input_decorator/input_decoration.prefix_icon.0_test.dart: InputDecorator prefixIcon alignment
01:05 +35: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/input_decorator/input_decoration.suffix_icon.0_test.dart
01:07 +35: test/input_decorator/input_decoration.suffix_icon.0_test.dart: InputDecorator suffixIcon alignment
01:08 +36: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/input_decorator/input_decoration.1_test.dart
01:09 +36: test/input_decorator/input_decoration.1_test.dart: TextField is decorated
01:10 +37: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/input_decorator/input_decoration.label.0_test.dart
01:16 +37 -1: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/input_decorator/input_decoration.label.0_test.dart [E]
  Failed to load "test/input_decorator/input_decoration.label.0_test.dart": Connection closed before test suite loaded.
01:16 +37 -1: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/input_decorator/input_decoration.helper.0_test.dart
01:16 +37 -2: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/input_decorator/input_decoration.helper.0_test.dart [E]
  Failed to load "test/input_decorator/input_decoration.helper.0_test.dart": Connection closed before test suite loaded.
01:16 +37 -2: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/input_decorator/input_decoration.label_style_error.0_test.dart
01:16 +37 -3: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/input_decorator/input_decoration.label_style_error.0_test.dart [E]
  Failed to load "test/input_decorator/input_decoration.label_style_error.0_test.dart": Connection closed before test suite loaded.
01:16 +37 -3: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/refresh_indicator/refresh_indicator.2_test.dart
01:16 +37 -4: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/refresh_indicator/refresh_indicator.2_test.dart [E]
  Failed to load "test/refresh_indicator/refresh_indicator.2_test.dart": Connection closed before test suite loaded.
01:16 +37 -4: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/refresh_indicator/refresh_indicator.0_test.dart
01:16 +37 -5: loading /b/s/w/ir/x/w/packages/packages/material_ui/example/test/refresh_indicator/refresh_indicator.0_test.dart [E]
  Failed to load "test/refresh_indicator/refresh_indicator.0_test.dart": Connection closed before test suite loaded.
...

(Every test from this point on fails with the same error message.)

I'm re-running to see if it was just flake.

@stuartmorgan-g

stuartmorgan-g commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

For reference, it this doesn't work the other versions available to try are:

  • 137.0.7151.119
  • 138.0.7204.49
  • 141.0.7390.76

I'm not sure offhand when the flag changes that prevent us from adopting 145 on stable landed.

@stuartmorgan-g

stuartmorgan-g commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

Well, the test suite that failed before passed, but a different one crashed. I'm going to try 137.0.7151.119 and see if that's less flaky.

@stuartmorgan-g stuartmorgan-g changed the title Update Chrome for stable tests to 134.0.6998.165 Update Chrome for stable tests Sep 4, 2026
@stuartmorgan-g

stuartmorgan-g commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

No crashes with 137, just a timeout for the shard with material_ui. Hopefully that's the existing flake from it being close to the limit, and not 137 being slower. Re-running now.

(Worst case we can disable the stable web tests temporarily until we can figure out a sharding solution.)

@stuartmorgan-g

stuartmorgan-g commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Timed out again. I wonder if this is related to the headless mode discussed in #12486 (comment) ?

I'm going to force-land this since running but timing out is better than the status quo, and also I think the 90 minute timeout change doesn't actually take effect until it's submitted. Further iteration (e.g., temporarily disabling some tests on the non-wasm web stable tests) will likely be necessary to actually get the tree open.

@stuartmorgan-g
stuartmorgan-g merged commit 5362631 into flutter:main Sep 4, 2026
10 of 13 checks passed
This was referenced Sep 7, 2026
Closed
Closed
Closed
Closed
Closed
Merged
pull Bot pushed a commit to Mattlk13/flutter that referenced this pull request Sep 9, 2026
@engine-flutter-autoroll
Roll Packages from 9af9c6076d79 to 36e088a75b9b (24 revisions) (flutt…
63b9518 
…er#192485)

flutter/packages@9af9c60...36e088a

2026-09-09 [email protected] [quick_actions] Adopt code-excerpts
for README (flutter/packages#12643)
2026-09-08 [email protected] [camera_web] Fix
TypeError when reading the torch capability (flutter/packages#12647)
2026-09-08 [email protected] [google_maps_flutter_web] Avoid
replacing advanced marker content on move (flutter/packages#11952)
2026-09-08 [email protected] [material_ui][cupertino_ui] Change issue
tracker label in pubspec.yaml (flutter/packages#12792)
2026-09-08 [email protected] [material_ui] Fix FilledButton
Material 3 default style docs (flutter/packages#12620)
2026-09-08 [email protected] [infra] Use a
modified no-response workflow in flutter/packages
(flutter/packages#12745)
2026-09-08 [email protected] [material_ui]
Migrate M3 Banner template to use new gen_defaults
(flutter/packages#12734)
2026-09-08 [email protected] Roll Flutter from
63170e9 to b444e78 (13 revisions) (flutter/packages#12791)
2026-09-08 [email protected] Sync release-go_router-18.0.1 to
main (flutter/packages#12725)
2026-09-08 [email protected] Sync release-material_ui-1.1.1 to
main (flutter/packages#12726)
2026-09-08 [email protected] [tool] Adopt `platform` 3.2.0
(flutter/packages#12789)
2026-09-07 [email protected] [material_ui] Fix
SliverGeometry maxPaintExtent assertion in CarouselView.weighted
(flutter/packages#12563)
2026-09-05 [email protected] Roll Flutter from
5a6cfa7 to 63170e9 (15 revisions) (flutter/packages#12767)
2026-09-04 [email protected] Manual roll Flutter from
70797e1 to 5a6cfa7 (52 revisions) (flutter/packages#12760)
2026-09-04 [email protected] [material_ui] port drawer tests over
from flutter/widgets (flutter/packages#12711)
2026-09-04 [email protected] add cooldown (flutter/packages#12708)
2026-09-04 [email protected] [in_app_purchase] Support StoreKit 2
introductory offer eligibility JWS (flutter/packages#12584)
2026-09-04 [email protected] [material_ui]
Migrate M3 Badge template to use new gen_defaults
(flutter/packages#12733)
2026-09-04 [email protected] [google_maps_flutter] Convert heatmap
controller to Swift (flutter/packages#12713)
2026-09-04 [email protected] [material_ui] Remove
unused `maintainState` constructor parameter in `scaffold_test.dart`
(flutter/packages#12754)
2026-09-04 [email protected] [video_player_avfoundation]
Route video over AirPlay (flutter/packages#12490)
2026-09-04 [email protected] [google_fonts] Add
google_fonts_lite file to allow tree-shaking of the other huge files
(flutter/packages#11433)
2026-09-04 [email protected] Roll Flutter from
0cbd1a4 to 70797e1 (27 revisions) (flutter/packages#12727)
2026-09-04 [email protected] Update Chrome for stable tests
(flutter/packages#12747)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@stuartmorgan-g @victorsanni
Update Chrome for stable tests (flutter#12747)
ddc9927 
`test` 1.32.0 [requires at least Chrome 128], which caused OOB tree
breakage. Our `stable` tests can't use the latest version of Chrome yet,
so update from 125 to 137 so that the version of Chrome is compatible.
(134, the oldest available in CIPD that's newer than 125, seemed to
crash flakily.)

Fixes flutter/flutter#192248
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@stuartmorgan-g @victorsanni
Update Chrome for stable tests (flutter#12747)
da0d4bb 
`test` 1.32.0 [requires at least Chrome 128], which caused OOB tree
breakage. Our `stable` tests can't use the latest version of Chrome yet,
so update from 125 to 137 so that the version of Chrome is compatible.
(134, the oldest available in CIPD that's newer than 125, seemed to
crash flakily.)

Fixes flutter/flutter#192248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elliette elliette elliette approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flutter/packages tree closed on web unit tests due to package:test update

2 participants

@stuartmorgan-g @elliette