Repository navigation
[tool] Adopt platform 3.2.0 - #12789
Merged
Merged
Conversation
`platform` 3.2.0 added new APIs, and broke the ability to mock the old APIs. This updates all code to expect `NativePlatform` instead of `Platform`, and replaces `MockPlatform` with the upstream `TestNativePlatform`. Fixes flutter/flutter#192420
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the platform package dependency to ^3.2.0 and migrates the codebase from using Platform to NativePlatform. It replaces the custom MockPlatform class with createMockPlatform() returning a TestNativePlatform across the test suite, and refactors several test files to group platform-specific tests. A review comment identifies that the --no-swift flag test in format_command_test.dart runs on a Linux mock where Swift formatting is already skipped by default, and suggests running it with a macOS platform mock to ensure the flag is properly tested.
jmagman
approved these changes
Sep 8, 2026
stuartmorgan-g
added
emergency
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
Collaborator
Author
|
This is just waiting on the last slow web tests to finish; I'm going to force-land since other shards of those tests have finished, so if there were a tool-level issue that this had somehow introduced, it would have shown up, and I'd like to get the tree unblocked. |
danielleon-cmd
added a commit
to victogomez-cs/packages-fork
that referenced
this pull request
Sep 8, 2026
Resolves conflicting fixes for the same platform 3.2.0 breakage: main already landed the full migration (a26b623, "[tool] Adopt platform 3.2.0 (flutter#12789)"), which properly updates MockPlatform -> TestNativePlatform across script/tool instead of pinning the dependency backward. Took main's side entirely on both conflicting hunks (pubspec.yaml, CHANGELOG.md); this branch's own fix is now superseded and its diff against main is empty.
pull Bot
pushed a commit
to Mattlk13/flutter
that referenced
this pull request
Sep 9, 2026
…er#192485) flutter/packages@9af9c60...36e088a 2026-09-09 [email protected] [quick_actions] Adopt code-excerpts for README (flutter/packages#12643) 2026-09-08 [email protected] [camera_web] Fix TypeError when reading the torch capability (flutter/packages#12647) 2026-09-08 [email protected] [google_maps_flutter_web] Avoid replacing advanced marker content on move (flutter/packages#11952) 2026-09-08 [email protected] [material_ui][cupertino_ui] Change issue tracker label in pubspec.yaml (flutter/packages#12792) 2026-09-08 [email protected] [material_ui] Fix FilledButton Material 3 default style docs (flutter/packages#12620) 2026-09-08 [email protected] [infra] Use a modified no-response workflow in flutter/packages (flutter/packages#12745) 2026-09-08 [email protected] [material_ui] Migrate M3 Banner template to use new gen_defaults (flutter/packages#12734) 2026-09-08 [email protected] Roll Flutter from 63170e9 to b444e78 (13 revisions) (flutter/packages#12791) 2026-09-08 [email protected] Sync release-go_router-18.0.1 to main (flutter/packages#12725) 2026-09-08 [email protected] Sync release-material_ui-1.1.1 to main (flutter/packages#12726) 2026-09-08 [email protected] [tool] Adopt `platform` 3.2.0 (flutter/packages#12789) 2026-09-07 [email protected] [material_ui] Fix SliverGeometry maxPaintExtent assertion in CarouselView.weighted (flutter/packages#12563) 2026-09-05 [email protected] Roll Flutter from 5a6cfa7 to 63170e9 (15 revisions) (flutter/packages#12767) 2026-09-04 [email protected] Manual roll Flutter from 70797e1 to 5a6cfa7 (52 revisions) (flutter/packages#12760) 2026-09-04 [email protected] [material_ui] port drawer tests over from flutter/widgets (flutter/packages#12711) 2026-09-04 [email protected] add cooldown (flutter/packages#12708) 2026-09-04 [email protected] [in_app_purchase] Support StoreKit 2 introductory offer eligibility JWS (flutter/packages#12584) 2026-09-04 [email protected] [material_ui] Migrate M3 Badge template to use new gen_defaults (flutter/packages#12733) 2026-09-04 [email protected] [google_maps_flutter] Convert heatmap controller to Swift (flutter/packages#12713) 2026-09-04 [email protected] [material_ui] Remove unused `maintainState` constructor parameter in `scaffold_test.dart` (flutter/packages#12754) 2026-09-04 [email protected] [video_player_avfoundation] Route video over AirPlay (flutter/packages#12490) 2026-09-04 [email protected] [google_fonts] Add google_fonts_lite file to allow tree-shaking of the other huge files (flutter/packages#11433) 2026-09-04 [email protected] Roll Flutter from 0cbd1a4 to 70797e1 (27 revisions) (flutter/packages#12727) 2026-09-04 [email protected] Update Chrome for stable tests (flutter/packages#12747) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
`platform` 3.2.0 added new APIs, and broke the ability to mock the old APIs. This updates all code to expect `NativePlatform` instead of `Platform`, and replaces `MockPlatform` with the upstream `TestNativePlatform`. Fixes flutter/flutter#192420
victorsanni
pushed a commit
to victorsanni/packages
that referenced
this pull request
Sep 9, 2026
`platform` 3.2.0 added new APIs, and broke the ability to mock the old APIs. This updates all code to expect `NativePlatform` instead of `Platform`, and replaces `MockPlatform` with the upstream `TestNativePlatform`. Fixes flutter/flutter#192420
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platform3.2.0 added new APIs, and broke the ability to mock the old APIs. This updates all code to expectNativePlatforminstead ofPlatform, and replacesMockPlatformwith the upstreamTestNativePlatform.Fixes flutter/flutter#192420