Skip to content

[material_ui] Remove unused maintainState constructor parameter in scaffold_test.dart - #12754

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
b-luk:unused-optional-parameter-maintainState
Sep 4, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:mainfrom
b-luk:unused-optional-parameter-maintainState

Conversation

@b-luk

@b-luk b-luk commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Fixes flutter/flutter#192293

Dart SDK into Flutter AutoRoller is currently failing due to dart analyze failure on material_ui:

warning - test/scaffold_test.dart:3880:49 - A value for optional parameter 'maintainState' isn't ever given. Try removing the unused parameter. - unused_element_parameter

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 4, 2026
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 4, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the _CustomPageRoute class in scaffold_test.dart by removing the maintainState parameter from the constructor and directly initializing the maintainState field to true. There are no review comments, and I have no feedback to provide.

@b-luk
b-luk requested a review from elliette September 4, 2026 16:29

@elliette elliette left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for investigating, this seems fine to me!

@b-luk b-luk added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 4, 2026
@auto-submit
auto-submit Bot merged commit bfc3b6c into flutter:main Sep 4, 2026
12 checks passed
@b-luk
b-luk deleted the unused-optional-parameter-maintainState branch September 4, 2026 21:26
pull Bot pushed a commit to Mattlk13/flutter that referenced this pull request Sep 9, 2026
…er#192485)

flutter/packages@9af9c60...36e088a

2026-09-09 [email protected] [quick_actions] Adopt code-excerpts
for README (flutter/packages#12643)
2026-09-08 [email protected] [camera_web] Fix
TypeError when reading the torch capability (flutter/packages#12647)
2026-09-08 [email protected] [google_maps_flutter_web] Avoid
replacing advanced marker content on move (flutter/packages#11952)
2026-09-08 [email protected] [material_ui][cupertino_ui] Change issue
tracker label in pubspec.yaml (flutter/packages#12792)
2026-09-08 [email protected] [material_ui] Fix FilledButton
Material 3 default style docs (flutter/packages#12620)
2026-09-08 [email protected] [infra] Use a
modified no-response workflow in flutter/packages
(flutter/packages#12745)
2026-09-08 [email protected] [material_ui]
Migrate M3 Banner template to use new gen_defaults
(flutter/packages#12734)
2026-09-08 [email protected] Roll Flutter from
63170e9 to b444e78 (13 revisions) (flutter/packages#12791)
2026-09-08 [email protected] Sync release-go_router-18.0.1 to
main (flutter/packages#12725)
2026-09-08 [email protected] Sync release-material_ui-1.1.1 to
main (flutter/packages#12726)
2026-09-08 [email protected] [tool] Adopt `platform` 3.2.0
(flutter/packages#12789)
2026-09-07 [email protected] [material_ui] Fix
SliverGeometry maxPaintExtent assertion in CarouselView.weighted
(flutter/packages#12563)
2026-09-05 [email protected] Roll Flutter from
5a6cfa7 to 63170e9 (15 revisions) (flutter/packages#12767)
2026-09-04 [email protected] Manual roll Flutter from
70797e1 to 5a6cfa7 (52 revisions) (flutter/packages#12760)
2026-09-04 [email protected] [material_ui] port drawer tests over
from flutter/widgets (flutter/packages#12711)
2026-09-04 [email protected] add cooldown (flutter/packages#12708)
2026-09-04 [email protected] [in_app_purchase] Support StoreKit 2
introductory offer eligibility JWS (flutter/packages#12584)
2026-09-04 [email protected] [material_ui]
Migrate M3 Badge template to use new gen_defaults
(flutter/packages#12733)
2026-09-04 [email protected] [google_maps_flutter] Convert heatmap
controller to Swift (flutter/packages#12713)
2026-09-04 [email protected] [material_ui] Remove
unused `maintainState` constructor parameter in `scaffold_test.dart`
(flutter/packages#12754)
2026-09-04 [email protected] [video_player_avfoundation]
Route video over AirPlay (flutter/packages#12490)
2026-09-04 [email protected] [google_fonts] Add
google_fonts_lite file to allow tree-shaking of the other huge files
(flutter/packages#11433)
2026-09-04 [email protected] Roll Flutter from
0cbd1a4 to 70797e1 (27 revisions) (flutter/packages#12727)
2026-09-04 [email protected] Update Chrome for stable tests
(flutter/packages#12747)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
…`scaffold_test.dart` (flutter#12754)

Fixes flutter/flutter#192293

Dart SDK into Flutter AutoRoller is currently failing due to dart analyze failure on material_ui:

```
warning - test/scaffold_test.dart:3880:49 - A value for optional parameter 'maintainState' isn't ever given. Try removing the unused parameter. - unused_element_parameter
```

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
…`scaffold_test.dart` (flutter#12754)

Fixes flutter/flutter#192293

Dart SDK into Flutter AutoRoller is currently failing due to dart analyze failure on material_ui:

```
warning - test/scaffold_test.dart:3880:49 - A value for optional parameter 'maintainState' isn't ever given. Try removing the unused parameter. - unused_element_parameter
```

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dart SDK into Flutter AutoRoller failing due to dart analyze failure on material_ui

2 participants