Repository navigation
[v2] core: honor context while waiting for reauthentication - #3950
Merged
Merged
Conversation
github-actions
Bot
added
v2
Contributor
|
#3930 will add the missing test helpers. |
|
coverage: 63.906% (+0.01%) from 63.893% — bp-v2-f2a09ac into v2 |
mandre
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #3939
Fixes #3922
A request waiting for another goroutine's reauthentication ignores its context and can remain blocked past its deadline. This change lets the waiter return
ctx.Err()without interrupting the active reauthentication.ErrErrorAfterReauthenticationnow unwraps the retried request error, allowingResponseCodeIsto detect status codes such as 404.Links to the line numbers/files in the OpenStack source code that support the code in this PR:
N/A. This changes client-side synchronization and error handling.