Skip to content

Clean up Cypher parser helpers - #1515

Merged
lmeyerov merged 1 commit into
masterfrom
issue-1510-parser-cleanup
May 18, 2026
Merged

lmeyerov merged 1 commit into
masterfrom
issue-1510-parser-cleanup

Conversation

@lmeyerov

@lmeyerov lmeyerov commented May 17, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1510.

Summary

  • remove stale Cypher parser transformer hooks that no longer map to grammar rules
  • DRY MATCH and OPTIONAL MATCH AST construction through one private helper
  • add parser coverage for optional bound and optional shortestPath alias metadata
  • update CHANGELOG.md

Validation

  • python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_parser.py -k "optional_bound_pattern or optional_shortest_path"
  • python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_parser.py
  • python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "(shortestPath or bound_variable_length_relationship_pattern_alias or optional_match) and not cudf"
  • ./bin/ruff.sh graphistry/compute/gfql/cypher/parser.py graphistry/tests/compute/gfql/cypher/test_parser.py
  • ./bin/typecheck.sh graphistry/compute/gfql/cypher/parser.py
  • git diff --check origin/master...HEAD
  • review skill wave 3 refresh after rebase: converged, no findings
  • ssh dgx-spark RAPIDS 25.02 gfql: parser suite + explicit cuDF optional-match sentinels, 148 passed
  • ssh dgx-spark RAPIDS 26.02 gfql: parser suite + explicit cuDF optional-match sentinels, 148 passed

Rebase Notes

Notes

  • Local cuDF-selected lowering run hit cudaErrorNoDevice on this host; the same explicit cuDF sentinels passed on dgx-spark for RAPIDS 25.02 and 26.02.
  • No DGX rerun was needed after the rebase because the conflict was changelog-only and the code diff remains parser-only.

@lmeyerov
lmeyerov force-pushed the issue-1510-parser-cleanup branch from 32726b0 to 4b0840f Compare May 18, 2026 01:44
@lmeyerov
lmeyerov merged commit aad5d76 into master May 18, 2026
137 checks passed
@lmeyerov
lmeyerov deleted the issue-1510-parser-cleanup branch May 18, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GFQL cleanup: parser.py dead-code and grammar helper audit

1 participant