Repository navigation
version 2.6.3.4 - #300
Merged
Merged
version 2.6.3.4#300
Conversation
`recvLen` is a hack to get around performance issues of `length` on `String`. Its warning was pointing to a non existant function in `Network.Socket.ByteString`.
The symptom was that `cabal sdist` would rightly fail with ``` Building source dist for network-2.6.3.2... cabal: can't find include file HsNetworkConfig.h ``` Instead, the proper way is to inject autogenerated C header files via .buildinfo (which is generated at `configure`-time).
We want to test network with the verison of `cabal-install` that is most likely to be found in the wild. This commit switches the required builds to run with `cabal-install-2.0` and includes a failable pass with `cabal-install-head` and `ghc-head`.
* closing socket when it becames unreachable for GC. * GHC 7.4 does not provide mkWeakMVar.
* Fix finalizer getting triggered in ghc 8.2.2 GHC 8.2.2 more aggresively reclaims `Weak`. This causes the socket to be closed in `accept` before `c_accept` is called. Utilizing `withMVar` allows the reference to be held until `c_accept` has been called. * Update variable for readability.
It is common to close a file descriptor after sending it, however it is not a required part of the work flow. There are uses for not closing a file descriptor. Closing the file descriptor is too high level of a decision.
3 tasks done
Collaborator
Author
|
@eborden Would you review this PR? The finalizer is already reverted. |
eborden
approved these changes
Feb 5, 2018
Collaborator
Author
|
FF-merged. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes necessary bug fixes and document updates.
No deprecating.
This should be merged by fast-forward.