Skip to content

version 2.6.3.4 - #300

Merged
kazu-yamamoto merged 48 commits into
haskell:2.6from
kazu-yamamoto:poc-2.6.3.4
Feb 6, 2018
Merged

kazu-yamamoto merged 48 commits into
haskell:2.6from
kazu-yamamoto:poc-2.6.3.4

Conversation

@kazu-yamamoto

Copy link
Copy Markdown
Collaborator

This includes necessary bug fixes and document updates.
No deprecating.

This should be merged by fast-forward.

eborden and others added 30 commits January 29, 2018 10:39
`recvLen` is a hack to get around performance issues of `length` on
`String`. Its warning was pointing to a non existant function in
`Network.Socket.ByteString`.
The symptom was that `cabal sdist` would rightly fail with

```
Building source dist for network-2.6.3.2...
cabal: can't find include file HsNetworkConfig.h
```

Instead, the proper way is to inject autogenerated C header files
via .buildinfo (which is generated at `configure`-time).
We want to test network with the verison of `cabal-install` that is most
likely to be found in the wild. This commit switches the required builds
to run with `cabal-install-2.0` and includes a failable pass with
`cabal-install-head` and `ghc-head`.
kazu-yamamoto and others added 15 commits January 29, 2018 11:24
* closing socket when it becames unreachable for GC.

* GHC 7.4 does not provide mkWeakMVar.
* Fix finalizer getting triggered in ghc 8.2.2

GHC 8.2.2 more aggresively reclaims `Weak`. This causes the socket to be
closed in `accept` before `c_accept` is called. Utilizing `withMVar`
allows the reference to be held until `c_accept` has been called.

* Update variable for readability.
It is common to close a file descriptor after sending it, however it is
not a required part of the work flow. There are uses for not closing a
file descriptor. Closing the file descriptor is too high level of a
decision.
@kazu-yamamoto
kazu-yamamoto requested a review from eborden January 29, 2018 05:57
@kazu-yamamoto kazu-yamamoto mentioned this pull request Jan 30, 2018
3 tasks done
@kazu-yamamoto

Copy link
Copy Markdown
Collaborator Author

@eborden Would you review this PR? The finalizer is already reverted.

@kazu-yamamoto
kazu-yamamoto merged commit 7b22bec into haskell:2.6 Feb 6, 2018
@kazu-yamamoto
kazu-yamamoto deleted the poc-2.6.3.4 branch February 6, 2018 00:34
@kazu-yamamoto

Copy link
Copy Markdown
Collaborator Author

FF-merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants