Skip to content

Enh/image suggestions - #701

Merged
tacruc merged 14 commits into
masterfrom
enh/image-suggestions
Jan 1, 2023
Merged

tacruc merged 14 commits into
masterfrom
enh/image-suggestions

Conversation

@tacruc

@tacruc tacruc commented Mar 21, 2022 •

Copy link
Copy Markdown
Collaborator

This branch bring the photo location suggestions to vue. (Previously called nonlocalized photos.)
This PR contains only the fronted part, which works quite nicely and it requires #700.

The Implemented Workflow:

  1. The user can load photo location suggestions from the Actions in the photos app Navigation Menu
  2. Images are shown on the map and the sidebar opens.
    • If no suggestions are received from the backend there is an information in the sidebar
  3. The user selects suggestions by clicking on the image shown on the map.
    • If no suggestion is selected there is a information in the sidebar, that suggestions can be selected by clicking them on the map
    • There is a select all button
    • A clear selection button
    • A a cancel button
    • A save button
  4. Clicking the save button will store the suggested location into the selected images.

To test this branch you have to make the back-end deliver photo-suggestions. While this should work principle, it has many cases, where it just doesn't work. To test the branch I patched the PhotoController.php locally to provide dummy data.

     /**
     * @NoAdminRequired
     * @NoCSRFRequired
     */
    public function getNonLocalizedPhotosFromDb() {
        $result = $this->geophotoService->getNonLocalizedFromDB($this->userId);
	//Get Suggestions for Development fix real suggestions later
	$result = $this->geophotoService->getAllFromDB($this->userId);
	foreach ($result as $r) {
		$r->lat = $r->lat + 0.1;
		$r->lng = $r->lng + 0.1;
	}
        return new DataResponse($result);
    }

Changes which improve the backend are in:

To test this PR with backend improvements checkout enh/image-suggestions-with-backend.

@tacruc
tacruc requested a review from julien-nc March 21, 2022 23:44
@julien-nc

Copy link
Copy Markdown
Member

It requires #701.

Do you mean #700 ?

Could you describe what this does? What does it suggest? Location for non-localized photos?

@tacruc

tacruc commented Mar 22, 2022

Copy link
Copy Markdown
Collaborator Author

It requires #701.

Do you mean #700 ?

Yes

Could you describe what this does? What does it suggest? Location for non-localized photos?

Yes, Do you mean to describe it here in the PR for you and other reviewers or for the user of the maps app?

@julien-nc

Copy link
Copy Markdown
Member

Yes here 😁 I didn't immediately get what it was about.

If it requires some explanation in the UI, then there too 😁.

@tacruc
tacruc force-pushed the enh/image-suggestions branch from 81dfc00 to 13c9951 Compare March 23, 2022 10:19
@tacruc
tacruc force-pushed the enh/image-suggestions branch from 5620fc5 to de037ec Compare March 23, 2022 16:07
@tacruc tacruc mentioned this pull request Apr 1, 2022
12 of 15 tasks
@tacruc
tacruc force-pushed the enh/image-suggestions branch from 7986c28 to 3c1a847 Compare April 1, 2022 16:48
Base automatically changed from enh/vue-rewrite to master April 14, 2022 10:02
@tacruc
tacruc force-pushed the enh/image-suggestions branch from 3c1a847 to 5ff2946 Compare April 14, 2022 12:57
@codecov-commenter

codecov-commenter commented Jun 25, 2022 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.03%. Comparing base (c51b083) to head (48a37fc).
Report is 2419 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #701      +/-   ##
============================================
- Coverage     58.31%   57.03%   -1.28%     
- Complexity     1138     1153      +15     
============================================
  Files            42       47       +5     
  Lines          3481     3538      +57     
============================================
- Hits           2030     2018      -12     
- Misses         1451     1520      +69     
Flag Coverage Δ
unittests 57.03% <ø> (-1.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tacruc
tacruc merged commit 694f31b into master Jan 1, 2023
@tacruc
tacruc deleted the enh/image-suggestions branch January 1, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants