Repository navigation
Enh/image suggestions - #701
Merged
Merged
Conversation
Member
Collaborator
Author
Member
|
Yes here 😁 I didn't immediately get what it was about. If it requires some explanation in the UI, then there too 😁. |
tacruc
force-pushed
the
enh/image-suggestions
branch
from
March 23, 2022 10:19
81dfc00 to
13c9951
Compare
This was referenced Mar 23, 2022
Merged
tacruc
force-pushed
the
enh/image-suggestions
branch
from
March 23, 2022 16:07
5620fc5 to
de037ec
Compare
12 of 15 tasks
tacruc
force-pushed
the
enh/image-suggestions
branch
from
April 1, 2022 16:48
7986c28 to
3c1a847
Compare
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
tacruc
force-pushed
the
enh/image-suggestions
branch
from
April 14, 2022 12:57
3c1a847 to
5ff2946
Compare
Signed-off-by: Arne Hamann <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #701 +/- ##
============================================
- Coverage 58.31% 57.03% -1.28%
- Complexity 1138 1153 +15
============================================
Files 42 47 +5
Lines 3481 3538 +57
============================================
- Hits 2030 2018 -12
- Misses 1451 1520 +69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch bring the photo location suggestions to vue. (Previously called nonlocalized photos.)
This PR contains only the fronted part, which works quite nicely and it requires #700.
The Implemented Workflow:
To test this branch you have to make the back-end deliver photo-suggestions. While this should work principle, it has many cases, where it just doesn't work. To test the branch I patched the PhotoController.php locally to provide dummy data.
Changes which improve the backend are in:
To test this PR with backend improvements checkout enh/image-suggestions-with-backend.