6.3 lkgr - #21

[email protected]

Change-Id: I323a4b4e27c3c623cd58aef8a7a13a5dcf135755
Reviewed-on: https://chromium-review.googlesource.com/716116
Reviewed-by: Michael Hablich <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#1}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I419977d23adf80a7ef57e8b3d17307847f48406f
Reviewed-on: https://chromium-review.googlesource.com/715779
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#2}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

BUG=chromium:318206
[email protected], [email protected]
LOG=n
NOTRY=true
NOPRESUBMIT=true

Change-Id: I23869d1c27c39e940bf30664e7d4d6f5eb92b58d
Reviewed-on: https://chromium-review.googlesource.com/715764
Reviewed-by: Michael Hablich <[email protected]>
Commit-Queue: Michael Hablich <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#3}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ib7b011eeb7ffd1ab55559559fc2399d5ec0fa68c
Reviewed-on: https://chromium-review.googlesource.com/716236
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#4}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

Revision: a445b97

Should fix build problem on 6.3.

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I8c679afc5003ebe3ccae926e7a752fa1f9e67bd7
Reviewed-on: https://chromium-review.googlesource.com/716225
Reviewed-by: Michael Hablich <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#5}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I3867c48296c3c5d5f636d35e3cfd0376b433c7c1
Reviewed-on: https://chromium-review.googlesource.com/716237
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#6}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

This reverts commit d9a2584.
This is for 6.3 branch (to go with Chromium 63 branch). 

Reason for revert:

I'm reverting this CL for a few reasons. #2 is the most significant and
I should have thought of that before making a switch. Sorry for that.

1) perf-regression: http://crbug.com/769706
2) http://crbug.com/612010 : ICU timezone update is not propagated to
zygote process so that new tabs will hold on to an old timezone even
after a timezone change on Linux and Chrome OS.

3)  http://crbug.com/754053  : OS timezone detection issues on macOS
10.13, Ubutu 16, RHEL 7, SuSe Linux 12 or newer. ; it's being fixed. So,
it actually ok.

4)  http://crbug.com/771868  : timezone wrong in gmail: If it's due to

Revision: 28ef8dc

BUG=chromium:612010,chromium:769706,chromium:771868,v8:2137,v8:6031,v8:6076
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected], [email protected]

Change-Id: Id0093c2bc69e5bc1d3b7147b7bbcc633ed625a45
Reviewed-on: https://chromium-review.googlesource.com/721919
Reviewed-by: Adam Klein <[email protected]>
Commit-Queue: Jungshik Shin <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#7}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ib8890215f805bc52e0934b85d3148004d8905202
Reviewed-on: https://chromium-review.googlesource.com/721980
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#8}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

Revision: 69bd294

Merge to 6.3 branch

- remove unused Runtime_GetLanguageTagVariants
- add test for another related bug (chromium:770452) as well as for
chromium:770450 .

BUG=chromium:770450,chromium:770452
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
Change-Id: Ia2c6dd2156c51995fb18228fc3062a86e78d719c
Reviewed-on: https://chromium-review.googlesource.com/721844
Reviewed-by: Adam Klein <[email protected]>
Commit-Queue: Jungshik Shin <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#9}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I0a6e5fbf8480961e228d48df9da3eccc9c1d2b21
Reviewed-on: https://chromium-review.googlesource.com/721981
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#10}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

…cts.

Revision: 6aa9f43

BUG=chromium:763073
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: If8a8ebf9e176e862912010deb1a54ae484bd45e3
Reviewed-on: https://chromium-review.googlesource.com/722639
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#11}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

… bits).

Revision: a803fad

BUG=v8:6916
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: I4236e37ee9693bed3f4bb65e43b33d8da94cf634
Reviewed-on: https://chromium-review.googlesource.com/722640
Reviewed-by: Benedikt Meurer <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#12}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I7579594e7dafe60bfb2b65df09fb3425d8c04d40
Reviewed-on: https://chromium-review.googlesource.com/722082
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#13}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

Merged: [ic] Do access checks when storing via JSGlobalProxy.
Revision: 5ea95fe

Merged: [ic] Fix storing to JSGlobalProxy having JSProxy in prototype chain.
Revision: b19a1ba

BUG=chromium:764219
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: Icc7dde6ba3faae1aee29c4f3ac1aaa27d94f3124
Reviewed-on: https://chromium-review.googlesource.com/721443
Reviewed-by: Toon Verwaest <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#14}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I11f567e375bacb9c2774b2ecd9efb5792426021c
Reviewed-on: https://chromium-review.googlesource.com/721943
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#15}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

Parser creates a FunctionState for default ctors, which affects the
next_function_is_likely_called logic. PreParser needs to match that logic, so
that Parser and PreParser agree about which functions are skippable.

BUG=v8:5515, chromium:773576
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I96cb6f5aa68e74389a863355f70a34693a2d1329
Reviewed-on: https://chromium-review.googlesource.com/712579
Commit-Queue: Marja Hölttä <[email protected]>
Reviewed-by: Adam Klein <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#48511}(cherry picked from commit dd18faf)
Reviewed-on: https://chromium-review.googlesource.com/723519
Reviewed-by: Michael Hablich <[email protected]>
Commit-Queue: Michael Hablich <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#16}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

This reverts commit 593b0d8.

Reason for revert: broke some branch builders like https://build.chromium.org/p/client.v8.branches/builders/V8%20arm%20-%20sim%20-%20beta%20branch%20-%20debug

Original change's description:
> Merged: Correct the misuse of uloc_{to,from}LanguageTag
> 
> Revision: 69bd294
> 
> Merge to 6.3 branch
> 
> - remove unused Runtime_GetLanguageTagVariants
> - add test for another related bug (chromium:770452) as well as for
> chromium:770450 .
> 
> BUG=chromium:770450,chromium:770452
> LOG=N
> NOTRY=true
> NOPRESUBMIT=true
> NOTREECHECKS=true
> R=​[email protected]
> 
> Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
> Change-Id: Ia2c6dd2156c51995fb18228fc3062a86e78d719c
> Reviewed-on: https://chromium-review.googlesource.com/721844
> Reviewed-by: Adam Klein <[email protected]>
> Commit-Queue: Jungshik Shin <[email protected]>
> Cr-Commit-Position: refs/branch-heads/6.3@{#9}
> Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
> Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected],[email protected],[email protected]

Change-Id: I37018f8241efe1431f453ff55cf8216a5daa66de
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:770450, chromium:770452
Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/723323
Reviewed-by: Michael Hablich <[email protected]>
Commit-Queue: Michael Hablich <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#17}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

This reverts commit d734370.

Reason for revert: broke some branch builders like https://build.chromium.org/p/client.v8.branches/builders/V8%20arm%20-%20sim%20-%20beta%20branch%20-%20debug

Original change's description:
> Merged: Revert "Enable icu-timezone-data by default"
> 
> This reverts commit d9a2584.
> This is for 6.3 branch (to go with Chromium 63 branch). 
> 
> Reason for revert:
> 
> I'm reverting this CL for a few reasons. #2 is the most significant and
> I should have thought of that before making a switch. Sorry for that.
> 
> 1) perf-regression: http://crbug.com/769706
> 2) http://crbug.com/612010 : ICU timezone update is not propagated to
> zygote process so that new tabs will hold on to an old timezone even
> after a timezone change on Linux and Chrome OS.
> 
> 3)  http://crbug.com/754053  : OS timezone detection issues on macOS
> 10.13, Ubutu 16, RHEL 7, SuSe Linux 12 or newer. ; it's being fixed. So,
> it actually ok.
> 
> 4)  http://crbug.com/771868  : timezone wrong in gmail: If it's due to
> 
> Revision: 28ef8dc
> 
> BUG=chromium:612010,chromium:769706,chromium:771868,v8:2137,v8:6031,v8:6076
> LOG=N
> NOTRY=true
> NOPRESUBMIT=true
> NOTREECHECKS=true
> R=​[email protected], [email protected]
> 
> Change-Id: Id0093c2bc69e5bc1d3b7147b7bbcc633ed625a45
> Reviewed-on: https://chromium-review.googlesource.com/721919
> Reviewed-by: Adam Klein <[email protected]>
> Commit-Queue: Jungshik Shin <[email protected]>
> Cr-Commit-Position: refs/branch-heads/6.3@{#7}
> Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
> Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected],[email protected],[email protected]

Change-Id: I8b30f8f9c63b93cb000facbf910ed111ca3f9ab2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:612010, chromium:769706, chromium:771868, v8:2137, v8:6031, v8:6076
Reviewed-on: https://chromium-review.googlesource.com/723324
Reviewed-by: Michael Hablich <[email protected]>
Commit-Queue: Michael Hablich <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#18}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I81602ad8b9219df514418f0f8a9368c0a39183f5
Reviewed-on: https://chromium-review.googlesource.com/723700
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#19}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

…t32Key.

Revision: a3de183

BUG=chromium:774459
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
[email protected]

Change-Id: Ia785eaaa6effe18f31ec59fdb9544ffc36b5195f
Reviewed-on: https://chromium-review.googlesource.com/723593
Reviewed-by: Camillo Bruni <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#20}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

This reverts commit 3b1cfa3.

Reason for revert: ICU was not rolled in 6.3 branch leading invalid-locale test failure (that was added to test an ICU fix). Now, ICU is rolled in 6.3 branch ( https://chromium-review.googlesource.com/c/v8/v8/+/723564 ). 

Original change's description:
> Revert "Merged: Revert "Enable icu-timezone-data by default""
> 
> This reverts commit d734370.
> 
> Reason for revert: broke some branch builders like https://build.chromium.org/p/client.v8.branches/builders/V8%20arm%20-%20sim%20-%20beta%20branch%20-%20debug
> 
> Original change's description:
> > Merged: Revert "Enable icu-timezone-data by default"
> > 
> > This reverts commit d9a2584.
> > This is for 6.3 branch (to go with Chromium 63 branch). 
> > 
> > Reason for revert:
> > 
> > I'm reverting this CL for a few reasons. #2 is the most significant and
> > I should have thought of that before making a switch. Sorry for that.
> > 
> > 1) perf-regression: http://crbug.com/769706
> > 2) http://crbug.com/612010 : ICU timezone update is not propagated to
> > zygote process so that new tabs will hold on to an old timezone even
> > after a timezone change on Linux and Chrome OS.
> > 
> > 3)  http://crbug.com/754053  : OS timezone detection issues on macOS
> > 10.13, Ubutu 16, RHEL 7, SuSe Linux 12 or newer. ; it's being fixed. So,
> > it actually ok.
> > 
> > 4)  http://crbug.com/771868  : timezone wrong in gmail: If it's due to
> > 
> > Revision: 28ef8dc
> > 
> > BUG=chromium:612010,chromium:769706,chromium:771868,v8:2137,v8:6031,v8:6076
> > LOG=N
> > NOTRY=true
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > R=​[email protected], [email protected]
> > 
> > Change-Id: Id0093c2bc69e5bc1d3b7147b7bbcc633ed625a45
> > Reviewed-on: https://chromium-review.googlesource.com/721919
> > Reviewed-by: Adam Klein <[email protected]>
> > Commit-Queue: Jungshik Shin <[email protected]>
> > Cr-Commit-Position: refs/branch-heads/6.3@{#7}
> > Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
> > Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
> 
> [email protected],[email protected],[email protected]
> 
> Change-Id: I8b30f8f9c63b93cb000facbf910ed111ca3f9ab2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:612010, chromium:769706, chromium:771868, v8:2137, v8:6031, v8:6076
> Reviewed-on: https://chromium-review.googlesource.com/723324
> Reviewed-by: Michael Hablich <[email protected]>
> Commit-Queue: Michael Hablich <[email protected]>
> Cr-Commit-Position: refs/branch-heads/6.3@{#18}
> Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
> Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected],[email protected],[email protected]

Change-Id: I8f712f1e6eb1f14c703ffe9f1d63d23b4b4bb08e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:612010, chromium:769706, chromium:771868, v8:2137, v8:6031, v8:6076
Reviewed-on: https://chromium-review.googlesource.com/723962
Reviewed-by: Michael Hablich <[email protected]>
Reviewed-by: Adam Klein <[email protected]>
Commit-Queue: Jungshik Shin <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#21}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

There are only two changes in the roll. This is to match
Chromium M63's ICU in v8's 6.3 branch

 https://chromium.googlesource.com/chromium/deps/icu/+log/08cb9568..21d33b1a

Bug: 770452
Test: See the bug
Change-Id: I63007a5ece0222374a02a958bb04a523f66c78c1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/723564
Commit-Queue: Jungshik Shin <[email protected]>
Reviewed-by: Adam Klein <[email protected]>
Reviewed-by: Michael Hablich <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#22}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

…ag""

This reverts commit 9a132a9.

Reason for revert: ICU was not rolled in 6.3 branch leading invalid-locale test failure (that was added to test an ICU fix). Now, ICU is rolled in 6.3 branch ( https://chromium-review.googlesource.com/c/v8/v8/+/723564 ). 


Original change's description:
> Revert "Merged: Correct the misuse of uloc_{to,from}LanguageTag"
> 
> This reverts commit 593b0d8.
> 
> Reason for revert: broke some branch builders like https://build.chromium.org/p/client.v8.branches/builders/V8%20arm%20-%20sim%20-%20beta%20branch%20-%20debug
> 
> Original change's description:
> > Merged: Correct the misuse of uloc_{to,from}LanguageTag
> > 
> > Revision: 69bd294
> > 
> > Merge to 6.3 branch
> > 
> > - remove unused Runtime_GetLanguageTagVariants
> > - add test for another related bug (chromium:770452) as well as for
> > chromium:770450 .
> > 
> > BUG=chromium:770450,chromium:770452
> > LOG=N
> > NOTRY=true
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > R=​[email protected]
> > 
> > Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
> > Change-Id: Ia2c6dd2156c51995fb18228fc3062a86e78d719c
> > Reviewed-on: https://chromium-review.googlesource.com/721844
> > Reviewed-by: Adam Klein <[email protected]>
> > Commit-Queue: Jungshik Shin <[email protected]>
> > Cr-Commit-Position: refs/branch-heads/6.3@{#9}
> > Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
> > Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
> 
> [email protected],[email protected],[email protected]
> 
> Change-Id: I37018f8241efe1431f453ff55cf8216a5daa66de
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:770450, chromium:770452
> Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
> Reviewed-on: https://chromium-review.googlesource.com/723323
> Reviewed-by: Michael Hablich <[email protected]>
> Commit-Queue: Michael Hablich <[email protected]>
> Cr-Commit-Position: refs/branch-heads/6.3@{#17}
> Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
> Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected],[email protected],[email protected]

Change-Id: Ie7eac96859c8053c4f1b41b0a9b4f79a44883295
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:770450, chromium:770452
Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/723608
Reviewed-by: Michael Hablich <[email protected]>
Reviewed-by: Adam Klein <[email protected]>
Commit-Queue: Jungshik Shin <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#23}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: If830953f0ced61f8470d1d1faf1956fffffd39c5
Reviewed-on: https://chromium-review.googlesource.com/724982
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#24}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

…sing.

When skipping inner funcs is enabled, we also track variables for top level
funcs. Thus, we also declared the function name for the function scope, even
though it was the function scope for a function whose preparsing was
aborted. This lead into declaring the function name twice.

The fix is to declare the function name only in the success case.

The code was "wrong" before too, but this was never a problem, since variable
tracking and aborting preparsing were enabled for disjoint sets of
functions (aborting preparsing only for top-level, and variable tracking for
non-top-level).

BUG=v8:5516,chromium:774475
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: Ie6c321cc834cd946e8843f73916fa7dd75e9cd09
Reviewed-on: https://chromium-review.googlesource.com/720920
Reviewed-by: Toon Verwaest <[email protected]>
Commit-Queue: Marja Hölttä <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#48592}(cherry picked from commit d69159d)
Reviewed-on: https://chromium-review.googlesource.com/728000
Reviewed-by: Michael Hablich <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#25}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

Inner functions which called eval, and were the kind of functions
that can use `super`, were erroneously not marked as "uses_super_property",
leading to downstream crashes when the runtime tried to load the
[[HomeObject]] from them.

This patch eliminates the public Scope::uses_super_property()
API and ensures that callers always call Scope::NeedsHomeObject()
instead.

This is a minimal fix designed for easy merging; it's likely that
in the long run we should remove most mentions of "uses super property"
and replace them with "needs home object" for clarity.

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Bug: v8:5516, chromium:774994
Change-Id: Id269dd33e35bd40f6b59a3d3e19330687afa64f8
Reviewed-on: https://chromium-review.googlesource.com/721879
Reviewed-by: Marja Hölttä <[email protected]>
Commit-Queue: Adam Klein <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#48619}(cherry picked from commit 94a71d7)
Reviewed-on: https://chromium-review.googlesource.com/727762
Reviewed-by: Michael Hablich <[email protected]>
Commit-Queue: Marja Hölttä <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#26}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I5008b819ac6a5b89af2f8981268d6364bc545b66
Reviewed-on: https://chromium-review.googlesource.com/728040
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#27}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

This cherry-picks:
https://chromium-review.googlesource.com/c/v8/v8/+/725706
https://chromium-review.googlesource.com/c/v8/v8/+/727800
https://chromium-review.googlesource.com/c/v8/v8/+/728023

NOTRY=true
NOPRESUBMIT=true

Bug: v8:6917
Change-Id: If89a30f9d6548d9402ebad6bcef5b0d5f50802b2
Reviewed-on: https://chromium-review.googlesource.com/727205
Reviewed-by: Sergiy Byelozyorov <[email protected]>
Commit-Queue: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#28}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}

[email protected]

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ife4392a3dd9e6ca19a71fa23927e23f8b52b41f2
Reviewed-on: https://chromium-review.googlesource.com/727943
Reviewed-by: v8 autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/6.3@{#29}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}