Repository navigation
Conversions to SkyCoordinates should use astropy machinery for ICRS->GCRS conversion - #1
Open
StuartLittlefair wants to merge 300 commits into
Open
StuartLittlefair wants to merge 300 commits into
StuartLittlefair wants to merge 300 commits into
Conversation
Angular diameter distance for positive curvature (astropy#4723)
The axis argument was added in astropy#3792 and is passed correctly to sigma_clip, but then mean, median and std did not use axis and were computed on the whole array. This commit changes this to use axis to compute the statistics. Also another minor annoyance is that, with Numpy 1.10, np.ma.median always return a MaskedArray, even when axis is None. This was not the case in previous version (and will probably be fixed in the future), and mean and std return a scalar. So if it happens here, we take the first element of the array.
Fix sigma_clipped_stats to use the axis argument
Allow using a tuple of keys in Table.sort
Update equivalencies.py
…y powers. Also fixes a problem with lists as input to ufuncs.
Ensure that scaled dimensionless quantities can be raised to arbitrary powers.
fixed wrong rendered changelog entry and contributor name [skip ci]
Fixed indentation problem with author name
…rPower_fix Allow base with dimensionless quantity as base for np.power.
added bayesian information criterion and akaike information criterion
Compatibility code for Numpy 1.7 wasn't removed, so keep it for now.
Ref astropy#2824 an older bug report. On Python 3 `ResourceWarning` warnings were raised because the FITS convenience methods (`getdata`, `getheader`, `append`, `update`) were not closing files as they were supposed to.
Remove unnecessary sort when defining __all__
…d expose publically available bodies
…was used for earth and solar system body
bmorris3
pushed a commit
that referenced
this pull request
Jul 3, 2016
Finalizes attribute and frame naming conventions for AstrometricFrame and subclasses.
bmorris3
pushed a commit
that referenced
this pull request
Apr 29, 2017
fixes for test_wcs. Yields removed to get rid of deprecation warnings in pytest3 and be compatible with pytest4
bmorris3
pushed a commit
that referenced
this pull request
Apr 29, 2017
Remove unit checks that are irrelevant for the bug fix.
bmorris3
pushed a commit
that referenced
this pull request
Apr 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested I've submitted a PR for changes so that the conversion from barycentric coordinates returned by the JPL ephemeris to the GCRS coordinates needed to create a SkyCoord for the apparent planet position is handled by the astropy coordinate transformation machinery.
The easiest way for me to do that was to change
_get_absolute_planet_positionto_get_barycentric_planet_positionand to add a new routine to get the vector and distance between the Earth and the requested planet. This in turn suggested a change in the planet indexing convention.